Skip to content

ZEPPELIN-331 Don't update back the browser where updated the angular object - #341

Closed
Leemoonsoo wants to merge 5 commits into
apache:masterfrom
Leemoonsoo:ZEPPELIN-331
Closed

ZEPPELIN-331 Don't update back the browser where updated the angular object#341
Leemoonsoo wants to merge 5 commits into
apache:masterfrom
Leemoonsoo:ZEPPELIN-331

Conversation

@Leemoonsoo

Copy link
Copy Markdown
Member

This PR fixes problem described in
https://issues.apache.org/jira/browse/ZEPPELIN-331

By excluding the webbrowser who created the angular object update event from broadcast target.

  • exclude from broadcast
  • add unittest

@LeemoonsooLeemoonsoo changed the title Don't update back the browser where updated the angular objectZEPPELIN-331 Don't update back the browser where updated the angular objectOct 13, 2015
@corneadoug

Copy link
Copy Markdown
Contributor

Do you know how to reproduce that issue?

@Leemoonsoo

Copy link
Copy Markdown
MemberAuthor

You can easily reproduce when there are big network latency between your browser and zeppelin server.

@Leemoonsoo
Leemoonsooforce-pushed the ZEPPELIN-331 branch 2 times, most recently from 114eecf to ad8657dCompareOctober 18, 2015 10:19
@Leemoonsoo
Leemoonsooforce-pushed the ZEPPELIN-331 branch 6 times, most recently from 2c10cbb to 7f370fcCompareNovember 7, 2015 16:11
@Leemoonsoo

Copy link
Copy Markdown
MemberAuthor

Ready to merge

@Leemoonsoo

Copy link
Copy Markdown
MemberAuthor

Merge if there're no more discussions

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You'd better change the level of this log to debug. I saw the issue to change it with this kind of logs

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for finding this one. update pushed.

@Leemoonsoo
Leemoonsooforce-pushed the ZEPPELIN-331 branch 3 times, most recently from b99186d to cd45a7fCompareNovember 14, 2015 11:39
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@Leemoonsoo@corneadoug@jongyoul