Skip to content

ZEPPELIN-360 Remove "Copyright 2014, NFLabs inc." from LICENSE - #364

Closed
Leemoonsoo wants to merge 2 commits into
apache:masterfrom
Leemoonsoo:ZEPPELIN-360
Closed

ZEPPELIN-360 Remove "Copyright 2014, NFLabs inc." from LICENSE#364
Leemoonsoo wants to merge 2 commits into
apache:masterfrom
Leemoonsoo:ZEPPELIN-360

Conversation

@Leemoonsoo

Copy link
Copy Markdown
Member

This PR addresses https://issues.apache.org/jira/browse/ZEPPELIN-360
Removing "Copyright 2014, NFLabs inc." from LICENSE.

Comment threadLICENSE

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Leemoonsoo Is it enough? Will it be filled automatically?

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked some TLPs to see how they do. And looks like it's enough. I'm also curious if it is enough (and why).

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I'm also curious :)

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can one of our mentors clarify it?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This section is talking about "How to apply the Apache License to your work."

 APPENDIX: How to apply the Apache License to your work. To apply the Apache License to your work, attach the following boilerplate notice, with the fields enclosed by brackets "[]" replaced with your own identifying information. (Don't include the brackets!) The text should be enclosed in the appropriate comment syntax for the file format. We also recommend that a file or class name and description of purpose be included on the same "printed page" as the copyright notice for easier identification within third-party archives. ```
So I think [yyyy] [name of copyright owner] is indeed correct.

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I'm merging it.

@felixcheung

Copy link
Copy Markdown
Member

looks good? :)

lelou6666 pushed a commit to lelou6666/incubator-zeppelin that referenced this pull request Mar 25, 2016
soralee pushed a commit to soralee/zeppelin that referenced this pull request Feb 9, 2017
Update documentation for separate interpreter process apache#364
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@Leemoonsoo@felixcheung@jongyoul