Uh oh!
There was an error while loading. Please reload this page.
[ZEPPELIN-49] Interpreter.getProperty returns wrong value - #41
Conversation
jongyoul
commented
Apr 16, 2015
- Fixed to return p, not property
- Fixed to return p, not property
RamVenkatesh
commented
Apr 16, 2015
LGTM! |
jongyoul
commented
Apr 17, 2015
@RamVenkatesh Thanks. |
bzz
commented
Apr 17, 2015
Looks great! |
jongyoul
commented
Apr 17, 2015
@bzz Do you want to test the method of Interpreter.getProperty itself? It can help make sample subclass of Interpreter including static register codes and then make an instance with some properties and and them manually. Do you think it is good? |
bzz
commented
Apr 17, 2015
@jongyoul That would be great, but this sounds too complicated for such a change.. Do you think it worth doing now? |
jongyoul
commented
Apr 17, 2015
If we have a plan to change an implementation of Interpreter, it would be good. Otherwise, it's a little tricky. Please tell me your plan. |
bzz
commented
Apr 17, 2015
I agree, lets address it in separate PR later, in case we actually need it. |
bzz
commented
Apr 17, 2015
Merging this one if there is no discussion |