Uh oh!
There was an error while loading. Please reload this page.
ZEPPELIN-5536 Update protoc and grpc for Linux ARM64 - #4233
Conversation
Update protoc and grpc to their first versions that support Linux ARM64 architecture. With this the build on Linux ARM64 passes!
Actually the build passes only if I disable the tests for the web app module, because they use PhantomJS which has no binary for Linux aarch64, and since PhantomJS is a dead project it will never have such officially. |
jongyoul
commented
Sep 24, 2021
@martin-g Hello, I might not understand what you are saying but could you please explain more about PhantomJS and the result of this CI? It looks like all passed without disabling anything. |
martin-g
commented
Sep 24, 2021
The CI passed because GitHub Actions run on x86_64 machines. |
@martin-g Thank you for explaining it. I also think |
zjffdu
commented
Sep 24, 2021
@martin-g Do you know whether GitHub Actions support ARM64 ? If so, we should enable it to avoid regression. |
martin-g
commented
Sep 25, 2021
I could try to replace it with headless Chromium! I'll keep you posted! |
jongyoul
commented
Sep 25, 2021
Sounds like a great idea!! Thank you!! |
martin-g
commented
Sep 25, 2021
GitHub Actions does not provide Linux ARM64 VMs at the moment (actions/runner-images#2536).
Other projects use TravisCI or CircleCI (my recommendation) for testing on Linux ARM64/PPC64/s390x. The issue is - one more CI to maintain and watch over. |
Thanks @martin-g for the investigation, I checked CircleCI. But it seems not free like github action. We have to think about other options. It could be done in another PR future. Regarding this PR, LGTM +1 |
CircleCI is free for public repos. |
martin-g
commented
Sep 26, 2021
@jongyoul I will work on it in a separate PR! |
zjffdu
commented
Sep 27, 2021
ha, right, CircleCI has free plan for open source project. |
martin-g
commented
Sep 27, 2021
@zjffdu I will prepare a PR for testing on Linux ARM64 at CircleCI! |
zjffdu
commented
Sep 27, 2021
Thanks @martin-g I will merge this PR if no more comment |
### What is this PR for? Update protoc and grpc to their first versions that support Linux ARM64 architecture. With this the build on Linux ARM64 passes! ### What type of PR is it? Bug Fix ### What is the Jira issue? [ZEPPELIN-5536](https://issues.apache.org/jira/browse/ZEPPELIN-5536) ### How should this be tested? Run the build on Linux ARM64, e.g. at TravisCI or even better CircleCI on ARM64 hardware! Let me know if you want me to setup either of those! ### Questions: * Does the licenses files need update? - NO * Is there breaking changes for older versions? - Hopefully not! There is one API break in Grpc APIs (`usePlaintext()`), but there might be problems in reading serialized messages with the old versions * Does this needs documentation? - NO Author: Martin Tzvetanov Grigorov <mgrigorov@apache.org> Closes#4233 from martin-g/update-protobuf-and-grpc and squashes the following commits: 60b0c1d [Martin Tzvetanov Grigorov] ZEPPELIN-5536 Update protoc and grpc for Linux ARM64 (cherry picked from commit a1fe668) Signed-off-by: Jeff Zhang <zjffdu@apache.org>
### What is this PR for? Update protoc and grpc to their first versions that support Linux ARM64 architecture. With this the build on Linux ARM64 passes! ### What type of PR is it? Bug Fix ### What is the Jira issue? [ZEPPELIN-5536](https://issues.apache.org/jira/browse/ZEPPELIN-5536) ### How should this be tested? Run the build on Linux ARM64, e.g. at TravisCI or even better CircleCI on ARM64 hardware! Let me know if you want me to setup either of those! ### Questions: * Does the licenses files need update? - NO * Is there breaking changes for older versions? - Hopefully not! There is one API break in Grpc APIs (`usePlaintext()`), but there might be problems in reading serialized messages with the old versions * Does this needs documentation? - NO Author: Martin Tzvetanov Grigorov <mgrigorov@apache.org> Closesapache#4233 from martin-g/update-protobuf-and-grpc and squashes the following commits: 60b0c1d [Martin Tzvetanov Grigorov] ZEPPELIN-5536 Update protoc and grpc for Linux ARM64
### What is this PR for? Update protoc and grpc to their first versions that support Linux ARM64 architecture. With this the build on Linux ARM64 passes! ### What type of PR is it? Bug Fix ### What is the Jira issue? [ZEPPELIN-5536](https://issues.apache.org/jira/browse/ZEPPELIN-5536) ### How should this be tested? Run the build on Linux ARM64, e.g. at TravisCI or even better CircleCI on ARM64 hardware! Let me know if you want me to setup either of those! ### Questions: * Does the licenses files need update? - NO * Is there breaking changes for older versions? - Hopefully not! There is one API break in Grpc APIs (`usePlaintext()`), but there might be problems in reading serialized messages with the old versions * Does this needs documentation? - NO Author: Martin Tzvetanov Grigorov <mgrigorov@apache.org> Closesapache#4233 from martin-g/update-protobuf-and-grpc and squashes the following commits: 60b0c1d [Martin Tzvetanov Grigorov] ZEPPELIN-5536 Update protoc and grpc for Linux ARM64
### What is this PR for? Update protoc and grpc to their first versions that support Linux ARM64 architecture. With this the build on Linux ARM64 passes! ### What type of PR is it? Bug Fix ### What is the Jira issue? [ZEPPELIN-5536](https://issues.apache.org/jira/browse/ZEPPELIN-5536) ### How should this be tested? Run the build on Linux ARM64, e.g. at TravisCI or even better CircleCI on ARM64 hardware! Let me know if you want me to setup either of those! ### Questions: * Does the licenses files need update? - NO * Is there breaking changes for older versions? - Hopefully not! There is one API break in Grpc APIs (`usePlaintext()`), but there might be problems in reading serialized messages with the old versions * Does this needs documentation? - NO Author: Martin Tzvetanov Grigorov <mgrigorov@apache.org> Closesapache#4233 from martin-g/update-protobuf-and-grpc and squashes the following commits: 60b0c1d [Martin Tzvetanov Grigorov] ZEPPELIN-5536 Update protoc and grpc for Linux ARM64
What is this PR for?
Update protoc and grpc to their first versions that support Linux ARM64 architecture.
With this the build on Linux ARM64 passes!
What type of PR is it?
Bug Fix
What is the Jira issue?
ZEPPELIN-5536
How should this be tested?
Run the build on Linux ARM64, e.g. at TravisCI or even better CircleCI on ARM64 hardware!
Let me know if you want me to setup either of those!
Questions:
usePlaintext()), but there might be problems in reading serialized messages with the old versions