Skip to content

[WIP] Fix notebook clone bug - #458

Closed
minahlee wants to merge 1 commit into
apache:masterfrom
minahlee:fix/clone
Closed

[WIP] Fix notebook clone bug#458
minahlee wants to merge 1 commit into
apache:masterfrom
minahlee:fix/clone

Conversation

@minahlee

Copy link
Copy Markdown
Member

Handle exception when paragraph's getReturn method returns unparseable object.

@bzz

bzz commented Nov 22, 2015

Copy link
Copy Markdown
Member

Looks great, but how complicated is it to reproduce this bug?
If there is a simple case, it might be worth adding a test too.

Also a bit of explanation in comments in case of empty catch block (i.e why is it ok to ignore it here) is of a good style

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does result == null cause problem to paragraph.setReturn?

@bzz

bzz commented Jan 5, 2016

Copy link
Copy Markdown
Member

Looks like build failed due to networking issue on downloading mvn dependencies. Should not be reproducible.

@minahleeminahlee changed the title Fix notebook clone bug[WIP] Fix notebook clone bugJan 5, 2016
@minahlee

Copy link
Copy Markdown
MemberAuthor

Duplicated with #933

@minahlee
minahlee deleted the fix/clone branch June 21, 2016 19:02
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@minahlee@bzz@felixcheung