Skip to content

[ZEPPELIN-6206] Fix notebook paths in job manager page - #4951

Merged
Reamer merged 1 commit into
apache:masterfrom
tbonelee:fix-notebook-path
Jun 30, 2025
Merged

[ZEPPELIN-6206] Fix notebook paths in job manager page#4951
Reamer merged 1 commit into
apache:masterfrom
tbonelee:fix-notebook-path

Conversation

@tbonelee

Copy link
Copy Markdown
Contributor

What is this PR for?

URLs to notebook page are set wrong in job manager page

What type of PR is it?

Bug Fix

What is the Jira issue?

https://issues.apache.org/jira/browse/ZEPPELIN-6206

How should this be tested?

  • Enable cron and job manager configurations and check a links in the page
    • zeppelin.jobmanager.enable : true
    • zeppelin.notebook.cron.enable: true
    • zeppelin.notebook.cron.folders : /
      image

Questions:

  • Does the license files need to update? No
  • Is there breaking changes for older versions? No
  • Does this needs documentation? No

@Reamer

Copy link
Copy Markdown
Contributor

Perhaps this is related to #4947
What do you think?

@tbonelee

Copy link
Copy Markdown
ContributorAuthor

@Reamer
Thanks Reamer! I had a look at #4947, and while both involve notebook paths, I believe the issues are different.

That one addresses URI-encoded names, whereas this PR fixes a routing issue in Angular, where links were generated as relative paths instead of root-based, leading to incorrect URLs under nested routes like /#/jobmanager.

So while they seem related in topic, I think the underlying causes and fixes are different.

@ParkGyeongTae

Copy link
Copy Markdown
Member

👍 LGTM

@ReamerReamer left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the correction

@ReamerReamer self-assigned this Jun 30, 2025
@Reamer
Reamer merged commit 1ca383e into apache:masterJun 30, 2025
asf-gitbox-commits pushed a commit that referenced this pull request Jun 30, 2025
### What is this PR for?
URLs to notebook page are set wrong in job manager page
### What type of PR is it?
Bug Fix
### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-6206
### How should this be tested?
- Enable cron and job manager configurations and check a links in the page
- `zeppelin.jobmanager.enable` : `true`
- `zeppelin.notebook.cron.enable`: `true`
- `zeppelin.notebook.cron.folders` : `/`
![image](https://github.com/user-attachments/assets/19f77891-a40a-4d6a-be56-beb8ad4bff27)
### Questions:
* Does the license files need to update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No
Closes#4951 from tbonelee/fix-notebook-path.
Signed-off-by: Philipp Dallig <philipp.dallig@gmail.com>
(cherry picked from commit 1ca383e)
Signed-off-by: Philipp Dallig <philipp.dallig@gmail.com>
@Reamer

Copy link
Copy Markdown
Contributor

Merged into master and branch-0.12

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@tbonelee@Reamer@ParkGyeongTae