[ZEPPELIN-6281] Add Unit Tests for LivyVersion Class by celinayk · Pull Request #5029 · apache/zeppelin

celinayk · 2025-08-16T08:43:12Z

What is this PR for?

This PR adds a comprehensive suite of unit tests for the LivyVersion class. The LivyVersion class is critical for ensuring Zeppelin's compatibility with various versions of the Livy server.

What type of PR is it?

Test

Todos

Add LivyVersionTest.java with comprehensive test cases.
Ensure all tests pass with the existing LivyVersion implementation.

What is the Jira issue?

ZEPPELIN-6281

How should this be tested?

Screenshots (if appropriate)

Questions:

Does the license files need to update? No
Is there breaking changes for older versions? No
Does this needs documentation? No

ParkGyeongTae · 2025-08-19T13:06:00Z

+
+import org.junit.jupiter.api.Test;
+
+import static org.junit.jupiter.api.Assertions.*;


Could you update this to avoid the wildcard import and use explicit imports for the Assertions methods being used?

Thanks for pointing that out!! I'll update the code to remove the wildcard and explicitly import only the Assertions methods that are used in the test.

ParkGyeongTae

Please make the minor changes I commented on.

…s in LivyVersionTest

celinayk · 2025-08-19T13:24:38Z

Please make the minor changes I commented on.

Done. Thank you!

Reamer

Just a minor thing, everthing else looks good

Reamer

LGTM

Reamer · 2025-08-20T06:33:30Z

There are several checkstyle errors.

[INFO] --- checkstyle:3.4.0:check (checkstyle-fail-build) @ zeppelin-livy ---
[INFO] There are 36 errors reported by Checkstyle 9.3 with zeppelin/checkstyle.xml ruleset.
Error: src/test/java/org/apache/zeppelin/livy/LivyVersionTest.java:[27,5] (indentation) Indentation: 'method def modifier' has incorrect indentation level 4, expected level should be 2.
Error: src/test/java/org/apache/zeppelin/livy/LivyVersionTest.java:[29,9] (indentation) Indentation: 'method def' child has incorrect indentation level 8, expected level should be 4.
Error: src/test/java/org/apache/zeppelin/livy/LivyVersionTest.java:[30,9] (indentation) Indentation: 'method def' child has incorrect indentation level 8, expected level should be 4.
Error: src/test/java/org/apache/zeppelin/livy/LivyVersionTest.java:[31,9] (indentation) Indentation: 'method def' child has incorrect indentation level 8, expected level should be 4.
Error: src/test/java/org/apache/zeppelin/livy/LivyVersionTest.java:[32,5] (indentation) Indentation: 'method def rcurly' has incorrect indentation level 4, expected level should be 2.
Error: src/test/java/org/apache/zeppelin/livy/LivyVersionTest.java:[34,5] (indentation) Indentation: 'method def modifier' has incorrect indentation level 4, expected level should be 2.
Error: src/test/java/org/apache/zeppelin/livy/LivyVersionTest.java:[36,9] (indentation) Indentation: 'method def' child has incorrect indentation level 8, expected level should be 4.
Error: src/test/java/org/apache/zeppelin/livy/LivyVersionTest.java:[37,9] (indentation) Indentation: 'method def' child has incorrect indentation level 8, expected level should be 4.
Error: src/test/java/org/apache/zeppelin/livy/LivyVersionTest.java:[38,9] (indentation) Indentation: 'method def' child has incorrect indentation level 8, expected level should be 4.
Error: src/test/java/org/apache/zeppelin/livy/LivyVersionTest.java:[39,5] (indentation) Indentation: 'method def rcurly' has incorrect indentation level 4, expected level should be 2.
Error: src/test/java/org/apache/zeppelin/livy/LivyVersionTest.java:[41,5] (indentation) Indentation: 'method def modifier' has incorrect indentation level 4, expected level should be 2.
Error: src/test/java/org/apache/zeppelin/livy/LivyVersionTest.java:[43,9] (indentation) Indentation: 'method def' child has incorrect indentation level 8, expected level should be 4.
Error: src/test/java/org/apache/zeppelin/livy/LivyVersionTest.java:[44,9] (indentation) Indentation: 'method def' child has incorrect indentation level 8, expected level should be 4.
Error: src/test/java/org/apache/zeppelin/livy/LivyVersionTest.java:[45,9] (indentation) Indentation: 'method def' child has incorrect indentation level 8, expected level should be 4.
Error: src/test/java/org/apache/zeppelin/livy/LivyVersionTest.java:[46,9] (indentation) Indentation: 'method def' child has incorrect indentation level 8, expected level should be 4.
Error: src/test/java/org/apache/zeppelin/livy/LivyVersionTest.java:[47,9] (indentation) Indentation: 'method def' child has incorrect indentation level 8, expected level should be 4.
Error: src/test/java/org/apache/zeppelin/livy/LivyVersionTest.java:[48,9] (indentation) Indentation: 'method def' child has incorrect indentation level 8, expected level should be 4.
Error: src/test/java/org/apache/zeppelin/livy/LivyVersionTest.java:[49,5] (indentation) Indentation: 'method def rcurly' has incorrect indentation level 4, expected level should be 2.
Error: src/test/java/org/apache/zeppelin/livy/LivyVersionTest.java:[51,5] (indentation) Indentation: 'method def modifier' has incorrect indentation level 4, expected level should be 2.
Error: src/test/java/org/apache/zeppelin/livy/LivyVersionTest.java:[53,9] (indentation) Indentation: 'method def' child has incorrect indentation level 8, expected level should be 4.
Error: src/test/java/org/apache/zeppelin/livy/LivyVersionTest.java:[54,9] (indentation) Indentation: 'method def' child has incorrect indentation level 8, expected level should be 4.
Error: src/test/java/org/apache/zeppelin/livy/LivyVersionTest.java:[56,9] (indentation) Indentation: 'method def' child has incorrect indentation level 8, expected level should be 4.
Error: src/test/java/org/apache/zeppelin/livy/LivyVersionTest.java:[57,9] (indentation) Indentation: 'method def' child has incorrect indentation level 8, expected level should be 4.
Error: src/test/java/org/apache/zeppelin/livy/LivyVersionTest.java:[58,5] (indentation) Indentation: 'method def rcurly' has incorrect indentation level 4, expected level should be 2.
Error: src/test/java/org/apache/zeppelin/livy/LivyVersionTest.java:[60,5] (indentation) Indentation: 'method def modifier' has incorrect indentation level 4, expected level should be 2.
Error: src/test/java/org/apache/zeppelin/livy/LivyVersionTest.java:[62,9] (indentation) Indentation: 'method def' child has incorrect indentation level 8, expected level should be 4.
Error: src/test/java/org/apache/zeppelin/livy/LivyVersionTest.java:[63,9] (indentation) Indentation: 'method def' child has incorrect indentation level 8, expected level should be 4.
Error: src/test/java/org/apache/zeppelin/livy/LivyVersionTest.java:[64,5] (indentation) Indentation: 'method def rcurly' has incorrect indentation level 4, expected level should be 2.
Error: src/test/java/org/apache/zeppelin/livy/LivyVersionTest.java:[66,5] (indentation) Indentation: 'method def modifier' has incorrect indentation level 4, expected level should be 2.
Error: src/test/java/org/apache/zeppelin/livy/LivyVersionTest.java:[68,9] (indentation) Indentation: 'method def' child has incorrect indentation level 8, expected level should be 4.
Error: src/test/java/org/apache/zeppelin/livy/LivyVersionTest.java:[69,9] (indentation) Indentation: 'method def' child has incorrect indentation level 8, expected level should be 4.
Error: src/test/java/org/apache/zeppelin/livy/LivyVersionTest.java:[70,5] (indentation) Indentation: 'method def rcurly' has incorrect indentation level 4, expected level should be 2.
Error: src/test/java/org/apache/zeppelin/livy/LivyVersionTest.java:[72,5] (indentation) Indentation: 'method def modifier' has incorrect indentation level 4, expected level should be 2.
Error: src/test/java/org/apache/zeppelin/livy/LivyVersionTest.java:[74,9] (indentation) Indentation: 'method def' child has incorrect indentation level 8, expected level should be 4.
Error: src/test/java/org/apache/zeppelin/livy/LivyVersionTest.java:[75,9] (indentation) Indentation: 'method def' child has incorrect indentation level 8, expected level should be 4.
Error: src/test/java/org/apache/zeppelin/livy/LivyVersionTest.java:[76,5] (indentation) Indentation: 'method def rcurly' has incorrect indentation level 4, expected level should be 2.

celinayk · 2025-08-20T10:39:07Z

There are several checkstyle errors.

[INFO] --- checkstyle:3.4.0:check (checkstyle-fail-build) @ zeppelin-livy ---
[INFO] There are 36 errors reported by Checkstyle 9.3 with zeppelin/checkstyle.xml ruleset.
Error: src/test/java/org/apache/zeppelin/livy/LivyVersionTest.java:[27,5] (indentation) Indentation: 'method def modifier' has incorrect indentation level 4, expected level should be 2.
Error: src/test/java/org/apache/zeppelin/livy/LivyVersionTest.java:[29,9] (indentation) Indentation: 'method def' child has incorrect indentation level 8, expected level should be 4.
Error: src/test/java/org/apache/zeppelin/livy/LivyVersionTest.java:[30,9] (indentation) Indentation: 'method def' child has incorrect indentation level 8, expected level should be 4.
Error: src/test/java/org/apache/zeppelin/livy/LivyVersionTest.java:[31,9] (indentation) Indentation: 'method def' child has incorrect indentation level 8, expected level should be 4.
Error: src/test/java/org/apache/zeppelin/livy/LivyVersionTest.java:[32,5] (indentation) Indentation: 'method def rcurly' has incorrect indentation level 4, expected level should be 2.
Error: src/test/java/org/apache/zeppelin/livy/LivyVersionTest.java:[34,5] (indentation) Indentation: 'method def modifier' has incorrect indentation level 4, expected level should be 2.
Error: src/test/java/org/apache/zeppelin/livy/LivyVersionTest.java:[36,9] (indentation) Indentation: 'method def' child has incorrect indentation level 8, expected level should be 4.
Error: src/test/java/org/apache/zeppelin/livy/LivyVersionTest.java:[37,9] (indentation) Indentation: 'method def' child has incorrect indentation level 8, expected level should be 4.
Error: src/test/java/org/apache/zeppelin/livy/LivyVersionTest.java:[38,9] (indentation) Indentation: 'method def' child has incorrect indentation level 8, expected level should be 4.
Error: src/test/java/org/apache/zeppelin/livy/LivyVersionTest.java:[39,5] (indentation) Indentation: 'method def rcurly' has incorrect indentation level 4, expected level should be 2.
Error: src/test/java/org/apache/zeppelin/livy/LivyVersionTest.java:[41,5] (indentation) Indentation: 'method def modifier' has incorrect indentation level 4, expected level should be 2.
Error: src/test/java/org/apache/zeppelin/livy/LivyVersionTest.java:[43,9] (indentation) Indentation: 'method def' child has incorrect indentation level 8, expected level should be 4.
Error: src/test/java/org/apache/zeppelin/livy/LivyVersionTest.java:[44,9] (indentation) Indentation: 'method def' child has incorrect indentation level 8, expected level should be 4.
Error: src/test/java/org/apache/zeppelin/livy/LivyVersionTest.java:[45,9] (indentation) Indentation: 'method def' child has incorrect indentation level 8, expected level should be 4.
Error: src/test/java/org/apache/zeppelin/livy/LivyVersionTest.java:[46,9] (indentation) Indentation: 'method def' child has incorrect indentation level 8, expected level should be 4.
Error: src/test/java/org/apache/zeppelin/livy/LivyVersionTest.java:[47,9] (indentation) Indentation: 'method def' child has incorrect indentation level 8, expected level should be 4.
Error: src/test/java/org/apache/zeppelin/livy/LivyVersionTest.java:[48,9] (indentation) Indentation: 'method def' child has incorrect indentation level 8, expected level should be 4.
Error: src/test/java/org/apache/zeppelin/livy/LivyVersionTest.java:[49,5] (indentation) Indentation: 'method def rcurly' has incorrect indentation level 4, expected level should be 2.
Error: src/test/java/org/apache/zeppelin/livy/LivyVersionTest.java:[51,5] (indentation) Indentation: 'method def modifier' has incorrect indentation level 4, expected level should be 2.
Error: src/test/java/org/apache/zeppelin/livy/LivyVersionTest.java:[53,9] (indentation) Indentation: 'method def' child has incorrect indentation level 8, expected level should be 4.
Error: src/test/java/org/apache/zeppelin/livy/LivyVersionTest.java:[54,9] (indentation) Indentation: 'method def' child has incorrect indentation level 8, expected level should be 4.
Error: src/test/java/org/apache/zeppelin/livy/LivyVersionTest.java:[56,9] (indentation) Indentation: 'method def' child has incorrect indentation level 8, expected level should be 4.
Error: src/test/java/org/apache/zeppelin/livy/LivyVersionTest.java:[57,9] (indentation) Indentation: 'method def' child has incorrect indentation level 8, expected level should be 4.
Error: src/test/java/org/apache/zeppelin/livy/LivyVersionTest.java:[58,5] (indentation) Indentation: 'method def rcurly' has incorrect indentation level 4, expected level should be 2.
Error: src/test/java/org/apache/zeppelin/livy/LivyVersionTest.java:[60,5] (indentation) Indentation: 'method def modifier' has incorrect indentation level 4, expected level should be 2.
Error: src/test/java/org/apache/zeppelin/livy/LivyVersionTest.java:[62,9] (indentation) Indentation: 'method def' child has incorrect indentation level 8, expected level should be 4.
Error: src/test/java/org/apache/zeppelin/livy/LivyVersionTest.java:[63,9] (indentation) Indentation: 'method def' child has incorrect indentation level 8, expected level should be 4.
Error: src/test/java/org/apache/zeppelin/livy/LivyVersionTest.java:[64,5] (indentation) Indentation: 'method def rcurly' has incorrect indentation level 4, expected level should be 2.
Error: src/test/java/org/apache/zeppelin/livy/LivyVersionTest.java:[66,5] (indentation) Indentation: 'method def modifier' has incorrect indentation level 4, expected level should be 2.
Error: src/test/java/org/apache/zeppelin/livy/LivyVersionTest.java:[68,9] (indentation) Indentation: 'method def' child has incorrect indentation level 8, expected level should be 4.
Error: src/test/java/org/apache/zeppelin/livy/LivyVersionTest.java:[69,9] (indentation) Indentation: 'method def' child has incorrect indentation level 8, expected level should be 4.
Error: src/test/java/org/apache/zeppelin/livy/LivyVersionTest.java:[70,5] (indentation) Indentation: 'method def rcurly' has incorrect indentation level 4, expected level should be 2.
Error: src/test/java/org/apache/zeppelin/livy/LivyVersionTest.java:[72,5] (indentation) Indentation: 'method def modifier' has incorrect indentation level 4, expected level should be 2.
Error: src/test/java/org/apache/zeppelin/livy/LivyVersionTest.java:[74,9] (indentation) Indentation: 'method def' child has incorrect indentation level 8, expected level should be 4.
Error: src/test/java/org/apache/zeppelin/livy/LivyVersionTest.java:[75,9] (indentation) Indentation: 'method def' child has incorrect indentation level 8, expected level should be 4.
Error: src/test/java/org/apache/zeppelin/livy/LivyVersionTest.java:[76,5] (indentation) Indentation: 'method def rcurly' has incorrect indentation level 4, expected level should be 2.

Thank you for your feedback !

ParkGyeongTae

👍 LGTM

### What is this PR for? This PR adds a comprehensive suite of unit tests for the LivyVersion class. The LivyVersion class is critical for ensuring Zeppelin's compatibility with various versions of the Livy server. ### What type of PR is it? Test ### Todos * [x] Add LivyVersionTest.java with comprehensive test cases. * [x] Ensure all tests pass with the existing LivyVersion implementation. ### What is the Jira issue? [ZEPPELIN-6281](https://issues.apache.org/jira/browse/ZEPPELIN-6281) ### How should this be tested? ### Screenshots (if appropriate) ### Questions: * Does the license files need to update? No * Is there breaking changes for older versions? No * Does this needs documentation? No Closes#5029 from celinayk/ZEPPELIN-6281. Signed-off-by: ParkGyeongTae <gyeongtae@apache.org>

ParkGyeongTae · 2025-08-22T13:49:27Z

Merged into master and branch-0.12

[ZEPPELIN-6281] Add Unit Tests for LivyVersion Class
9d366a2

ParkGyeongTae reviewed Aug 19, 2025
View reviewed changes

Comment threadlivy/src/test/java/org/apache/zeppelin/livy/LivyVersionTest.java

ParkGyeongTae reviewed Aug 19, 2025
View reviewed changes

ParkGyeongTae requested changes Aug 19, 2025
View reviewed changes

[ZEPPELIN-6281] Add Apache license header and replace wildcard import…
017ad90
…s in LivyVersionTest

Reamer requested changes Aug 19, 2025
View reviewed changes

Comment threadlivy/src/test/java/org/apache/zeppelin/livy/LivyVersionTest.java Outdated

Reamer self-assigned this Aug 19, 2025

celinayk added 3 commits August 19, 2025 23:31

[ZEPPELIN-6281] Add newline at end of LivyVersionTest.java
8349072

[ZEPPELIN-6281] Add 1 newline at end of LivyVersionTest.java
ed8791d

[ZEPPELIN-6281] Add only 1 newline at end of LivyVersionTest.java
301ef61

Reamer previously approved these changes Aug 20, 2025
View reviewed changes

[ZEPPELIN-6281] checkstyle edit of LivyVersionTest.java
0d8d997

celinayk dismissed Reamer’s stale review via 0d8d997August 20, 2025 10:37

[ZEPPELIN-6281] separate the license header of LivyVersionTest.java
792ea8b

Reamer approved these changes Aug 21, 2025
View reviewed changes

Reamer requested a review from ParkGyeongTae August 21, 2025 06:40

ParkGyeongTae approved these changes Aug 22, 2025
View reviewed changes

ParkGyeongTae merged commit f68d69b into apache:masterAug 22, 2025
28 of 33 checks passed

Navigation Menu

Uh oh!

[ZEPPELIN-6281] Add Unit Tests for LivyVersion Class - #5029

[ZEPPELIN-6281] Add Unit Tests for LivyVersion Class#5029
ParkGyeongTae merged 7 commits into
apache:masterfrom
celinayk:ZEPPELIN-6281

celinayk commented Aug 16, 2025

Uh oh!

Uh oh!

ParkGyeongTaeAug 19, 2025

Uh oh!

celinaykAug 19, 2025

Uh oh!

ParkGyeongTae left a comment

Uh oh!

celinayk commented Aug 19, 2025

Uh oh!

Reamer left a comment

Uh oh!

Uh oh!

Reamer left a comment

Uh oh!

Reamer commented Aug 20, 2025

Uh oh!

celinayk commented Aug 20, 2025

Uh oh!

ParkGyeongTae left a comment

Uh oh!

Uh oh!

ParkGyeongTae commented Aug 22, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants


		import org.junit.jupiter.api.Test;

		import static org.junit.jupiter.api.Assertions.*;

Uh oh!

Conversation

celinayk commented Aug 16, 2025

What is this PR for?

What type of PR is it?

Todos

What is the Jira issue?

How should this be tested?

Screenshots (if appropriate)

Questions:

Uh oh!

Uh oh!

ParkGyeongTaeAug 19, 2025

Choose a reason for hiding this comment

Uh oh!

celinaykAug 19, 2025

Choose a reason for hiding this comment

Uh oh!

ParkGyeongTae left a comment

Choose a reason for hiding this comment

Uh oh!

celinayk commented Aug 19, 2025

Uh oh!

Reamer left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reamer left a comment

Choose a reason for hiding this comment

Uh oh!

Reamer commented Aug 20, 2025

Uh oh!

celinayk commented Aug 20, 2025

Uh oh!

ParkGyeongTae left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

ParkGyeongTae commented Aug 22, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants