Uh oh!
There was an error while loading. Please reload this page.
[ZEPPELIN-6335] Fix failing zengine tests caused by invalid interpreters.json - #5081
Merged
Conversation
…eterSettings` keys match their inner IDs
pan3793
approved these changes
Sep 26, 2025
Uh oh!
There was an error while loading. Please reload this page.
tbonelee added a commit
that referenced
this pull request
Sep 27, 2025
…ers.json ### What is this PR for? Tests in the `zeppelin-zengine` module were failing. The main reason was that the `interpreter.json` in test resources were invalid: the value object did not have an `id` field matching its corresponding key. As a result, the deserialized `InterpreterSetting` instance had an auto-genarated `id` field, causing the key and value.id to be inconsistent. Before #5063, invalid settings were simply skipped. However, after that change, they caused a NPE. This PR fixes the invalid JSON files and adds minor validation logic in the deserialization method so that such issues can be detected early by users. ### What type of PR is it? Bug Fix ### What is the Jira issue? https://issues.apache.org/jira/browse/ZEPPELIN-6335 ### How should this be tested? * Check `core-modules` - `zeppelin-zengine` tests in CI ### Questions: * Does the license files need to update? No * Is there breaking changes for older versions? No * Does this needs documentation? No Closes#5081 from tbonelee/fix-test-resource. Signed-off-by: ChanHo Lee <chanholee@apache.org> (cherry picked from commit 80ff51c) Signed-off-by: ChanHo Lee <chanholee@apache.org>
tbonelee
commented
Sep 27, 2025
ContributorAuthor
Thanks for the reviews, merged into master and branch-0.12. |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this PR for?
Tests in the
zeppelin-zenginemodule were failing. The main reason was that theinterpreter.jsonin test resources were invalid: the value object did not have anidfield matching its corresponding key.As a result, the deserialized
InterpreterSettinginstance had an auto-genaratedidfield, causing the key and value.id to be inconsistent.Before #5063, invalid settings were simply skipped. However, after that change, they caused a NPE.
This PR fixes the invalid JSON files and adds minor validation logic in the deserialization method so that such issues can be detected early by users.
What type of PR is it?
Bug Fix
What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-6335
How should this be tested?
core-modules-zeppelin-zenginetests in CIQuestions: