Uh oh!
There was an error while loading. Please reload this page.
ZEPPELIN-487 Change supporting multiple statements to multiple connections - #517
ZEPPELIN-487 Change supporting multiple statements to multiple connections#517jongyoul wants to merge 3 commits into
Conversation
- keyConnectionMap -> propertyKeyConnectionMap
- Multiple Statements -> multiple connections
prasadwagle
commented
Dec 6, 2015
I tested the pull request and it allowed Vertica queries to execute in parallel with one modification. Thanks! I had to comment: Can you help me understand the need for the statement.isClosed() check in line 208 since the statement is created in line 207? |
jongyoul
commented
Dec 6, 2015
It's soft of defensive code for avoiding error. Do you think it's redundant? I'll fix this code more general :-). Thanks for the review quickly. |
- Fix the error when statement doesn't support isClosed method
jongyoul
commented
Dec 8, 2015
@praagarw Could you please review this PR again? |
prasadwagle
commented
Dec 8, 2015
Hi Jongyoul, since createStatement is implemented in the JDBC drivers, I think it is unlikely it will return a closed statement. However, I am all for defensive coding and your fix in ZEPPELIN-487 looks good to me. |
jongyoul
commented
Dec 9, 2015
@praagarw Sure, but I couldn't guarantee all of jdbc connections create statement when it's alive. Thus double check might be helpful in that case. And thanks for kind review. I'm merging in three day. |
jongyoul
commented
Dec 9, 2015
Merging without additional discussion |
Changed multiple statements to multiple connection. Some JDBC don't support parallel executions with one connection.