Uh oh!
There was an error while loading. Please reload this page.
[ZEPPELIN-6496] Replace BigQuery polling stdout output with SLF4J logging - #5298
Conversation
ParkGyeongTae
left a comment
There was a problem hiding this comment.
LGTM. The change correctly replaces the System.out.println in pollJob()
with LOGGER.info(...), which is already declared in the class.
Using SLF4J parameterized logging ({}) is a small additional improvement
over the original string concatenation — it avoids unnecessary string
construction when the INFO level is disabled.
Verified:
- No remaining
System.out/System.errcalls in thebigquerypackage. - Polling behavior (while loop,
Thread.sleep, returnedJob) is unchanged.
Nit: The PR title appears to be truncated — could you update it to[ZEPPELIN-6496] Replace BigQuery polling stdout output with SLF4J logging?
jongyoul
left a comment
There was a problem hiding this comment.
Reviewed the current head. The logging-only change preserves BigQuery polling behavior, and the remaining Selenium failure is unrelated to this module.
celinayk
commented
Jul 14, 2026
Thanks for the reviews! Updated the PR title to the full form as suggested. |
Uh oh!
There was an error while loading. Please reload this page.
jongyoul
commented
Jul 14, 2026
Merged into master (8b0bf9c). |
What is this PR for?
BigQueryInterpreter.pollJob(...)printed job polling status directly to standard output viaSystem.out.println(...), bypassing Zeppelin's SLF4J/Log4j2 loggingconfiguration, log levels, and appenders. This made diagnostics noisy and hard to route in server/interpreter deployments. This PR replaces the direct stdout call with a
structured SLF4J logger call.
What type of PR is it?
Improvement
Todos
System.out.println(...)inpollJob(...)withLOGGER.info(...)What is the Jira issue?
ZEPPELIN-6496
How should this be tested?
rg -n "System\.out\.println|System\.err\.println" bigquery/src/main/java/org/apache/zeppelin/bigqueryreturns no results./mvnw test -pl bigquerycompiles/builds successfullyScreenshots (if appropriate)
N/A
Questions: