Skip to content

[Docs] Minor fixes for Elasticsearch documentation - #566

Closed
bzz wants to merge 4 commits into
apache:masterfrom
bzz:fix/elasticsearch-docs
Closed

[Docs] Minor fixes for Elasticsearch documentation#566
bzz wants to merge 4 commits into
apache:masterfrom
bzz:fix/elasticsearch-docs

Conversation

@bzz

@bzzbzz commented Dec 22, 2015

Copy link
Copy Markdown
Member

What is this PR for?

Adds elasticsearch to interpreter menu in navigation and fixes max image size for screenshots

What type of PR is it?

Documentation | Hot Fix

Is there a relevant Jira issue?

How should this be tested?

Build docs, go to elasticsearch one.

@bzz

bzz commented Dec 22, 2015

Copy link
Copy Markdown
MemberAuthor

This is HotFix for #520
Would like to merge it asap

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we keep alphabetical order of menu items?

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure!

@bzz

bzz commented Dec 22, 2015

Copy link
Copy Markdown
MemberAuthor

\cc @bbonnin for review

@bzz

bzz commented Dec 22, 2015

Copy link
Copy Markdown
MemberAuthor

Ready to be merged

@bbonnin

Copy link
Copy Markdown
Contributor

Looks good to me.

@Leemoonsoo

Copy link
Copy Markdown
Member

LGTM

@bzz

bzz commented Dec 22, 2015

Copy link
Copy Markdown
MemberAuthor

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@bzz@bbonnin@Leemoonsoo