Uh oh!
There was an error while loading. Please reload this page.
[ZEPPELIN-551] Add paragraph scope for angular object - #588
Closed
Leemoonsoo wants to merge 11 commits into
Closed
Conversation
Leemoonsooforce-pushed
the
ZEPPELIN-551
branch
4 times, most recently
from
January 13, 2016 00:11
b20ae24 to
917c1caCompareLeemoonsoo
commented
Jan 13, 2016
MemberAuthor
ready to merge |
corneadoug
commented
Jan 13, 2016
Contributor
I will take a look at it today then :) |
corneadoug
commented
Jan 13, 2016
Contributor
Do you have some example or documentation on how you can bind at paragraph or notebook level from UI? |
Leemoonsoo
commented
Jan 13, 2016
MemberAuthor
Let me update javadoc |
Leemoonsoo
commented
Jan 17, 2016
MemberAuthor
@corneadoug updated javadoc |
corneadoug
commented
Jan 17, 2016
Contributor
Thanks, I will look at it |
1 task
Member
There was a problem hiding this comment.
this will help reduce travis log length quite a bit!
felixcheung
commented
Jan 18, 2016
Member
looks good |
Leemoonsoo
commented
Jan 23, 2016
MemberAuthor
Thanks @felixcheung taking a look. I'm merging it into master. |
asfgit pushed a commit
that referenced
this pull request
Feb 1, 2016
### What is this PR for? This PR is related #591 created by Leemoonsoo. I just added a section explaining the **Utilities for Angular Display System** to `docs/angular.md`. ### What type of PR is it? Documentation ### Todos * [x] - Add a section for explaining Utilities for Angular Display System to angular.md ### Is there a relevant Jira issue? No. But there is a related PR: #591 (and maybe #588) ### How should this be tested? Just apply this PR and checkout the `Display System -> Angular` tab in Zeppelin web site. ### Screenshots (if appropriate) ### Questions: * Does the licenses files need update? No. * Is there breaking changes for older versions? No. * Does this needs documentation? No. Author: Ryu Ah young <fbdkdud93@hanmail.net> Closes#650 from AhyoungRyu/display_utils_docs and squashes the following commits: 6923400 [Ryu Ah young] (Documentation): Add package import information 280b846 [Ryu Ah young] (Documentation): Fix some grammar errors in angular.md 13330d0 [Ryu Ah young] (Documentation): Fix some sentences a7cf9ac [Ryu Ah young] (Documentation): Utilities for Angular Display System
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this PR for?
Add paragraph scope for angular object. While it changes some internal api and ZeppelinServer - Interpreter process protocol (thrift), it's better be merged after creating 0.5.6 release branch
What type of PR is it?
Improvement
Is there a relevant Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-551
How should this be tested?
Creating AngularObject now taking 'paragraphId' as a parameter in addition to 'noteId'.
When 'paragraphId' is null, the AngularObject becomes notebook scope, otherwise it becomes paragraph scope.
Screenshots (if appropriate)
Questions:
Incompatible with interpreter binary that built with older version because of this PR updates thrift idl