Uh oh!
There was an error while loading. Please reload this page.
[ZEPPELIN-554] Streaming interpreter output to front-end - #611
[ZEPPELIN-554] Streaming interpreter output to front-end#611Leemoonsoo wants to merge 30 commits into
Conversation
prabhjyotsingh
commented
Jan 8, 2016
I tried the default example it works awesomely well. I might not have understood what all this PR is supposed to cover;
before this PR the output was but now its just |
corneadoug
commented
Jan 8, 2016
I don't have any output for |
Leemoonsoo
commented
Jan 8, 2016
@prabhjyotsingh@corneadoug Thanks for the feedback. Let me push more commits for the output issue as well as pyspark. |
swkimme
commented
Jan 8, 2016
This is something what I REALLY needed. AWESOME!! |
corneadoug
commented
Jan 8, 2016
Made a PR to refactor the JS code :) |
Leemoonsoo
commented
Jan 8, 2016
@prabhjyotsingh@corneadoug Addressed the comments |
prabhjyotsingh
commented
Jan 9, 2016
@Leemoonsoo this is so awesome and useful feature. Thanks a lot of this. |
randerzander
commented
Jan 9, 2016
I wonder if this can be used in combination with #152/Zeppelin-157 ? I'm thinking a streaming job emits GPS points which are dynamically populated on a map. @Madhuka@corneadoug |
Leemoonsoo
commented
Jan 9, 2016
This PR stream output only when it's %text. It keeps the same behavior for %table, %html, %angular and all the other display system. For dynamically populated data on a map, here's great example. https://gist.github.com/granturing/a09aed4a302a7367be92. Which leverage %angular display system |
corneadoug
commented
Jan 10, 2016
Found another issue: |
felixcheung
commented
Jan 11, 2016
very cool. should SparkOutputStream be generalized - i think maybe other interpreters could stream output too (and maybe %table could use some partial result too?) |
Leemoonsoo
commented
Jan 11, 2016
@corneadoug trying to fix clear paragraph output. no success for now |
b9c0d6e to
debfc3eCompare5b8c25a to
d29cfbfCompareLeemoonsoo
commented
Jan 16, 2016
@corneadoug Fixed the clear paragraph output. |
minahlee
commented
Jan 19, 2016
Tested and LGTM |
Leemoonsoo
commented
Jan 20, 2016
Thanks @minahlee for the review. I'm merging it into master. |
### What is this PR for? This PR provides HOTFIX for master branch build error introduced by #611 ### What type of PR is it? Hot Fix ### Todos * [x] - Fix unittest ### Is there a relevant Jira issue? N/A ### How should this be tested? N/A ### Screenshots (if appropriate) N/A ### Questions: * Does the licenses files need update? no * Is there breaking changes for older versions? no * Does this needs documentation? no Author: Lee moon soo <moon@apache.org> Closes#663 from Leemoonsoo/hotfix_ZEPPELIN-554 and squashes the following commits: a468b2e [Lee moon soo] Update unit test
### What is this PR for? After #611 merged, Zeppelin provides streaming output for **spark** and **pyspark** interpreter. For the further improvement, I changed a few code lines using <code>[InterpreterContext](https://github.com/apache/incubator-zeppelin/blob/master/zeppelin-interpreter/src/main/java/org/apache/zeppelin/interpreter/InterpreterContext.java#L66)</code> so that **sh** interpreter can be available too. ### What type of PR is it? Improvement ### Todos ### Is there a relevant Jira issue? [ZEPPELIN-646: Shell interpreter output streaming](https://issues.apache.org/jira/browse/ZEPPELIN-646) [ZEPPELIN-554: Streaming interpreter output to front-end]() ### How should this be tested? After applying this PR, run this below code with `sh` interpreter in Zeppelin. ``` date && sleep 3 && date ``` Then you can see two timestamps which have 3 seconds gap. ### Screenshots (if appropriate)  ### Questions: * Does the licenses files need update? No * Is there breaking changes for older versions? No * Does this needs documentation? No Author: Ryu Ah young <fbdkdud93@hanmail.net> Closes#683 from AhyoungRyu/ZEPPELIN-646 and squashes the following commits: a9d2e2b [Ryu Ah young] ZEPPELIN-646: Shell interpreter output streaming

What is this PR for?
Output from interpreter is displayed after completion of paragraph execution.
It'll be useful if output can be streamed to front-end during execution.
Previous work #593 injects InterpreterOutput stream object to Interpreter.
This PR is based on #593 and stream the data from InterpreterOutput to front-end.
This implementation only streams output is %text. Other output type (%html, %angular, %table) is not streamed to the front end.
While this PR keeps backward compatibility, Interpreter who want to use this feature will need to modify code to write output into
InterpreterOutputinstead of return withInterpreterResult.This PR includes modification of SparkInterpreter to use InterpreterOutput.
What type of PR is it?
Feature
Todos
Is there a relevant Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-554
How should this be tested?
Run such code using Spark interpreter
Screenshots (if appropriate)
Questions: