Uh oh!
There was an error while loading. Please reload this page.
Update pom.xml - #637
Closed
hash-X wants to merge 1 commit into
Closed
Conversation
I use mvn clean package -Pspark-1.4 -Phadoop-2.6 -DskipTests can cause error and I think this should not appear. Reason about this issue is sqlline:sqlline:jar:1.1.8 is served from conjar repo. But sqlline:sqlline:jar:1.1.9 is served from maven repo. So add the dependency of sqlline1.1.9 can solve it.
gallenvara
commented
Jan 14, 2016
Good to merge. |
Leemoonsoo
commented
Jan 14, 2016
Member
LGTM and merge if there're no more discussions. |
hash-X
commented
Jan 15, 2016
Author
@Leemoonsoo thanks for your review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this PR for?
improving pom.xml
What type of PR is it
Improvement
Todos
Is there a relevant Jira issue?
May not require issue
How should this be tested?
I use
mvn clean package -Pspark-1.4 -Phadoop-2.6 -DskipTestscan cause the module Phoenix error and I think this should not appear. Reason about this issue is sqlline:sqlline:jar:1.1.8 is served from conjar repo. But sqlline:sqlline:jar:1.1.9 is served from maven repo. So add the dependency of sqlline1.1.9 can solve it. Of course, you can fix this issue by another way, but this way may be in common use.http://mvnrepository.com/artifact/sqlline/sqlline/1.1.9
Screenshots (if appropriate)
Before
BUILD FAILUREWhen you add this dependency
After
Questions: