Skip to content

keyboard shortcut to add above - #643

Closed
TYMichaelChen wants to merge 2 commits into
apache:masterfrom
TYMichaelChen:ZEPPELIN-611
Closed

keyboard shortcut to add above#643
TYMichaelChen wants to merge 2 commits into
apache:masterfrom
TYMichaelChen:ZEPPELIN-611

Conversation

@TYMichaelChen

Copy link
Copy Markdown
Contributor

What is this PR for?

add a keyboard shortcut to add paragraph above to keep difference with previous add paragraph below

What type of PR is it?

Improvement

Todos

Is there a relevant Jira issue?

https://issues.apache.org/jira/browse/ZEPPELIN-611

How should this be tested?

click into a paragraph and press ctrl+alt+n

Screenshots (if appropriate)

after

Questions:

  • Does the licenses files need update? no
  • Is there breaking changes for older versions? no
  • Does this needs documentation? no

@Leemoonsoo

Copy link
Copy Markdown
Member

Thanks for the contribution.
How about use shortcut key 'a' for this, like Jupyter/Ipython does?

And I think it's good idea to reserve ctrl-alt-'n' and ctrl-alt-'p' for something related to paragraph focus,
while ctrl-'n', ctrl-'p' moves cursor.

@TYMichaelChen

Copy link
Copy Markdown
ContributorAuthor

@Leemoonsoo : good point. thanks for pointing that out. it's changed to a now.

@Leemoonsoo

Copy link
Copy Markdown
Member

Thanks @MikeTYChen I'm merging it if there're no more discussions

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@TYMichaelChen@Leemoonsoo