Uh oh!
There was an error while loading. Please reload this page.
[ZEPPELIN-687] Display paragraph id in config dropdown menu - #739
Closed
doanduyhai wants to merge 1 commit into
Closed
[ZEPPELIN-687] Display paragraph id in config dropdown menu#739doanduyhai wants to merge 1 commit into
doanduyhai wants to merge 1 commit into
Conversation
Leemoonsoo
commented
Feb 22, 2016
Member
Looks good to me |
corneadoug
commented
Feb 22, 2016
Contributor
doanduyhai
commented
Feb 22, 2016
ContributorAuthor
@corneadoug Good idea, but why do we need the |
corneadoug
commented
Feb 22, 2016
Contributor
The drop-down menu is closing on mouse-up event. |
doanduyhai
commented
Feb 22, 2016
ContributorAuthor
Ok, makes sense, thanks, I'll update the PR accordingly |
doanduyhaiforce-pushed
the
ZEPPELIN-687
branch
from
February 22, 2016 20:29
4aa4a79 to
f4dfa5aComparedoanduyhai
commented
Feb 22, 2016
ContributorAuthor
Done, see updated screenshot |
doanduyhaiforce-pushed
the
ZEPPELIN-687
branch
from
February 22, 2016 21:46
f4dfa5a to
a3f3dacComparefelixcheung
commented
Feb 23, 2016
Member
Is it feasible to have a copy button? or is it to crowded? |
doanduyhai
commented
Feb 23, 2016
ContributorAuthor
I've tried to add an icon before and it overflows the maximum width of the popup. We can also reduce the font-size so the long paragraph id will fit in but it looks ugly |
doanduyhaiforce-pushed
the
ZEPPELIN-687
branch
from
February 23, 2016 07:34
a3f3dac to
ada9378Comparedoanduyhaiforce-pushed
the
ZEPPELIN-687
branch
from
February 23, 2016 14:30
ada9378 to
a2a9db6Comparecorneadoug
commented
Feb 23, 2016
Contributor
LGTM |
3 tasks
Leemoonsoo
commented
Feb 26, 2016
Member
LGTM and merge if there're no more discussions |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

What is this PR for?
Display paragraph id in the config drop down menu
This is a sub-task of epic ZEPPELIN-635
What type of PR is it?
[Improvement]
Todos
Is there a relevant Jira issue?
ZEPPELIN-687
How should this be tested?
git fetch origin pull/739/head:DisplayParagraphIdgit checkout DisplayParagraphIdmvn clean package -DskipTestsbin/zeppelin-daemon.sh restartScreenshots (if appropriate)
Questions: