Skip to content

[ZEPPELIN-792]Misspelt words and Wrong method parameters - #817

Closed
zuny25 wants to merge 2 commits into
apache:masterfrom
zuny25:feature/InterpreterDependency
Closed

[ZEPPELIN-792]Misspelt words and Wrong method parameters#817
zuny25 wants to merge 2 commits into
apache:masterfrom
zuny25:feature/InterpreterDependency

Conversation

@zuny25

Copy link
Copy Markdown

What is this PR for?

Fix misspelt words and wrong method parameter on zeppelin-interpreter
https://issues.apache.org/jira/browse/ZEPPELIN-792

What type of PR is it?

Bug Fix

Todos

  • - Fix misspelt variable
  • - Fix wrong method parameter

What is the Jira issue?

How should this be tested?

  1. Edit Interpreter dep package
  2. Run DependencyResolverTest

Screenshots (if appropriate)

Questions:

  • Does the licenses files need update? No
  • Is there breaking changes for older versions? No
  • Does this needs documentation? No

fireboy1919and others added 2 commits April 6, 2016 11:13
 classpathFlter -> classpathFilter
org.sonatype.aether/aether-api/1.12 / org.sonatype.aether.repository.RemoteRepository
public RemoteRepository setPolicy( boolena snapshot, RepositoryPolicy policy)
org.sonatype.aether/aether-api/1.12 / org.sonatype.aether.repository.RepositoryPolicy
public More ...RepositoryPolicy( boolean enabled, String updatePolicy, String checksumPolicy )
I think two paraemter have to changed its position
RemoteRepository rr = new RemoteRepository(id, "default", url);
rr.setPolicy(true, new RepositoryPolicy(
snapshot,
rr.setPolicy(snapshot, new RepositoryPolicy(

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe just new RepositoryPolicy() will do the same thing

@minahlee

Copy link
Copy Markdown
Member

LGTM

@corneadoug

Copy link
Copy Markdown
Contributor

@zuny25 Could you rebase this one and re-trigger the CI?

@zuny25zuny25 closed this Jun 9, 2016
@zuny25zuny25 reopened this Jun 9, 2016
@bzz

bzz commented Jun 9, 2016

Copy link
Copy Markdown
Member

@zuny25 thank you for contribution!
CI is green now.
Looks good to me.

@corneadoug

Copy link
Copy Markdown
Contributor

Merging if there is no more discussions

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@zuny25@minahlee@corneadoug@bzz@fireboy1919