Skip to content

ZEPPELIN-783: fix Spark download on CI - #818

Closed
bzz wants to merge 1 commit into
apache:masterfrom
bzz:ZEPPELIN-783-stable-ci-part-2
Closed

ZEPPELIN-783: fix Spark download on CI#818
bzz wants to merge 1 commit into
apache:masterfrom
bzz:ZEPPELIN-783-stable-ci-part-2

Conversation

@bzz

@bzzbzz commented Apr 6, 2016

Copy link
Copy Markdown
Member

What is this PR for?

Fix Spark download on CI

What type of PR is it?

Hot Fix

What is the Jira issue?

ZEPPELIN-783

How should this be tested?

CI must be green

Questions:

  • Does the licenses files need update? No
  • Is there breaking changes for older versions? No
  • Does this needs documentation? No

@bzz
bzzforce-pushed the ZEPPELIN-783-stable-ci-part-2 branch 2 times, most recently from 8f4c57a to 6a229e0CompareApril 6, 2016 10:14
@bzzbzz mentioned this pull request Apr 6, 2016
@bzz
bzzforce-pushed the ZEPPELIN-783-stable-ci-part-2 branch 2 times, most recently from e4f3614 to 061c9b7CompareApril 6, 2016 12:21
@bzz
bzzforce-pushed the ZEPPELIN-783-stable-ci-part-2 branch from 061c9b7 to b4d66b3CompareApril 6, 2016 12:59
@bzz

bzz commented Apr 6, 2016

Copy link
Copy Markdown
MemberAuthor

\cc @felixcheung for review

@bzz

bzz commented Apr 7, 2016

Copy link
Copy Markdown
MemberAuthor

@bzz

bzz commented Apr 8, 2016

Copy link
Copy Markdown
MemberAuthor

Merging if there is no more discussion

@lresende

Copy link
Copy Markdown
Member

LGTM

set -xe

TIMEOUT_SEC=590
MAX_DOWNLOAD_TIME_SEC=590

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trivial: This isn't used any longer.

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, but I thought about keeping it for a while, reminding about great use of timeout that we have discarded for now. We possibly might what get back to it one day (i.e to reduce build time), once we get the build stability.

@jongyoul

Copy link
Copy Markdown
Member

LGTM

@bzz

bzz commented Apr 8, 2016

Copy link
Copy Markdown
MemberAuthor

Thank you for reviews!

@asfgitasfgit closed this in 7155268Apr 8, 2016
@bzz
bzz deleted the ZEPPELIN-783-stable-ci-part-2 branch April 8, 2016 03:24
@felixcheung

Copy link
Copy Markdown
Member

Looks good - sorry for the delay.
My only thought was that we should probably echo the exit code from wget if it is not zero in download_with_retry() 

onkarshedge pushed a commit to onkarshedge/incubator-zeppelin that referenced this pull request May 11, 2016
### What is this PR for?
Fix Spark download on CI
### What type of PR is it?
Hot Fix
### What is the Jira issue?
[ZEPPELIN-783](https://issues.apache.org/jira/browse/ZEPPELIN-783)
### How should this be tested?
CI must be green
### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No
Author: Alexander Bezzubov <bzz@apache.org>
Closesapache#818 from bzz/ZEPPELIN-783-stable-ci-part-2 and squashes the following commits:
b4d66b3 [Alexander Bezzubov] ZEPPELIN-783: advanced Spark download failover procedure
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@bzz@lresende@jongyoul@felixcheung