Uh oh!
There was an error while loading. Please reload this page.
[ZEPPELIN-799] Modify index.html and karma.conf.js for mode-python - #851
Closed
cyhsutw wants to merge 1 commit into
Closed
[ZEPPELIN-799] Modify index.html and karma.conf.js for mode-python#851cyhsutw wants to merge 1 commit into
index.html and karma.conf.js for mode-python#851cyhsutw wants to merge 1 commit into
Conversation
prabhjyotsingh
commented
Apr 22, 2016
Contributor
LGTM |
felixcheung
commented
Apr 23, 2016
Member
right, thanks. |
prabhjyotsingh
commented
Apr 23, 2016
Contributor
Merging if there's no more discussion |
onkarshedge pushed a commit
to onkarshedge/incubator-zeppelin
that referenced
this pull request
May 11, 2016
### What is this PR for? Python edit mode was added in apache#825 thank to astroshim. I think we'll need to update the `src/index.html` and `test/karma.conf.js` under `zeppelin-web` accordingly to avoid unstaged changes after building. ### What type of PR is it? Improvement ### Todos None ### What is the Jira issue? Probably a subtask of https://issues.apache.org/jira/browse/ZEPPELIN-799 ### How should this be tested? Shouldn't be any since apache#825 is merged into `master` and has been tested. ### Screenshots (if appropriate) N/A ### Questions: * Does the licenses files need update? *no* * Is there breaking changes for older versions? *no* * Does this needs documentation? *no* /cc astroshim Author: Cheng-Yu Hsu <m@cyhsu.me> Closesapache#851 from cyhsutw/update-template-files and squashes the following commits: 24901cc [Cheng-Yu Hsu] add `mode-python` to generated html and js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this PR for?
Python edit mode was added in #825 thank to @astroshim.
I think we'll need to update the
src/index.htmlandtest/karma.conf.jsunderzeppelin-webaccordingly to avoid unstaged changes after building.What type of PR is it?
Improvement
Todos
None
What is the Jira issue?
Probably a subtask of
https://issues.apache.org/jira/browse/ZEPPELIN-799
How should this be tested?
Shouldn't be any since #825 is merged into
masterand has been tested.Screenshots (if appropriate)
N/A
Questions:
/cc @astroshim