Uh oh!
There was an error while loading. Please reload this page.
Hotfix - does not working notebook filter on navibar. - #912
Conversation
minahlee
commented
May 24, 2016
@astroshim Seems like folder structure notebook is broken. Could you take a look? |
astroshim
commented
May 25, 2016
@minahlee Thank you for review and finding the problem. I'll take a look this. |
astroshim
commented
May 25, 2016
@minahlee I fixed the problem. Can you review? |
bzz
commented
May 25, 2016
CI failure is not related and is due to spark download failure :\ Could you plz create a JIRA issue for that with label |
astroshim
commented
May 25, 2016
@bzz Okay. I'll make one. |
astroshim
commented
May 25, 2016
@bzz I couldn't find the reason of build failure so I just retrigger CI. |
minahlee
commented
May 26, 2016
@astroshim Thanks for the contribution. One feedback from me is that it would be awesome if we can filter subdirectory names in nav bar like main page does: This PR only can filter top-level directory name, so if user types b it won't show 0/b/c notebook. |
astroshim
commented
May 26, 2016
@minahlee Yes, you're right. It would be better supporting the filter subdirectory names. |
@astroshim sounds good :) |
Looks good to me. Last failure seems very similar to #917 |
astroshim
commented
May 26, 2016
@bzz I made issue(https://issues.apache.org/jira/browse/ZEPPELIN-886). |
@astroshim thanks! I think there might be a fix for CI just merged to master - could you please rebase this branch and see if that resolves the issue? Otherwise looks great to me! |
astroshim
commented
May 26, 2016
@bzz I rebased. |
That CI issue is gone, current failure is due to networking issues on Spark download =\ Shall be good to merge. |
minahlee
commented
May 26, 2016
@astroshim Did you remove tutorial notebook on purpose? If not, can you revert the last commit? |
This reverts commit 67d6b5c.
astroshim
commented
May 27, 2016
@minahlee It's my mistake. I reverted. |



What is this PR for?
It doesn't working the notebook filter on navibar.
What type of PR is it?
Bug Fix
What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-873
Screenshots (if appropriate)
Questions: