Skip to content

Hotfix - does not working notebook filter on navibar. - #912

Closed
astroshim wants to merge 4 commits into
apache:masterfrom
astroshim:ZEPPELIN-873
Closed

Hotfix - does not working notebook filter on navibar.#912
astroshim wants to merge 4 commits into
apache:masterfrom
astroshim:ZEPPELIN-873

Conversation

@astroshim

Copy link
Copy Markdown
Contributor

What is this PR for?

It doesn't working the notebook filter on navibar.

What type of PR is it?

Bug Fix

What is the Jira issue?

https://issues.apache.org/jira/browse/ZEPPELIN-873

Screenshots (if appropriate)

  • before
    image
  • after
    image

Questions:

  • Does the licenses files need update? no
  • Is there breaking changes for older versions? no
  • Does this needs documentation? no

@minahlee

Copy link
Copy Markdown
Member

@astroshim Seems like folder structure notebook is broken. Could you take a look?

Attaching screenshot
Master
screen shot 2016-05-24 at 4 46 57 pm

PR#912
screen shot 2016-05-24 at 4 48 49 pm

@astroshim

Copy link
Copy Markdown
ContributorAuthor

@minahlee Thank you for review and finding the problem. I'll take a look this.

@astroshim

Copy link
Copy Markdown
ContributorAuthor

@minahlee I fixed the problem. Can you review?

@bzz

bzz commented May 25, 2016

Copy link
Copy Markdown
Member

CI failure is not related and is due to spark download failure :\

Could you plz create a JIRA issue for that with label flaky-build ?

@astroshim

Copy link
Copy Markdown
ContributorAuthor

@bzz Okay. I'll make one.

@astroshimastroshim reopened this May 25, 2016
@astroshim

Copy link
Copy Markdown
ContributorAuthor

@bzz I couldn't find the reason of build failure so I just retrigger CI.

@astroshimastroshim reopened this May 26, 2016
@minahlee

Copy link
Copy Markdown
Member

@astroshim Thanks for the contribution. One feedback from me is that it would be awesome if we can filter subdirectory names in nav bar like main page does:
screen shot 2016-05-25 at 11 02 33 pm

This PR only can filter top-level directory name, so if user types b it won't show 0/b/c notebook.
We can leave it as a future work if it is too much.

@astroshim

Copy link
Copy Markdown
ContributorAuthor

@minahlee Yes, you're right. It would be better supporting the filter subdirectory names.
How about creating new PR for filtering subdirectory names?

@minahlee

minahlee commented May 26, 2016

Copy link
Copy Markdown
Member

@astroshim sounds good :)
merging if there is no more discussion

@bzz

bzz commented May 26, 2016

Copy link
Copy Markdown
Member

Looks good to me.
@astroshim can you please post the link to JIRA issue here as well?

Last failure seems very similar to #917

 ZeppelinIT.testSparkInterpreterDependencyLoading:209 » ElementNotVisible Eleme...

@astroshim

Copy link
Copy Markdown
ContributorAuthor

@bzz

bzz commented May 26, 2016

Copy link
Copy Markdown
Member

@astroshim thanks! I think there might be a fix for CI just merged to master - could you please rebase this branch and see if that resolves the issue?

Otherwise looks great to me!

@astroshim

Copy link
Copy Markdown
ContributorAuthor

@bzz I rebased.

@bzz

bzz commented May 26, 2016

Copy link
Copy Markdown
Member

That CI issue is gone, current failure is due to networking issues on Spark download =\

Shall be good to merge.

@minahlee

Copy link
Copy Markdown
Member

@astroshim Did you remove tutorial notebook on purpose? If not, can you revert the last commit?

@astroshim

Copy link
Copy Markdown
ContributorAuthor

@minahlee It's my mistake. I reverted.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@astroshim@minahlee@bzz