Uh oh!
There was an error while loading. Please reload this page.
[MINOR] switch location of interpreter search input box - #913
Conversation
cloverhearts
commented
May 25, 2016
Looks good. +1 |
AhyoungRyu
commented
May 25, 2016
@minahlee I was thinking about this too. LGTM 👍 |
astroshim
commented
May 25, 2016
+1 |
prabhjyotsingh
commented
May 25, 2016
LGTM |
prabhjyotsingh
commented
May 26, 2016
Merging this if no more discussion. |
bzz
commented
May 26, 2016
Guys, what's with CI failure? We should not be merging PRs in case CI is not green - at least without some investigation and results posted. If a JIRA issue could be created, linking particular failure with a label What do you think? |
prabhjyotsingh
commented
May 26, 2016
@bzz, agreed. I too think this will help in building stability. and for the error due to which this PR is failing; have seen the same in other PRs as well. And this(#862) fixes it. |
bzz
commented
May 26, 2016
@prabhjyotsingh thank you for quick research! I think same CI failure happened at least in #905 and #917 Shall we merge #862 first and then rebase this and other PRs on top to make sure issue is addressed? |
prabhjyotsingh
commented
May 26, 2016
Yes, perfect, it make sense. |
bzz
commented
May 26, 2016
Done! @minahlee could you rebase please? |
037adeb to
fd3a13dCompareminahlee
commented
May 26, 2016
@bzz Rebase is done, the failure seems like related to network issue for downloading spark. |
Great! If this happens again - we need to look if there is existing issue in JIRA for CI failure under It looks good to merge, if there is no other discussion. |
What is this PR for?
Make search interpreter input box always to be placed upper than repository information or interpreter creation form.
What type of PR is it?
Improvement
Screenshots (if appropriate)
Before

After

Questions: