Uh oh!
There was an error while loading. Please reload this page.
ZEPPELIN-928: fix flaky ZeppelinIT test for Spark interpreter - #939
Closed
bzz wants to merge 2 commits into
Closed
Conversation
bzz
commented
May 31, 2016
MemberAuthor
CI passes, ready to be merged. This should fix CI on #860 |
khalidhuseynov
commented
May 31, 2016
Member
thanks for fixing this flaky test, LGTM |
Leemoonsoo
commented
May 31, 2016
Member
LGTM |
Member
LGTM +1 |
bzz
commented
Jun 1, 2016
MemberAuthor
Thank you for prompt reviews! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this PR for?
Fix flaky Integration Test by adding new id to HTML (as of HTML5 it can be any non-empty string) and liverage it in tests for simpler XPath statements that pick only 1 candidate.
TODO
What type of PR is it?
Bug Fix
What is the Jira issue?
ZEPPELIN-928
How should this be tested?
CI should pass
Questions: