Skip to content

ZEPPELIN-947: Change docs link to point the same Zeppelin version - #953

Closed
AhyoungRyu wants to merge 1 commit into
apache:masterfrom
AhyoungRyu:ZEPPELIN-947
Closed

ZEPPELIN-947: Change docs link to point the same Zeppelin version#953
AhyoungRyu wants to merge 1 commit into
apache:masterfrom
AhyoungRyu:ZEPPELIN-947

Conversation

@AhyoungRyu

Copy link
Copy Markdown
Contributor

What is this PR for?

Currently, Zeppelin documentation link in Zeppelin home is pointing to http://zeppelin.apache.org/docs/latest/index.html. But maybe some people is not using the latest version. So the link should point to the same Zeppelin version that user is using now.

I just change the latest -> {{zeppelinVersion}}

What type of PR is it?

Improvement

Todos

What is the Jira issue?

ZEPPELIN-947

How should this be tested?

  1. After applying this patch and browse Zeppelin home.
  2. Just click Zeppelin Documentation link in here
    screen shot 2016-06-02 at 1 11 17 pm

Screenshots (if appropriate)

Questions:

  • Does the licenses files need update? No
  • Is there breaking changes for older versions? No
  • Does this needs documentation? No

@AhyoungRyuAhyoungRyu reopened this Jun 2, 2016
@corneadoug

Copy link
Copy Markdown
Contributor

The CI failure is unrelated,
Tested, LGTM

@prabhjyotsingh

Copy link
Copy Markdown
Contributor

I have seen in some of the organisations where the build/release team edits pom.xml and truncates -SNAPSHOT e.g. 0.6.0-SNAPSHOT becomes 0.6.0, for their own cache purposes.

So, IMO if we are going ahead with this, then may be we should have a redirect of http://zeppelin.apache.org/docs/{anything-else}/index.html to http://zeppelin.apache.org/docs/latest/index.html. Any thoughts ?

@Leemoonsoo

Leemoonsoo commented Jun 4, 2016

Copy link
Copy Markdown
Member

@prabhjyotsingh redirection is good idea. Created an issue and pullrequest.

@AhyoungRyu

Copy link
Copy Markdown
ContributorAuthor

@prabhjyotsingh Appreciate for sharing your thought! and
@Leemoonsoo Thanks for taking care that :)

@corneadoug

Copy link
Copy Markdown
Contributor

@Leemoonsoo not sure your PR is doing it, the idea was to use latest instead of 0.6.0-SNAPSHOT

@Leemoonsoo

Copy link
Copy Markdown
Member

@corneadoug updated #961, please check!

@prabhjyotsingh

Copy link
Copy Markdown
Contributor

LGTM. We can merge this if no more discussion.

@felixcheung

Copy link
Copy Markdown
Member

but latest is generally older than the unreleased snapshot build?
for instance, https://zeppelin.incubator.apache.org/docs/latest/ now points to 0.5.6 release doc, not 0.6.0-snapshot doc.

@AhyoungRyu

Copy link
Copy Markdown
ContributorAuthor

@felixcheung Yeah right. As you can see, that's why I changed the link http://zeppelin.apache.org/docs/latest/index.html -> http://zeppelin.apache.org/docs/{{zeppelinVersion}}/index.html. Did I understand your comment incorrectly ?

@felixcheung

Copy link
Copy Markdown
Member

Right. This is good. I was not sure about the redirect comment above but I didn't really have a better solution.

 _____________________________

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@AhyoungRyu@corneadoug@prabhjyotsingh@Leemoonsoo@felixcheung