Skip to content

[Hot Fix] Fix flaky ZeppelinIT build - #958

Closed
prabhjyotsingh wants to merge 1 commit into
apache:masterfrom
prabhjyotsingh:ZEPPELIN-950
Closed

[Hot Fix] Fix flaky ZeppelinIT build#958
prabhjyotsingh wants to merge 1 commit into
apache:masterfrom
prabhjyotsingh:ZEPPELIN-950

Conversation

@prabhjyotsingh

@prabhjyotsinghprabhjyotsingh commented Jun 3, 2016

Copy link
Copy Markdown
Contributor

What is this PR for?

Most of the builds are failing for ZeppelinIT at testSparkInterpreterDependencyLoading:243, as the previous line's testDepRemoveBtn.click() is taking it to a different page.

What type of PR is it?

[Hot Fix]

Todos

  • - Change all add/remove dependencies/property's div to button
  • - make relevant change in selenium test case.

What is the Jira issue?

ZEPPELIN-950

How should this be tested?

CI should pass

Questions:

  • Does the licenses files need update? N/A
  • Is there breaking changes for older versions? N/A
  • Does this needs documentation? N/A

@prabhjyotsingh
prabhjyotsinghforce-pushed the ZEPPELIN-950 branch 2 times, most recently from 80bb77d to 66ce9ccCompareJune 3, 2016 20:05
@prabhjyotsingh

Copy link
Copy Markdown
ContributorAuthor

@felixcheung

Copy link
Copy Markdown
Member

thanks! we should probably look into download/network errors too.
LGTM

@prabhjyotsingh

Copy link
Copy Markdown
ContributorAuthor

Sure, I'll try to figure something out for npm related network error(s).

I'll merge this if no more discussion.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@prabhjyotsingh@felixcheung