Skip to content

ZEPPELIN-985 ] Fixed bug in the Pyspark completion - #988

Closed
cloverhearts wants to merge 1 commit into
apache:masterfrom
cloverhearts:hotfix/nwPyspark
Closed

ZEPPELIN-985 ] Fixed bug in the Pyspark completion#988
cloverhearts wants to merge 1 commit into
apache:masterfrom
cloverhearts:hotfix/nwPyspark

Conversation

@cloverhearts

Copy link
Copy Markdown
Member

What is this PR for?

Currently, does not work 'pyspark completion'.

What type of PR is it?

Bug Fix

Todos

  • - change standard output for completion to interpreter outer.

What is the Jira issue?

https://issues.apache.org/jira/browse/ZEPPELIN-985

How should this be tested?

Try keyword completion for pyspark interpreter.

Screenshots (if appropriate)

Before

pycompletion_err2

After

pycompletion

Questions:

  • Does the licenses files need update? no
  • Is there breaking changes for older versions? no
  • Does this needs documentation? no

@cloverhearts

Copy link
Copy Markdown
MemberAuthor

retry ci

@AhyoungRyu

Copy link
Copy Markdown
Contributor

@cloverhearts Thank you for quick fixing ! I closed my issue ZEPPELIN-984 since they are duplicated.

@AhyoungRyu

Copy link
Copy Markdown
Contributor

@cloverhearts I tested and it works well 👍

@felixcheung

Copy link
Copy Markdown
Member

LGTM

@Leemoonsoo

Copy link
Copy Markdown
Member

Tested and it works well.
LGTM

@Leemoonsoo

Copy link
Copy Markdown
Member

Merge if there're no further discussions.

@cloverhearts
cloverhearts deleted the hotfix/nwPyspark branch June 16, 2016 06:22
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@cloverhearts@AhyoungRyu@felixcheung@Leemoonsoo