Links require same ID type

[nesl247]

API Platform version(s) affected: 3.0.7

Description
Links require the same property type when following the example here: https://api-platform.com/docs/core/subresources/#company-employees

If the id type is a string on Company, it will fail if the id is type UUIDv4 for example on Employee. The issue is caused because the type is retrieved from the last identifier in the URL, and not for the particular identifier.

How to reproduce
See the link above.

Possible Solution

--- /dev/null
+++ ../src/Doctrine/Orm/State/LinksHandlerTrait.php
@@ -118,6 +118,9 @@
 $queryBuilder->join("{$previousAlias}.{$link->getToProperty()}", $joinAlias);
 
 foreach ($identifierProperties as $identifierProperty) {
+ $associationTargetClass = $doctrineClassMetadata->getAssociationMapping($link->getToProperty())['targetEntity'];
+ $doctrineClassMetadata = $manager->getClassMetadata($associationTargetClass);
+
 $placeholder = $queryNameGenerator->generateParameterName($identifierProperty);
 $queryBuilder->andWhere("$joinAlias.$identifierProperty = :$placeholder");
 $queryBuilder->setParameter($placeholder, $this->getIdentifierValue($identifiers, $hasCompositeIdentifiers ? $identifierProperty : null), $doctrineClassMetadata->getTypeOfField($identifierProperty));

Additional Context
I didn't submit this as a PR as I'm not sure if there is more to the code that maybe we need to change, but this did solve our issue.

[soyuka]

It's a good idea, you'd need to test if $link->getToProperty() is an association before making an assumption on that matter. Please open a patch on 3.x and if you can add a functional test its awesome :).

[nesl247]

@soyuka awesome, thanks. I will do so, but may not get to it until January as I'm out of the office for the rest of the year.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[nesl247]

This isn't stale, I have not had time to work on the related PR.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.