Ignore property that does not exist for interfaces (identifiers for interfaces)

[Nek-]

Q	A
Bug fix?	yes/no
New feature?	yes
BC breaks?	no
Deprecations?	no
Tests pass?	yes
Fixed tickets	Related to #1574
License	MIT
Doc PR	N/A

Motivations

TL;DR: Before: no "item" route working because we can't define an identifier. After: we can define a property for an interface and it will not be considered as "not found property".

1. It makes no sense to check if an interface exists in case it's an interface ;
2. If the property is not recognized as one and there is no identifier, then API Platform will not be able to call the DataProvider for a given item and interface as a resource is an incomplete feature.

Usage

Me\InterfaceAsAResource:
properties:
# Will work even if foo is not defined in the interface!foo:
identifier: true

What's next?

If you like this kind of features, I will probably work on "virtual properties" next. I see something like

Me\InterfaceAsAResource:
properties:
foo:
identifier: trueproxy_method: 'customMethodToGetFoo'

What do you think? Maybe you want a separate RFC issue to discuss it?

[teohhanhui]

I thought we already support virtual properties?

[Nek-]

@teohhanhui interesting. I was surprised to not find the feature. I'm curious to know where it is documented.

[teohhanhui]

@Nek- I think there's no documentation, not even tests for it. 😆 🙈

But looking at the code (and as I've heard from other's experience), it should work. (Not when using the Extractor factory, obviously, as you've discovered.)

[Nek-]

In any case, it doesn't invalidate this feature as I understand. Are failures on CI related? (due to inversion of condition?)

[teohhanhui]

CI failures are unrelated and should be fixed after #2106 is merged.

[Nek-]

It's up to date and issues of phpstan non-related.

[soyuka]

I think that #2495 fixes this case lmk if it doesn't.

Going to cherry pick the tests anyway!

/note for EU-FOSSA Hackathon just cherry-pick the test

[Nek-]

@soyuka it does not. (I tried to add the test to the code base)