Skip to content

Prevent cloning generator when instanciating previous_data - #2990

Merged
dunglas merged 1 commit into
api-platform:2.4from
nitneuk:fix-previous_data
Aug 19, 2019
Merged

Prevent cloning generator when instanciating previous_data#2990
dunglas merged 1 commit into
api-platform:2.4from
nitneuk:fix-previous_data

Conversation

@nitneuk

@nitneuknitneuk commented Aug 19, 2019•
edited
Loading

Copy link
Copy Markdown
Contributor
QA
Bug fix?yes
New feature?no
BC breaks?no
Deprecations?no
Tests pass?yes
Fixed tickets
LicenseMIT
Doc PRapi-platform/docs#858

Add a clone trait with a method clone that returns a clone of the given variable if cloneable.
Inspired by @alanpoulain from #2978

dunglas
dunglas requested changes Aug 19, 2019
View reviewed changes
Comment threadsrc/Util/CloneTrait.php Outdated
Comment threadsrc/Util/CloneTrait.php Outdated
teohhanhui
teohhanhui reviewed Aug 19, 2019
View reviewed changes
Comment threadsrc/Util/CloneTrait.php Outdated
@dunglasdunglas mentioned this pull request Aug 19, 2019
Merged
@nitneuk
nitneukforce-pushed the fix-previous_data branch 5 times, most recently from 76e042b to f640dabCompareAugust 19, 2019 15:08
@dunglas
dunglas merged commit ee4bf84 into api-platform:2.4Aug 19, 2019
@dunglas

dunglas commented Aug 19, 2019

Copy link
Copy Markdown
Member

Thanks @Nitneuk2

@alanpoulain

alanpoulain commented Aug 19, 2019

Copy link
Copy Markdown
Member

Shouldn't the ItemResolver use the trait too?

@dunglas

dunglas commented Aug 19, 2019

Copy link
Copy Markdown
Member

good catch

@dunglasdunglas mentioned this pull request Aug 19, 2019
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dunglasdunglasdunglas approved these changes
+1 more reviewer
@teohhanhuiteohhanhuiteohhanhui left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@nitneuk@dunglas@alanpoulain@teohhanhui