Skip to content

Passing custom doctrine type to addWhereByStrategy - #3331

Closed
oleg-andreyev wants to merge 3 commits into
api-platform:2.5from
oleg-andreyev:custom-doctrine-type
Closed

Passing custom doctrine type to addWhereByStrategy#3331
oleg-andreyev wants to merge 3 commits into
api-platform:2.5from
oleg-andreyev:custom-doctrine-type

Conversation

@oleg-andreyev

Copy link
Copy Markdown
Contributor
QA
Bug fix?yes
New feature?no
BC breaks?no
Deprecations?no
Tickets-
LicenseMIT
Doc PR-

When usinguuid_binary_ordered_time (ramsey/uuid) as PK and then trying to filter list by association.id
ORM is not callingUuidBinaryOrderedTimeType because type is not passed to QueryBuilder parameters.

@soyuka
soyukaforce-pushed the custom-doctrine-type branch from 4ad1edb to 9204027CompareApril 15, 2020 14:48
@soyukasoyuka mentioned this pull request Apr 15, 2020
Merged
@soyuka

Copy link
Copy Markdown
Member

cs fixes unrelated, thanks @oleg-andreyev

@soyukasoyuka closed this Apr 15, 2020
soyuka added a commit to soyuka/core that referenced this pull request Apr 24, 2020
Adds correct deprecations to introduce back api-platform#3331
@bendavies

bendavies commented Apr 27, 2020

Copy link
Copy Markdown
Contributor

@soyuka This doesn't work with array values for WHERE IN queries, where the type should be Connection::PARAM_STR_ARRAY or Connection::PARAM_INT_ARRAY etc...
Surprised there isn't a behat scenario that covers this!

@guilliamxavier

Copy link
Copy Markdown
Contributor

FTR, this has been reverted (#3520) in version 2.5.6

@soyuka

Copy link
Copy Markdown
Member

re-opened in #3521 needs work though (don't hesitate to take it over)

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@oleg-andreyev@soyuka@bendavies@guilliamxavier