Skip to content

feat(pagination): Add UuidRangeFilter to allow Uuid cursors - #4689

Closed
KDederichs wants to merge 13 commits into
api-platform:mainfrom
KDederichs:uuid_range
Closed

feat(pagination): Add UuidRangeFilter to allow Uuid cursors#4689
KDederichs wants to merge 13 commits into
api-platform:mainfrom
KDederichs:uuid_range

Conversation

@KDederichs

Copy link
Copy Markdown
Contributor
QA
Branch?main
Tickets#8033
LicenseMIT
Doc PRapi-platform/docs#1520

As requested in #4595 I moved the Uuid Range to be its own thing.
I hope I managed to catch all the services that need to be wired if not let me know!

@Xusifob

Copy link
Copy Markdown

Where is the status on this PR ? :)

@stale

staleBot commented Nov 4, 2022

Copy link
Copy Markdown

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stalestaleBot added the wontfix label Nov 4, 2022
@nesl247

Copy link
Copy Markdown
Contributor

This is still really needed.

@stalestaleBot removed the wontfix label Nov 4, 2022
@stale

staleBot commented Jan 3, 2023

Copy link
Copy Markdown

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stalestaleBot added the stale label Jan 3, 2023
@Xusifob

Copy link
Copy Markdown

this is still needed

@stalestaleBot removed the stale label Jan 4, 2023
@stale

staleBot commented Mar 5, 2023

Copy link
Copy Markdown

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stalestaleBot added the stale label Mar 5, 2023
@Xusifob

Copy link
Copy Markdown

This is still needed

@stalestaleBot removed the stale label Mar 6, 2023
@nesl247

Copy link
Copy Markdown
Contributor

What’s preventing this from being merged?

@stale

staleBot commented May 19, 2023

Copy link
Copy Markdown

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stalestaleBot added the stale label May 19, 2023
@nesl247

Copy link
Copy Markdown
Contributor

This is still needed.

@stalestaleBot closed this May 27, 2023
@KDederichs

Copy link
Copy Markdown
ContributorAuthor

@soyuka
Since I ran into this yet again:
Should we re open this?

With the emergence and popularity of UUIDv7 this become rather relevant, at least if you try to do cursor based pagination with that.

@soyuka

soyuka commented Oct 28, 2023

Copy link
Copy Markdown
Member

#5618 has reasons why this still hasn't been merged...

@soyukasoyuka reopened this Oct 28, 2023
@stalestaleBot removed the stale label Oct 28, 2023
# Conflicts:
#	.github/workflows/ci.yml
#	src/Doctrine/Common/Filter/RangeFilterTrait.php
#	src/Doctrine/Odm/Filter/RangeFilter.php
#	src/Doctrine/Orm/Filter/RangeFilter.php
#	tests/Fixtures/app/config/config_test.yml
@soyukasoyuka self-assigned this Dec 4, 2025
@soyuka

Copy link
Copy Markdown
Member

I've reviewed this a bit and I really like the work, I'd like try to find some time to refactor/merge this.
I think that we need to take all this work back and add it to the next api platform version its a great addition.

@soyuka

Copy link
Copy Markdown
Member

Closing a 4 years old pr is always a thing ! Thanks for putting time into this, I took the idea and modernized it to a new ComparisonFilter (coming in the 4.3 release).

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@KDederichs@Xusifob@nesl247@soyuka