Uh oh!
There was an error while loading. Please reload this page.
GraphQL: Support Enum collections - #5955
Merged
Merged
Conversation
soyuka
approved these changes
Nov 22, 2023
soyuka
left a comment
Member
There was a problem hiding this comment.
Nice, could you rebase against main though it looks like there's a commit that doesn't belong to this patch. Commit should be: feat(graphql): ...
jotweaforce-pushed
the
enum-collection
branch
2 times, most recently
from
November 23, 2023 13:19
23c2cf2 to
c971810Compare
soyuka
commented
Nov 24, 2023
Member
nice thanks@jotwea! |
soyuka pushed a commit
to anoziere/core
that referenced
this pull request
Dec 18, 2023
Co-authored-by: josef.wagner <josef.wagner@hf-solutions.co>
priyadi pushed a commit
to priyadi/core
that referenced
this pull request
Jan 3, 2024
Co-authored-by: josef.wagner <josef.wagner@hf-solutions.co>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We have a resource with an array property. The content of this array are enum values. This information can be provided with a doc block. Unfortunatelly on the GraphQL API this was visible as an
iterable. With the changes in this PR it will be a proper "array of enum", same like i.e. "array of string".The Behat tests should give you an insight into the details.