Skip to content

fix(symfony): check if required package is installed before configuri… - #7607

Merged
soyuka merged 2 commits into
api-platform:4.2from
aaa2000:feat-7053-conf-validation
Dec 15, 2025
Merged

fix(symfony): check if required package is installed before configuri…#7607
soyuka merged 2 commits into
api-platform:4.2from
aaa2000:feat-7053-conf-validation

Conversation

@aaa2000

@aaa2000aaa2000 commented Dec 14, 2025

Copy link
Copy Markdown
Contributor
QA
Branch4.2
TicketsCloses#7053
LicenseMIT

Check if required package is installed before configuring associated services.

I haven’t included tests for this change because I’m not sure how to properly test this part of the code

Note: The Behat errors in CI are already present on branch 4.2

@aaa2000
aaa2000force-pushed the feat-7053-conf-validation branch 2 times, most recently from 0c8c3be to e5f5c89CompareDecember 14, 2025 12:09
@aaa2000
aaa2000force-pushed the feat-7053-conf-validation branch 4 times, most recently from 94d540e to 86a632dCompareDecember 14, 2025 18:40
Comment threadcomposer.json
"illuminate/support": "^11.0 || ^12.0",
"jangregor/phpstan-prophecy": "^2.1.11",
"justinrainbow/json-schema": "^5.2.11",
"justinrainbow/json-schema": "5.3.0",

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct by downgrading the package version of jsonrainbow/json-schema from 5.3.1 to 5.3.0

Strangely, the fix https://github.com/jsonrainbow/json-schema/pull/857/changes caused the errors in the CI. And I couldn't reproduce the problem locally.

@aaa2000
aaa2000force-pushed the feat-7053-conf-validation branch from e181ae7 to 111b5a8CompareDecember 14, 2025 23:30
Comment threadcomposer.json
@soyukasoyuka changed the title feat(symfony) check if required package is installed before configuri…fix(symfony): check if required package is installed before configuri…Dec 15, 2025
@soyuka
soyuka merged commit 2a34498 into api-platform:4.2Dec 15, 2025
258 checks passed
@soyuka

Copy link
Copy Markdown
Member

thanks!

Maxcastel pushed a commit to Maxcastel/api-platform-core that referenced this pull request Jan 26, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@aaa2000@soyuka