fix(server): derive etcd endpoint on subsequent boot from cp_base_url

[jarvis9443]

The bundle_on_disk branch (subsequent boot with persisted mTLS bundle) restored TLS config and env_id but never updated cfg.etcd.endpoints, leaving the placeholder https://placeholder-overridden-at-register:2379 from config.managed.yaml in place. The DP then failed to connect to the control plane etcd/kine endpoint until the volume was removed.

This extracts derive_cp_etcd_url() and uses it in both the cert-bundle provision path and the bundle_on_disk path, so subsequent boots always resolve the real etcd endpoint from AISIX_MANAGED__CP_BASE_URL (or AISIX_MANAGED__CP_ETCD_ENDPOINT when explicitly set).

Closes api7/AISIX-Cloud#289

Summary by CodeRabbit

• Bug Fixes

  • Fixed stale etcd endpoint handling in managed-mode bootstrap and when reusing persisted mTLS bundles.
  • Improved control-plane URL derivation during certificate provisioning and heartbeat construction—now validates base URLs, strips URL schemes, and trims trailing slashes.

• Tests

  • Added unit tests for URL derivation, explicit endpoint preference, scheme stripping, and error cases.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: ffbee559-2640-44d4-94f7-dc1b532b01ed

📥 Commits

Reviewing files that changed from the base of the PR and between aef2d91 and d685da4.

📒 Files selected for processing (1)

• crates/aisix-server/src/main.rs

🚧 Files skipped from review as they are similar to previous changes (1)

• crates/aisix-server/src/main.rs

---

📝 Walkthrough

Walkthrough

Adds derive_cp_etcd_url to normalize/produce an https:// etcd endpoint from managed config, uses it in both managed-mode bootstrap paths to set cfg.etcd.endpoints and log the derived endpoint, validates heartbeat URL construction, and adds unit tests for derivation cases and errors.

Changes

Etcd Endpoint Derivation Helper and Bootstrap Integration

Layer / File(s)	Summary
Helper function implementation crates/aisix-server/src/main.rs	Adds derive_cp_etcd_url(managed: &ManagedConfig) -> anyhow::Result<String> helper that prefers cp_etcd_endpoint, validates non-empty cp_base_url, strips http:///https:// prefixes from cp_base_url, trims trailing /, and returns an https://<host:port> endpoint string.
Dashboard cert bundle bootstrap integration crates/aisix-server/src/main.rs	In the dashboard-issued certificate provisioning path, calls derive_cp_etcd_url to compute the etcd endpoint, logs it with dp_id and env_id, assigns it to cfg.etcd.endpoints, and validates/trims cp_base_url before building the /dp/heartbeat URL.
Persisted mTLS bundle bootstrap integration crates/aisix-server/src/main.rs	In the persisted mTLS reuse path on subsequent boots, calls derive_cp_etcd_url to replace stale placeholder endpoints, logs the derived endpoint, and overwrites cfg.etcd.endpoints.
Unit tests crates/aisix-server/src/main.rs	Adds unit tests validating derive_cp_etcd_url for scheme stripping (http:// and https://), explicit cp_etcd_endpoint precedence, trailing slash trimming, http inputs, and expected failures when cp_base_url is missing or empty.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related issues

• #289: QA: DP restart with persisted mTLS bundle can reuse placeholder endpoint

🚥 Pre-merge checks | ✅ 4

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title directly describes the main fix: deriving the etcd endpoint on subsequent boot from cp_base_url, which is the core change shown in the raw summary and PR objectives.
Linked Issues check	✅ Passed	The code changes address the core issue by implementing derive_cp_etcd_url() to resolve the real etcd endpoint from cp_base_url (or cp_etcd_endpoint) on both initial provision and subsequent boots, fixing the placeholder endpoint problem documented in #289.
Out of Scope Changes check	✅ Passed	All changes focus on resolving etcd endpoint derivation for the managed-mode bootstrap path; no unrelated alterations to other functionality or modules are evident in the changeset.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[Copilot]

Pull request overview

This PR fixes managed-mode subsequent boot behavior by deriving and applying the real etcd endpoint when an mTLS bundle already exists, avoiding reuse of the placeholder endpoint from config.managed.yaml.

Changes:

• Extracts shared derive_cp_etcd_url() logic.
• Uses derived etcd URL in both cert-bundle provisioning and bundle-on-disk managed boot paths.
• Adds unit tests for deriving etcd URLs from base URL and explicit endpoint inputs.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@crates/aisix-server/src/main.rs`:
- Around line 756-775: The code currently forces cp_base (managed.cp_base_url)
to be present before checking cp_etcd, which breaks the intended precedence
where an explicit managed.cp_etcd_endpoint should be accepted; change the logic
so you first attempt to read managed.cp_etcd_endpoint (as_deref().filter(|s|
!s.is_empty())) and if that yields Some, use it for cp_etcd; only when cp_etcd
is missing should you then try to derive it from managed.cp_base_url
(strip_prefix http/https) and if cp_base is absent/error then return the anyhow
error. Update the cp_etcd and cp_base variable handling accordingly (references:
cp_etcd, cp_base, managed.cp_etcd_endpoint, managed.cp_base_url).

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 33d6b8ef-8a81-46df-9a5a-748cdb08e39c

📥 Commits

Reviewing files that changed from the base of the PR and between 068aa1f and ac060c7.

📒 Files selected for processing (1)

• crates/aisix-server/src/main.rs

[Copilot]

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 2 comments.

[jarvis9443]

The bundle_on_disk branch (subsequent boot with persisted mTLS bundle) restored TLS config and env_id but never updated cfg.etcd.endpoints, leaving the placeholder https://placeholder-overridden-at-register:2379 from config.managed.yaml in place. The DP then failed to connect to the control plane etcd/kine endpoint until the volume was removed.

This extracts derive_cp_etcd_url() and uses it in both the cert-bundle provision path and the bundle_on_disk path, so subsequent boots always resolve the real etcd endpoint from AISIX_MANAGED__CP_BASE_URL (or AISIX_MANAGED__CP_ETCD_ENDPOINT when explicitly set).

Closes api7/AISIX-Cloud#289

Summary by CodeRabbit

• Bug Fixes

  • Fixed stale etcd endpoint handling in managed-mode bootstrap and when reusing persisted mTLS bundles.
  • Improved control-plane URL derivation during certificate provisioning and heartbeat construction—now validates base URLs, strips URL schemes, and trims trailing slashes.

• Tests

  • Added unit tests for URL derivation, explicit endpoint preference, scheme stripping, and error cases.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: ffbee559-2640-44d4-94f7-dc1b532b01ed

📥 Commits

Reviewing files that changed from the base of the PR and between aef2d91 and d685da4.

📒 Files selected for processing (1)

• crates/aisix-server/src/main.rs

🚧 Files skipped from review as they are similar to previous changes (1)

• crates/aisix-server/src/main.rs

---

📝 Walkthrough

Walkthrough

Adds derive_cp_etcd_url to normalize/produce an https:// etcd endpoint from managed config, uses it in both managed-mode bootstrap paths to set cfg.etcd.endpoints and log the derived endpoint, validates heartbeat URL construction, and adds unit tests for derivation cases and errors.

Changes

Etcd Endpoint Derivation Helper and Bootstrap Integration

Layer / File(s)	Summary
Helper function implementation crates/aisix-server/src/main.rs	Adds derive_cp_etcd_url(managed: &ManagedConfig) -> anyhow::Result<String> helper that prefers cp_etcd_endpoint, validates non-empty cp_base_url, strips http:///https:// prefixes from cp_base_url, trims trailing /, and returns an https://<host:port> endpoint string.
Dashboard cert bundle bootstrap integration crates/aisix-server/src/main.rs	In the dashboard-issued certificate provisioning path, calls derive_cp_etcd_url to compute the etcd endpoint, logs it with dp_id and env_id, assigns it to cfg.etcd.endpoints, and validates/trims cp_base_url before building the /dp/heartbeat URL.
Persisted mTLS bundle bootstrap integration crates/aisix-server/src/main.rs	In the persisted mTLS reuse path on subsequent boots, calls derive_cp_etcd_url to replace stale placeholder endpoints, logs the derived endpoint, and overwrites cfg.etcd.endpoints.
Unit tests crates/aisix-server/src/main.rs	Adds unit tests validating derive_cp_etcd_url for scheme stripping (http:// and https://), explicit cp_etcd_endpoint precedence, trailing slash trimming, http inputs, and expected failures when cp_base_url is missing or empty.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related issues

• #289: QA: DP restart with persisted mTLS bundle can reuse placeholder endpoint

🚥 Pre-merge checks | ✅ 4

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title directly describes the main fix: deriving the etcd endpoint on subsequent boot from cp_base_url, which is the core change shown in the raw summary and PR objectives.
Linked Issues check	✅ Passed	The code changes address the core issue by implementing derive_cp_etcd_url() to resolve the real etcd endpoint from cp_base_url (or cp_etcd_endpoint) on both initial provision and subsequent boots, fixing the placeholder endpoint problem documented in #289.
Out of Scope Changes check	✅ Passed	All changes focus on resolving etcd endpoint derivation for the managed-mode bootstrap path; no unrelated alterations to other functionality or modules are evident in the changeset.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[Copilot]

Pull request overview

This PR fixes managed-mode subsequent boot behavior by deriving and applying the real etcd endpoint when an mTLS bundle already exists, avoiding reuse of the placeholder endpoint from config.managed.yaml.

Changes:

• Extracts shared derive_cp_etcd_url() logic.
• Uses derived etcd URL in both cert-bundle provisioning and bundle-on-disk managed boot paths.
• Adds unit tests for deriving etcd URLs from base URL and explicit endpoint inputs.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@crates/aisix-server/src/main.rs`:
- Around line 756-775: The code currently forces cp_base (managed.cp_base_url)
to be present before checking cp_etcd, which breaks the intended precedence
where an explicit managed.cp_etcd_endpoint should be accepted; change the logic
so you first attempt to read managed.cp_etcd_endpoint (as_deref().filter(|s|
!s.is_empty())) and if that yields Some, use it for cp_etcd; only when cp_etcd
is missing should you then try to derive it from managed.cp_base_url
(strip_prefix http/https) and if cp_base is absent/error then return the anyhow
error. Update the cp_etcd and cp_base variable handling accordingly (references:
cp_etcd, cp_base, managed.cp_etcd_endpoint, managed.cp_base_url).

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 33d6b8ef-8a81-46df-9a5a-748cdb08e39c

📥 Commits

Reviewing files that changed from the base of the PR and between 068aa1f and ac060c7.

📒 Files selected for processing (1)

• crates/aisix-server/src/main.rs

[Copilot]

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 2 comments.

[jarvis9443]

The bundle_on_disk branch (subsequent boot with persisted mTLS bundle) restored TLS config and env_id but never updated cfg.etcd.endpoints, leaving the placeholder https://placeholder-overridden-at-register:2379 from config.managed.yaml in place. The DP then failed to connect to the control plane etcd/kine endpoint until the volume was removed.

This extracts derive_cp_etcd_url() and uses it in both the cert-bundle provision path and the bundle_on_disk path, so subsequent boots always resolve the real etcd endpoint from AISIX_MANAGED__CP_BASE_URL (or AISIX_MANAGED__CP_ETCD_ENDPOINT when explicitly set).

Closes api7/AISIX-Cloud#289

Summary by CodeRabbit

• Bug Fixes

  • Fixed stale etcd endpoint handling in managed-mode bootstrap and when reusing persisted mTLS bundles.
  • Improved control-plane URL derivation during certificate provisioning and heartbeat construction—now validates base URLs, strips URL schemes, and trims trailing slashes.

• Tests

  • Added unit tests for URL derivation, explicit endpoint preference, scheme stripping, and error cases.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: ffbee559-2640-44d4-94f7-dc1b532b01ed

📥 Commits

Reviewing files that changed from the base of the PR and between aef2d91 and d685da4.

📒 Files selected for processing (1)

• crates/aisix-server/src/main.rs

🚧 Files skipped from review as they are similar to previous changes (1)

• crates/aisix-server/src/main.rs

---

📝 Walkthrough

Walkthrough

Adds derive_cp_etcd_url to normalize/produce an https:// etcd endpoint from managed config, uses it in both managed-mode bootstrap paths to set cfg.etcd.endpoints and log the derived endpoint, validates heartbeat URL construction, and adds unit tests for derivation cases and errors.

Changes

Etcd Endpoint Derivation Helper and Bootstrap Integration

Layer / File(s)	Summary
Helper function implementation crates/aisix-server/src/main.rs	Adds derive_cp_etcd_url(managed: &ManagedConfig) -> anyhow::Result<String> helper that prefers cp_etcd_endpoint, validates non-empty cp_base_url, strips http:///https:// prefixes from cp_base_url, trims trailing /, and returns an https://<host:port> endpoint string.
Dashboard cert bundle bootstrap integration crates/aisix-server/src/main.rs	In the dashboard-issued certificate provisioning path, calls derive_cp_etcd_url to compute the etcd endpoint, logs it with dp_id and env_id, assigns it to cfg.etcd.endpoints, and validates/trims cp_base_url before building the /dp/heartbeat URL.
Persisted mTLS bundle bootstrap integration crates/aisix-server/src/main.rs	In the persisted mTLS reuse path on subsequent boots, calls derive_cp_etcd_url to replace stale placeholder endpoints, logs the derived endpoint, and overwrites cfg.etcd.endpoints.
Unit tests crates/aisix-server/src/main.rs	Adds unit tests validating derive_cp_etcd_url for scheme stripping (http:// and https://), explicit cp_etcd_endpoint precedence, trailing slash trimming, http inputs, and expected failures when cp_base_url is missing or empty.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related issues

• #289: QA: DP restart with persisted mTLS bundle can reuse placeholder endpoint

🚥 Pre-merge checks | ✅ 4

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title directly describes the main fix: deriving the etcd endpoint on subsequent boot from cp_base_url, which is the core change shown in the raw summary and PR objectives.
Linked Issues check	✅ Passed	The code changes address the core issue by implementing derive_cp_etcd_url() to resolve the real etcd endpoint from cp_base_url (or cp_etcd_endpoint) on both initial provision and subsequent boots, fixing the placeholder endpoint problem documented in #289.
Out of Scope Changes check	✅ Passed	All changes focus on resolving etcd endpoint derivation for the managed-mode bootstrap path; no unrelated alterations to other functionality or modules are evident in the changeset.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[Copilot]

Pull request overview

This PR fixes managed-mode subsequent boot behavior by deriving and applying the real etcd endpoint when an mTLS bundle already exists, avoiding reuse of the placeholder endpoint from config.managed.yaml.

Changes:

• Extracts shared derive_cp_etcd_url() logic.
• Uses derived etcd URL in both cert-bundle provisioning and bundle-on-disk managed boot paths.
• Adds unit tests for deriving etcd URLs from base URL and explicit endpoint inputs.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@crates/aisix-server/src/main.rs`:
- Around line 756-775: The code currently forces cp_base (managed.cp_base_url)
to be present before checking cp_etcd, which breaks the intended precedence
where an explicit managed.cp_etcd_endpoint should be accepted; change the logic
so you first attempt to read managed.cp_etcd_endpoint (as_deref().filter(|s|
!s.is_empty())) and if that yields Some, use it for cp_etcd; only when cp_etcd
is missing should you then try to derive it from managed.cp_base_url
(strip_prefix http/https) and if cp_base is absent/error then return the anyhow
error. Update the cp_etcd and cp_base variable handling accordingly (references:
cp_etcd, cp_base, managed.cp_etcd_endpoint, managed.cp_base_url).

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 33d6b8ef-8a81-46df-9a5a-748cdb08e39c

📥 Commits

Reviewing files that changed from the base of the PR and between 068aa1f and ac060c7.

📒 Files selected for processing (1)

• crates/aisix-server/src/main.rs

[Copilot]

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 2 comments.

[jarvis9443]

The bundle_on_disk branch (subsequent boot with persisted mTLS bundle) restored TLS config and env_id but never updated cfg.etcd.endpoints, leaving the placeholder https://placeholder-overridden-at-register:2379 from config.managed.yaml in place. The DP then failed to connect to the control plane etcd/kine endpoint until the volume was removed.

This extracts derive_cp_etcd_url() and uses it in both the cert-bundle provision path and the bundle_on_disk path, so subsequent boots always resolve the real etcd endpoint from AISIX_MANAGED__CP_BASE_URL (or AISIX_MANAGED__CP_ETCD_ENDPOINT when explicitly set).

Closes api7/AISIX-Cloud#289

Summary by CodeRabbit

• Bug Fixes

  • Fixed stale etcd endpoint handling in managed-mode bootstrap and when reusing persisted mTLS bundles.
  • Improved control-plane URL derivation during certificate provisioning and heartbeat construction—now validates base URLs, strips URL schemes, and trims trailing slashes.

• Tests

  • Added unit tests for URL derivation, explicit endpoint preference, scheme stripping, and error cases.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: ffbee559-2640-44d4-94f7-dc1b532b01ed

📥 Commits

Reviewing files that changed from the base of the PR and between aef2d91 and d685da4.

📒 Files selected for processing (1)

• crates/aisix-server/src/main.rs

🚧 Files skipped from review as they are similar to previous changes (1)

• crates/aisix-server/src/main.rs

---

📝 Walkthrough

Walkthrough

Adds derive_cp_etcd_url to normalize/produce an https:// etcd endpoint from managed config, uses it in both managed-mode bootstrap paths to set cfg.etcd.endpoints and log the derived endpoint, validates heartbeat URL construction, and adds unit tests for derivation cases and errors.

Changes

Etcd Endpoint Derivation Helper and Bootstrap Integration

Layer / File(s)	Summary
Helper function implementation crates/aisix-server/src/main.rs	Adds derive_cp_etcd_url(managed: &ManagedConfig) -> anyhow::Result<String> helper that prefers cp_etcd_endpoint, validates non-empty cp_base_url, strips http:///https:// prefixes from cp_base_url, trims trailing /, and returns an https://<host:port> endpoint string.
Dashboard cert bundle bootstrap integration crates/aisix-server/src/main.rs	In the dashboard-issued certificate provisioning path, calls derive_cp_etcd_url to compute the etcd endpoint, logs it with dp_id and env_id, assigns it to cfg.etcd.endpoints, and validates/trims cp_base_url before building the /dp/heartbeat URL.
Persisted mTLS bundle bootstrap integration crates/aisix-server/src/main.rs	In the persisted mTLS reuse path on subsequent boots, calls derive_cp_etcd_url to replace stale placeholder endpoints, logs the derived endpoint, and overwrites cfg.etcd.endpoints.
Unit tests crates/aisix-server/src/main.rs	Adds unit tests validating derive_cp_etcd_url for scheme stripping (http:// and https://), explicit cp_etcd_endpoint precedence, trailing slash trimming, http inputs, and expected failures when cp_base_url is missing or empty.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related issues

• #289: QA: DP restart with persisted mTLS bundle can reuse placeholder endpoint

🚥 Pre-merge checks | ✅ 4

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title directly describes the main fix: deriving the etcd endpoint on subsequent boot from cp_base_url, which is the core change shown in the raw summary and PR objectives.
Linked Issues check	✅ Passed	The code changes address the core issue by implementing derive_cp_etcd_url() to resolve the real etcd endpoint from cp_base_url (or cp_etcd_endpoint) on both initial provision and subsequent boots, fixing the placeholder endpoint problem documented in #289.
Out of Scope Changes check	✅ Passed	All changes focus on resolving etcd endpoint derivation for the managed-mode bootstrap path; no unrelated alterations to other functionality or modules are evident in the changeset.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[Copilot]

Pull request overview

This PR fixes managed-mode subsequent boot behavior by deriving and applying the real etcd endpoint when an mTLS bundle already exists, avoiding reuse of the placeholder endpoint from config.managed.yaml.

Changes:

• Extracts shared derive_cp_etcd_url() logic.
• Uses derived etcd URL in both cert-bundle provisioning and bundle-on-disk managed boot paths.
• Adds unit tests for deriving etcd URLs from base URL and explicit endpoint inputs.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@crates/aisix-server/src/main.rs`:
- Around line 756-775: The code currently forces cp_base (managed.cp_base_url)
to be present before checking cp_etcd, which breaks the intended precedence
where an explicit managed.cp_etcd_endpoint should be accepted; change the logic
so you first attempt to read managed.cp_etcd_endpoint (as_deref().filter(|s|
!s.is_empty())) and if that yields Some, use it for cp_etcd; only when cp_etcd
is missing should you then try to derive it from managed.cp_base_url
(strip_prefix http/https) and if cp_base is absent/error then return the anyhow
error. Update the cp_etcd and cp_base variable handling accordingly (references:
cp_etcd, cp_base, managed.cp_etcd_endpoint, managed.cp_base_url).

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 33d6b8ef-8a81-46df-9a5a-748cdb08e39c

📥 Commits

Reviewing files that changed from the base of the PR and between 068aa1f and ac060c7.

📒 Files selected for processing (1)

• crates/aisix-server/src/main.rs

[Copilot]

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 2 comments.

[jarvis9443]

The bundle_on_disk branch (subsequent boot with persisted mTLS bundle) restored TLS config and env_id but never updated cfg.etcd.endpoints, leaving the placeholder https://placeholder-overridden-at-register:2379 from config.managed.yaml in place. The DP then failed to connect to the control plane etcd/kine endpoint until the volume was removed.

This extracts derive_cp_etcd_url() and uses it in both the cert-bundle provision path and the bundle_on_disk path, so subsequent boots always resolve the real etcd endpoint from AISIX_MANAGED__CP_BASE_URL (or AISIX_MANAGED__CP_ETCD_ENDPOINT when explicitly set).

Closes api7/AISIX-Cloud#289

Summary by CodeRabbit

• Bug Fixes

  • Fixed stale etcd endpoint handling in managed-mode bootstrap and when reusing persisted mTLS bundles.
  • Improved control-plane URL derivation during certificate provisioning and heartbeat construction—now validates base URLs, strips URL schemes, and trims trailing slashes.

• Tests

  • Added unit tests for URL derivation, explicit endpoint preference, scheme stripping, and error cases.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: ffbee559-2640-44d4-94f7-dc1b532b01ed

📥 Commits

Reviewing files that changed from the base of the PR and between aef2d91 and d685da4.

📒 Files selected for processing (1)

• crates/aisix-server/src/main.rs

🚧 Files skipped from review as they are similar to previous changes (1)

• crates/aisix-server/src/main.rs

---

📝 Walkthrough

Walkthrough

Adds derive_cp_etcd_url to normalize/produce an https:// etcd endpoint from managed config, uses it in both managed-mode bootstrap paths to set cfg.etcd.endpoints and log the derived endpoint, validates heartbeat URL construction, and adds unit tests for derivation cases and errors.

Changes

Etcd Endpoint Derivation Helper and Bootstrap Integration

Layer / File(s)	Summary
Helper function implementation crates/aisix-server/src/main.rs	Adds derive_cp_etcd_url(managed: &ManagedConfig) -> anyhow::Result<String> helper that prefers cp_etcd_endpoint, validates non-empty cp_base_url, strips http:///https:// prefixes from cp_base_url, trims trailing /, and returns an https://<host:port> endpoint string.
Dashboard cert bundle bootstrap integration crates/aisix-server/src/main.rs	In the dashboard-issued certificate provisioning path, calls derive_cp_etcd_url to compute the etcd endpoint, logs it with dp_id and env_id, assigns it to cfg.etcd.endpoints, and validates/trims cp_base_url before building the /dp/heartbeat URL.
Persisted mTLS bundle bootstrap integration crates/aisix-server/src/main.rs	In the persisted mTLS reuse path on subsequent boots, calls derive_cp_etcd_url to replace stale placeholder endpoints, logs the derived endpoint, and overwrites cfg.etcd.endpoints.
Unit tests crates/aisix-server/src/main.rs	Adds unit tests validating derive_cp_etcd_url for scheme stripping (http:// and https://), explicit cp_etcd_endpoint precedence, trailing slash trimming, http inputs, and expected failures when cp_base_url is missing or empty.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related issues

• #289: QA: DP restart with persisted mTLS bundle can reuse placeholder endpoint

🚥 Pre-merge checks | ✅ 4

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title directly describes the main fix: deriving the etcd endpoint on subsequent boot from cp_base_url, which is the core change shown in the raw summary and PR objectives.
Linked Issues check	✅ Passed	The code changes address the core issue by implementing derive_cp_etcd_url() to resolve the real etcd endpoint from cp_base_url (or cp_etcd_endpoint) on both initial provision and subsequent boots, fixing the placeholder endpoint problem documented in #289.
Out of Scope Changes check	✅ Passed	All changes focus on resolving etcd endpoint derivation for the managed-mode bootstrap path; no unrelated alterations to other functionality or modules are evident in the changeset.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[Copilot]

Pull request overview

This PR fixes managed-mode subsequent boot behavior by deriving and applying the real etcd endpoint when an mTLS bundle already exists, avoiding reuse of the placeholder endpoint from config.managed.yaml.

Changes:

• Extracts shared derive_cp_etcd_url() logic.
• Uses derived etcd URL in both cert-bundle provisioning and bundle-on-disk managed boot paths.
• Adds unit tests for deriving etcd URLs from base URL and explicit endpoint inputs.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@crates/aisix-server/src/main.rs`:
- Around line 756-775: The code currently forces cp_base (managed.cp_base_url)
to be present before checking cp_etcd, which breaks the intended precedence
where an explicit managed.cp_etcd_endpoint should be accepted; change the logic
so you first attempt to read managed.cp_etcd_endpoint (as_deref().filter(|s|
!s.is_empty())) and if that yields Some, use it for cp_etcd; only when cp_etcd
is missing should you then try to derive it from managed.cp_base_url
(strip_prefix http/https) and if cp_base is absent/error then return the anyhow
error. Update the cp_etcd and cp_base variable handling accordingly (references:
cp_etcd, cp_base, managed.cp_etcd_endpoint, managed.cp_base_url).

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 33d6b8ef-8a81-46df-9a5a-748cdb08e39c

📥 Commits

Reviewing files that changed from the base of the PR and between 068aa1f and ac060c7.

📒 Files selected for processing (1)

• crates/aisix-server/src/main.rs

[Copilot]

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 2 comments.

[jarvis9443]

The bundle_on_disk branch (subsequent boot with persisted mTLS bundle) restored TLS config and env_id but never updated cfg.etcd.endpoints, leaving the placeholder https://placeholder-overridden-at-register:2379 from config.managed.yaml in place. The DP then failed to connect to the control plane etcd/kine endpoint until the volume was removed.

This extracts derive_cp_etcd_url() and uses it in both the cert-bundle provision path and the bundle_on_disk path, so subsequent boots always resolve the real etcd endpoint from AISIX_MANAGED__CP_BASE_URL (or AISIX_MANAGED__CP_ETCD_ENDPOINT when explicitly set).

Closes api7/AISIX-Cloud#289

Summary by CodeRabbit

• Bug Fixes

  • Fixed stale etcd endpoint handling in managed-mode bootstrap and when reusing persisted mTLS bundles.
  • Improved control-plane URL derivation during certificate provisioning and heartbeat construction—now validates base URLs, strips URL schemes, and trims trailing slashes.

• Tests

  • Added unit tests for URL derivation, explicit endpoint preference, scheme stripping, and error cases.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: ffbee559-2640-44d4-94f7-dc1b532b01ed

📥 Commits

Reviewing files that changed from the base of the PR and between aef2d91 and d685da4.

📒 Files selected for processing (1)

• crates/aisix-server/src/main.rs

🚧 Files skipped from review as they are similar to previous changes (1)

• crates/aisix-server/src/main.rs

---

📝 Walkthrough

Walkthrough

Adds derive_cp_etcd_url to normalize/produce an https:// etcd endpoint from managed config, uses it in both managed-mode bootstrap paths to set cfg.etcd.endpoints and log the derived endpoint, validates heartbeat URL construction, and adds unit tests for derivation cases and errors.

Changes

Etcd Endpoint Derivation Helper and Bootstrap Integration

Layer / File(s)	Summary
Helper function implementation crates/aisix-server/src/main.rs	Adds derive_cp_etcd_url(managed: &ManagedConfig) -> anyhow::Result<String> helper that prefers cp_etcd_endpoint, validates non-empty cp_base_url, strips http:///https:// prefixes from cp_base_url, trims trailing /, and returns an https://<host:port> endpoint string.
Dashboard cert bundle bootstrap integration crates/aisix-server/src/main.rs	In the dashboard-issued certificate provisioning path, calls derive_cp_etcd_url to compute the etcd endpoint, logs it with dp_id and env_id, assigns it to cfg.etcd.endpoints, and validates/trims cp_base_url before building the /dp/heartbeat URL.
Persisted mTLS bundle bootstrap integration crates/aisix-server/src/main.rs	In the persisted mTLS reuse path on subsequent boots, calls derive_cp_etcd_url to replace stale placeholder endpoints, logs the derived endpoint, and overwrites cfg.etcd.endpoints.
Unit tests crates/aisix-server/src/main.rs	Adds unit tests validating derive_cp_etcd_url for scheme stripping (http:// and https://), explicit cp_etcd_endpoint precedence, trailing slash trimming, http inputs, and expected failures when cp_base_url is missing or empty.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related issues

• #289: QA: DP restart with persisted mTLS bundle can reuse placeholder endpoint

🚥 Pre-merge checks | ✅ 4

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title directly describes the main fix: deriving the etcd endpoint on subsequent boot from cp_base_url, which is the core change shown in the raw summary and PR objectives.
Linked Issues check	✅ Passed	The code changes address the core issue by implementing derive_cp_etcd_url() to resolve the real etcd endpoint from cp_base_url (or cp_etcd_endpoint) on both initial provision and subsequent boots, fixing the placeholder endpoint problem documented in #289.
Out of Scope Changes check	✅ Passed	All changes focus on resolving etcd endpoint derivation for the managed-mode bootstrap path; no unrelated alterations to other functionality or modules are evident in the changeset.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[Copilot]

Pull request overview

This PR fixes managed-mode subsequent boot behavior by deriving and applying the real etcd endpoint when an mTLS bundle already exists, avoiding reuse of the placeholder endpoint from config.managed.yaml.

Changes:

• Extracts shared derive_cp_etcd_url() logic.
• Uses derived etcd URL in both cert-bundle provisioning and bundle-on-disk managed boot paths.
• Adds unit tests for deriving etcd URLs from base URL and explicit endpoint inputs.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@crates/aisix-server/src/main.rs`:
- Around line 756-775: The code currently forces cp_base (managed.cp_base_url)
to be present before checking cp_etcd, which breaks the intended precedence
where an explicit managed.cp_etcd_endpoint should be accepted; change the logic
so you first attempt to read managed.cp_etcd_endpoint (as_deref().filter(|s|
!s.is_empty())) and if that yields Some, use it for cp_etcd; only when cp_etcd
is missing should you then try to derive it from managed.cp_base_url
(strip_prefix http/https) and if cp_base is absent/error then return the anyhow
error. Update the cp_etcd and cp_base variable handling accordingly (references:
cp_etcd, cp_base, managed.cp_etcd_endpoint, managed.cp_base_url).

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 33d6b8ef-8a81-46df-9a5a-748cdb08e39c

📥 Commits

Reviewing files that changed from the base of the PR and between 068aa1f and ac060c7.

📒 Files selected for processing (1)

• crates/aisix-server/src/main.rs

[Copilot]

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 2 comments.

[jarvis9443]

The bundle_on_disk branch (subsequent boot with persisted mTLS bundle) restored TLS config and env_id but never updated cfg.etcd.endpoints, leaving the placeholder https://placeholder-overridden-at-register:2379 from config.managed.yaml in place. The DP then failed to connect to the control plane etcd/kine endpoint until the volume was removed.

This extracts derive_cp_etcd_url() and uses it in both the cert-bundle provision path and the bundle_on_disk path, so subsequent boots always resolve the real etcd endpoint from AISIX_MANAGED__CP_BASE_URL (or AISIX_MANAGED__CP_ETCD_ENDPOINT when explicitly set).

Closes api7/AISIX-Cloud#289

Summary by CodeRabbit

• Bug Fixes

  • Fixed stale etcd endpoint handling in managed-mode bootstrap and when reusing persisted mTLS bundles.
  • Improved control-plane URL derivation during certificate provisioning and heartbeat construction—now validates base URLs, strips URL schemes, and trims trailing slashes.

• Tests

  • Added unit tests for URL derivation, explicit endpoint preference, scheme stripping, and error cases.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: ffbee559-2640-44d4-94f7-dc1b532b01ed

📥 Commits

Reviewing files that changed from the base of the PR and between aef2d91 and d685da4.

📒 Files selected for processing (1)

• crates/aisix-server/src/main.rs

🚧 Files skipped from review as they are similar to previous changes (1)

• crates/aisix-server/src/main.rs

---

📝 Walkthrough

Walkthrough

Adds derive_cp_etcd_url to normalize/produce an https:// etcd endpoint from managed config, uses it in both managed-mode bootstrap paths to set cfg.etcd.endpoints and log the derived endpoint, validates heartbeat URL construction, and adds unit tests for derivation cases and errors.

Changes

Etcd Endpoint Derivation Helper and Bootstrap Integration

Layer / File(s)	Summary
Helper function implementation crates/aisix-server/src/main.rs	Adds derive_cp_etcd_url(managed: &ManagedConfig) -> anyhow::Result<String> helper that prefers cp_etcd_endpoint, validates non-empty cp_base_url, strips http:///https:// prefixes from cp_base_url, trims trailing /, and returns an https://<host:port> endpoint string.
Dashboard cert bundle bootstrap integration crates/aisix-server/src/main.rs	In the dashboard-issued certificate provisioning path, calls derive_cp_etcd_url to compute the etcd endpoint, logs it with dp_id and env_id, assigns it to cfg.etcd.endpoints, and validates/trims cp_base_url before building the /dp/heartbeat URL.
Persisted mTLS bundle bootstrap integration crates/aisix-server/src/main.rs	In the persisted mTLS reuse path on subsequent boots, calls derive_cp_etcd_url to replace stale placeholder endpoints, logs the derived endpoint, and overwrites cfg.etcd.endpoints.
Unit tests crates/aisix-server/src/main.rs	Adds unit tests validating derive_cp_etcd_url for scheme stripping (http:// and https://), explicit cp_etcd_endpoint precedence, trailing slash trimming, http inputs, and expected failures when cp_base_url is missing or empty.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related issues

• #289: QA: DP restart with persisted mTLS bundle can reuse placeholder endpoint

🚥 Pre-merge checks | ✅ 4

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title directly describes the main fix: deriving the etcd endpoint on subsequent boot from cp_base_url, which is the core change shown in the raw summary and PR objectives.
Linked Issues check	✅ Passed	The code changes address the core issue by implementing derive_cp_etcd_url() to resolve the real etcd endpoint from cp_base_url (or cp_etcd_endpoint) on both initial provision and subsequent boots, fixing the placeholder endpoint problem documented in #289.
Out of Scope Changes check	✅ Passed	All changes focus on resolving etcd endpoint derivation for the managed-mode bootstrap path; no unrelated alterations to other functionality or modules are evident in the changeset.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[Copilot]

Pull request overview

This PR fixes managed-mode subsequent boot behavior by deriving and applying the real etcd endpoint when an mTLS bundle already exists, avoiding reuse of the placeholder endpoint from config.managed.yaml.

Changes:

• Extracts shared derive_cp_etcd_url() logic.
• Uses derived etcd URL in both cert-bundle provisioning and bundle-on-disk managed boot paths.
• Adds unit tests for deriving etcd URLs from base URL and explicit endpoint inputs.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@crates/aisix-server/src/main.rs`:
- Around line 756-775: The code currently forces cp_base (managed.cp_base_url)
to be present before checking cp_etcd, which breaks the intended precedence
where an explicit managed.cp_etcd_endpoint should be accepted; change the logic
so you first attempt to read managed.cp_etcd_endpoint (as_deref().filter(|s|
!s.is_empty())) and if that yields Some, use it for cp_etcd; only when cp_etcd
is missing should you then try to derive it from managed.cp_base_url
(strip_prefix http/https) and if cp_base is absent/error then return the anyhow
error. Update the cp_etcd and cp_base variable handling accordingly (references:
cp_etcd, cp_base, managed.cp_etcd_endpoint, managed.cp_base_url).

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 33d6b8ef-8a81-46df-9a5a-748cdb08e39c

📥 Commits

Reviewing files that changed from the base of the PR and between 068aa1f and ac060c7.

📒 Files selected for processing (1)

• crates/aisix-server/src/main.rs

[Copilot]

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 2 comments.

[jarvis9443]

The bundle_on_disk branch (subsequent boot with persisted mTLS bundle) restored TLS config and env_id but never updated cfg.etcd.endpoints, leaving the placeholder https://placeholder-overridden-at-register:2379 from config.managed.yaml in place. The DP then failed to connect to the control plane etcd/kine endpoint until the volume was removed.

This extracts derive_cp_etcd_url() and uses it in both the cert-bundle provision path and the bundle_on_disk path, so subsequent boots always resolve the real etcd endpoint from AISIX_MANAGED__CP_BASE_URL (or AISIX_MANAGED__CP_ETCD_ENDPOINT when explicitly set).

Closes api7/AISIX-Cloud#289

Summary by CodeRabbit

• Bug Fixes

  • Fixed stale etcd endpoint handling in managed-mode bootstrap and when reusing persisted mTLS bundles.
  • Improved control-plane URL derivation during certificate provisioning and heartbeat construction—now validates base URLs, strips URL schemes, and trims trailing slashes.

• Tests

  • Added unit tests for URL derivation, explicit endpoint preference, scheme stripping, and error cases.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: ffbee559-2640-44d4-94f7-dc1b532b01ed

📥 Commits

Reviewing files that changed from the base of the PR and between aef2d91 and d685da4.

📒 Files selected for processing (1)

• crates/aisix-server/src/main.rs

🚧 Files skipped from review as they are similar to previous changes (1)

• crates/aisix-server/src/main.rs

---

📝 Walkthrough

Walkthrough

Adds derive_cp_etcd_url to normalize/produce an https:// etcd endpoint from managed config, uses it in both managed-mode bootstrap paths to set cfg.etcd.endpoints and log the derived endpoint, validates heartbeat URL construction, and adds unit tests for derivation cases and errors.

Changes

Etcd Endpoint Derivation Helper and Bootstrap Integration

Layer / File(s)	Summary
Helper function implementation crates/aisix-server/src/main.rs	Adds derive_cp_etcd_url(managed: &ManagedConfig) -> anyhow::Result<String> helper that prefers cp_etcd_endpoint, validates non-empty cp_base_url, strips http:///https:// prefixes from cp_base_url, trims trailing /, and returns an https://<host:port> endpoint string.
Dashboard cert bundle bootstrap integration crates/aisix-server/src/main.rs	In the dashboard-issued certificate provisioning path, calls derive_cp_etcd_url to compute the etcd endpoint, logs it with dp_id and env_id, assigns it to cfg.etcd.endpoints, and validates/trims cp_base_url before building the /dp/heartbeat URL.
Persisted mTLS bundle bootstrap integration crates/aisix-server/src/main.rs	In the persisted mTLS reuse path on subsequent boots, calls derive_cp_etcd_url to replace stale placeholder endpoints, logs the derived endpoint, and overwrites cfg.etcd.endpoints.
Unit tests crates/aisix-server/src/main.rs	Adds unit tests validating derive_cp_etcd_url for scheme stripping (http:// and https://), explicit cp_etcd_endpoint precedence, trailing slash trimming, http inputs, and expected failures when cp_base_url is missing or empty.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related issues

• #289: QA: DP restart with persisted mTLS bundle can reuse placeholder endpoint

🚥 Pre-merge checks | ✅ 4

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title directly describes the main fix: deriving the etcd endpoint on subsequent boot from cp_base_url, which is the core change shown in the raw summary and PR objectives.
Linked Issues check	✅ Passed	The code changes address the core issue by implementing derive_cp_etcd_url() to resolve the real etcd endpoint from cp_base_url (or cp_etcd_endpoint) on both initial provision and subsequent boots, fixing the placeholder endpoint problem documented in #289.
Out of Scope Changes check	✅ Passed	All changes focus on resolving etcd endpoint derivation for the managed-mode bootstrap path; no unrelated alterations to other functionality or modules are evident in the changeset.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[Copilot]

Pull request overview

This PR fixes managed-mode subsequent boot behavior by deriving and applying the real etcd endpoint when an mTLS bundle already exists, avoiding reuse of the placeholder endpoint from config.managed.yaml.

Changes:

• Extracts shared derive_cp_etcd_url() logic.
• Uses derived etcd URL in both cert-bundle provisioning and bundle-on-disk managed boot paths.
• Adds unit tests for deriving etcd URLs from base URL and explicit endpoint inputs.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@crates/aisix-server/src/main.rs`:
- Around line 756-775: The code currently forces cp_base (managed.cp_base_url)
to be present before checking cp_etcd, which breaks the intended precedence
where an explicit managed.cp_etcd_endpoint should be accepted; change the logic
so you first attempt to read managed.cp_etcd_endpoint (as_deref().filter(|s|
!s.is_empty())) and if that yields Some, use it for cp_etcd; only when cp_etcd
is missing should you then try to derive it from managed.cp_base_url
(strip_prefix http/https) and if cp_base is absent/error then return the anyhow
error. Update the cp_etcd and cp_base variable handling accordingly (references:
cp_etcd, cp_base, managed.cp_etcd_endpoint, managed.cp_base_url).

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 33d6b8ef-8a81-46df-9a5a-748cdb08e39c

📥 Commits

Reviewing files that changed from the base of the PR and between 068aa1f and ac060c7.

📒 Files selected for processing (1)

• crates/aisix-server/src/main.rs

[Copilot]

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 2 comments.