docs: update Admin API OpenAPI reference to align with the latest development - #603

Merged
kayx23 merged 13 commits into
mainfrom
codex/admin-api-openapi-completeness
Jun 15, 2026
Merged

docs: update Admin API OpenAPI reference to align with the latest development#603
kayx23 merged 13 commits into
mainfrom
codex/admin-api-openapi-completeness

Conversation

@kayx23

@kayx23kayx23 commented Jun 15, 2026

Copy link
Copy Markdown
Contributor

Summary

  • expand the Admin API OpenAPI document into a reference-quality spec with operation tags, endpoint descriptions, parameter descriptions/examples, request-body descriptions, response schemas, and enum metadata
  • remove the stale /metrics path from the Admin API spec because metrics are served from the dedicated metrics listener
  • document Admin API behavior for CRUD resources, health, runtime status, delete, API key rotation, malformed JSON/content-type failures, JSON body-limit failures, and playground proxy responses
  • use the self-hosted Admin API key request schema for API key create/update routes and keep public provider-key wording on the self-hosted path
  • add OpenAPI tests for exact route coverage, response schemas, auth/error envelopes, request-body schemas, reference metadata, parameter metadata, enum metadata, JSON body-limit responses, playground media/status coverage, and internal $ref resolution

Fixes#602.

Validation

  • cargo fmt --all -- --check
  • cargo test -p aisix-admin openapi -- --nocapture
  • cargo test -p aisix-admin -- --nocapture
  • cargo run -p aisix-core --bin dump-schema
  • strict JSON metadata audit for operation tags/descriptions, parameter descriptions/examples, request-body descriptions, and enum metadata
  • internal $ref resolution audit
  • git diff --check

Docs sync

The public docs sync is in api7/docs#1680. Merge this source PR first, then merge the docs PR after required docs review approval.

Independent audit

A fresh audit agent reviewed this PR and the docs sync PR. It reported three MEDIUM findings, which were fixed in follow-up commit 62207ee. Later review passes also addressed playground response coverage, Admin JSON body-limit documentation, reference metadata completeness, self-hosted wording, and public docs $ref resolution.

@coderabbitai

coderabbitaiBot commented Jun 15, 2026

Copy link
Copy Markdown

Review Change Stack

Warning

Review limit reached

@kayx23, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 8 minutes and 13 seconds. Learn how PR review limits work.

Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file).

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Free

Run ID: f876e2bb-17ba-4374-879f-7f2a27ed5149

📥 Commits

Reviewing files that changed from the base of the PR and between bac213c and 4ee16ac.

📒 Files selected for processing (3)
  • crates/aisix-admin/src/openapi.rs
  • crates/aisix-core/src/models/provider_key.rs
  • schemas/resources/provider_key.schema.json
📝 Walkthrough

Walkthrough

Expands the embedded OpenAPI document in openapi.rs to declare full responses[*].content media-type schemas for all admin and playground endpoints, tightens components.schemas entries with required fields, enums, and additionalProperties constraints, and adds four new test assertions validating path completeness, schema references, response coverage, and 401 error schema consistency.

Changes

OpenAPI Spec Expansion and Validation

Layer / File(s)Summary
Info description and utility endpoint schemas
crates/aisix-admin/src/openapi.rs
Updates info.description wording for managed-mode behavior, expands /livez query parameter schema to explicit object form, and adds content blocks with media-type schemas for /admin/openapi.json and /admin/openapi-scalar responses.
Admin v1 and playground route response schemas
crates/aisix-admin/src/openapi.rs
Replaces compact response declarations across all /admin/v1/* CRUD/status endpoints and /playground/chat/completions with detailed content blocks containing JSON schemas for success payloads (ModelEntry, PublicApiKeyEntry, DeleteResponse, etc.) and all error statuses (AdminError, 401/422).
components.schemas definitions
crates/aisix-admin/src/openapi.rs
Expands schema definitions for ModelEntry, ModelStatusView, ModelKind, RuntimeStatus, SystemTime, PublicApiKey, PublicApiKeyEntry, ApiKeyRotateResponse, DeleteResponse, HealthResponse, ApiKeyRequest, and AdminError with explicit required arrays, enum values, property shapes, additionalProperties, and descriptions.
Test coverage expansion
crates/aisix-admin/src/openapi.rs
Extends schema existence assertions for newly introduced wrapper schemas; adds tests for exact admin path-set equality, ApiKeyRequest$ref usage in POST/PUT, every response defining a media schema, response media types/schemas for /playground/chat/completions, and all /admin/v1/* 401 responses referencing AdminError.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes


Note

🎁 Summarized by CodeRabbit Free

Your organization has reached its limit of developer seats under the Pro Plan. For new users, CodeRabbit will generate a high-level summary and a walkthrough for each pull request. For a comprehensive line-by-line review, please add seats to your subscription by visiting https://app.coderabbit.ai/login.If you believe this is a mistake and have available seats, please assign one to the pull request author through the subscription management page using the link above.

Comment @coderabbitai help to get the list of available commands and usage tips.

@kayx23
kayx23 marked this pull request as ready for review June 15, 2026 01:18

@chatgpt-codex-connectorchatgpt-codex-connectorBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit:330def89c4

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment threadcrates/aisix-admin/src/openapi.rs

@chatgpt-codex-connectorchatgpt-codex-connectorBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit:52cce94ef3

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment threadcrates/aisix-admin/src/openapi.rs

@chatgpt-codex-connectorchatgpt-codex-connectorBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit:bac213c495

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment threadcrates/aisix-admin/src/openapi.rs

@chatgpt-codex-connectorchatgpt-codex-connectorBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit:c1567211eb

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment threadcrates/aisix-admin/src/openapi.rs

@chatgpt-codex-connectorchatgpt-codex-connectorBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit:7ea6271ac0

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment threadcrates/aisix-admin/src/openapi.rs
@kayx23kayx23 changed the title docs: complete admin OpenAPI response schemasdocs: polish Admin API OpenAPI referenceJun 15, 2026
@kayx23kayx23 changed the title docs: polish Admin API OpenAPI referencedocs: update Admin API OpenAPI reference to align with the latest codeJun 15, 2026
@kayx23kayx23 changed the title docs: update Admin API OpenAPI reference to align with the latest codedocs: update Admin API OpenAPI reference to align with the latest developmentJun 15, 2026
@kayx23
kayx23 merged commit 9bd1e55 into mainJun 15, 2026
10 checks passed
@kayx23
kayx23 deleted the codex/admin-api-openapi-completeness branch June 15, 2026 04:40
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Improve Admin API OpenAPI reference completeness

1 participant

@kayx23
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Skip to content

docs: update Admin API OpenAPI reference to align with the latest development - #603

Merged
kayx23 merged 13 commits into
mainfrom
codex/admin-api-openapi-completeness
Jun 15, 2026
Merged

docs: update Admin API OpenAPI reference to align with the latest development#603
kayx23 merged 13 commits into
mainfrom
codex/admin-api-openapi-completeness

Conversation

@kayx23

@kayx23kayx23 commented Jun 15, 2026

Copy link
Copy Markdown
Contributor

Summary

  • expand the Admin API OpenAPI document into a reference-quality spec with operation tags, endpoint descriptions, parameter descriptions/examples, request-body descriptions, response schemas, and enum metadata
  • remove the stale /metrics path from the Admin API spec because metrics are served from the dedicated metrics listener
  • document Admin API behavior for CRUD resources, health, runtime status, delete, API key rotation, malformed JSON/content-type failures, JSON body-limit failures, and playground proxy responses
  • use the self-hosted Admin API key request schema for API key create/update routes and keep public provider-key wording on the self-hosted path
  • add OpenAPI tests for exact route coverage, response schemas, auth/error envelopes, request-body schemas, reference metadata, parameter metadata, enum metadata, JSON body-limit responses, playground media/status coverage, and internal $ref resolution

Fixes#602.

Validation

  • cargo fmt --all -- --check
  • cargo test -p aisix-admin openapi -- --nocapture
  • cargo test -p aisix-admin -- --nocapture
  • cargo run -p aisix-core --bin dump-schema
  • strict JSON metadata audit for operation tags/descriptions, parameter descriptions/examples, request-body descriptions, and enum metadata
  • internal $ref resolution audit
  • git diff --check

Docs sync

The public docs sync is in api7/docs#1680. Merge this source PR first, then merge the docs PR after required docs review approval.

Independent audit

A fresh audit agent reviewed this PR and the docs sync PR. It reported three MEDIUM findings, which were fixed in follow-up commit 62207ee. Later review passes also addressed playground response coverage, Admin JSON body-limit documentation, reference metadata completeness, self-hosted wording, and public docs $ref resolution.

@coderabbitai

coderabbitaiBot commented Jun 15, 2026

Copy link
Copy Markdown

Review Change Stack

Warning

Review limit reached

@kayx23, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 8 minutes and 13 seconds. Learn how PR review limits work.

Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file).

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Free

Run ID: f876e2bb-17ba-4374-879f-7f2a27ed5149

📥 Commits

Reviewing files that changed from the base of the PR and between bac213c and 4ee16ac.

📒 Files selected for processing (3)
  • crates/aisix-admin/src/openapi.rs
  • crates/aisix-core/src/models/provider_key.rs
  • schemas/resources/provider_key.schema.json
📝 Walkthrough

Walkthrough

Expands the embedded OpenAPI document in openapi.rs to declare full responses[*].content media-type schemas for all admin and playground endpoints, tightens components.schemas entries with required fields, enums, and additionalProperties constraints, and adds four new test assertions validating path completeness, schema references, response coverage, and 401 error schema consistency.

Changes

OpenAPI Spec Expansion and Validation

Layer / File(s)Summary
Info description and utility endpoint schemas
crates/aisix-admin/src/openapi.rs
Updates info.description wording for managed-mode behavior, expands /livez query parameter schema to explicit object form, and adds content blocks with media-type schemas for /admin/openapi.json and /admin/openapi-scalar responses.
Admin v1 and playground route response schemas
crates/aisix-admin/src/openapi.rs
Replaces compact response declarations across all /admin/v1/* CRUD/status endpoints and /playground/chat/completions with detailed content blocks containing JSON schemas for success payloads (ModelEntry, PublicApiKeyEntry, DeleteResponse, etc.) and all error statuses (AdminError, 401/422).
components.schemas definitions
crates/aisix-admin/src/openapi.rs
Expands schema definitions for ModelEntry, ModelStatusView, ModelKind, RuntimeStatus, SystemTime, PublicApiKey, PublicApiKeyEntry, ApiKeyRotateResponse, DeleteResponse, HealthResponse, ApiKeyRequest, and AdminError with explicit required arrays, enum values, property shapes, additionalProperties, and descriptions.
Test coverage expansion
crates/aisix-admin/src/openapi.rs
Extends schema existence assertions for newly introduced wrapper schemas; adds tests for exact admin path-set equality, ApiKeyRequest$ref usage in POST/PUT, every response defining a media schema, response media types/schemas for /playground/chat/completions, and all /admin/v1/* 401 responses referencing AdminError.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes


Note

🎁 Summarized by CodeRabbit Free

Your organization has reached its limit of developer seats under the Pro Plan. For new users, CodeRabbit will generate a high-level summary and a walkthrough for each pull request. For a comprehensive line-by-line review, please add seats to your subscription by visiting https://app.coderabbit.ai/login.If you believe this is a mistake and have available seats, please assign one to the pull request author through the subscription management page using the link above.

Comment @coderabbitai help to get the list of available commands and usage tips.

@kayx23
kayx23 marked this pull request as ready for review June 15, 2026 01:18

@chatgpt-codex-connectorchatgpt-codex-connectorBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit:330def89c4

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment threadcrates/aisix-admin/src/openapi.rs

@chatgpt-codex-connectorchatgpt-codex-connectorBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit:52cce94ef3

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment threadcrates/aisix-admin/src/openapi.rs

@chatgpt-codex-connectorchatgpt-codex-connectorBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit:bac213c495

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment threadcrates/aisix-admin/src/openapi.rs

@chatgpt-codex-connectorchatgpt-codex-connectorBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit:c1567211eb

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment threadcrates/aisix-admin/src/openapi.rs

@chatgpt-codex-connectorchatgpt-codex-connectorBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit:7ea6271ac0

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment threadcrates/aisix-admin/src/openapi.rs
@kayx23kayx23 changed the title docs: complete admin OpenAPI response schemasdocs: polish Admin API OpenAPI referenceJun 15, 2026
@kayx23kayx23 changed the title docs: polish Admin API OpenAPI referencedocs: update Admin API OpenAPI reference to align with the latest codeJun 15, 2026
@kayx23kayx23 changed the title docs: update Admin API OpenAPI reference to align with the latest codedocs: update Admin API OpenAPI reference to align with the latest developmentJun 15, 2026
@kayx23
kayx23 merged commit 9bd1e55 into mainJun 15, 2026
10 checks passed
@kayx23
kayx23 deleted the codex/admin-api-openapi-completeness branch June 15, 2026 04:40
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Improve Admin API OpenAPI reference completeness

1 participant

@kayx23
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix"); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

docs: update Admin API OpenAPI reference to align with the latest development - #603

Merged
kayx23 merged 13 commits into
mainfrom
codex/admin-api-openapi-completeness
Jun 15, 2026
Merged

docs: update Admin API OpenAPI reference to align with the latest development#603
kayx23 merged 13 commits into
mainfrom
codex/admin-api-openapi-completeness

Conversation

@kayx23

@kayx23kayx23 commented Jun 15, 2026

Copy link
Copy Markdown
Contributor

Summary

  • expand the Admin API OpenAPI document into a reference-quality spec with operation tags, endpoint descriptions, parameter descriptions/examples, request-body descriptions, response schemas, and enum metadata
  • remove the stale /metrics path from the Admin API spec because metrics are served from the dedicated metrics listener
  • document Admin API behavior for CRUD resources, health, runtime status, delete, API key rotation, malformed JSON/content-type failures, JSON body-limit failures, and playground proxy responses
  • use the self-hosted Admin API key request schema for API key create/update routes and keep public provider-key wording on the self-hosted path
  • add OpenAPI tests for exact route coverage, response schemas, auth/error envelopes, request-body schemas, reference metadata, parameter metadata, enum metadata, JSON body-limit responses, playground media/status coverage, and internal $ref resolution

Fixes#602.

Validation

  • cargo fmt --all -- --check
  • cargo test -p aisix-admin openapi -- --nocapture
  • cargo test -p aisix-admin -- --nocapture
  • cargo run -p aisix-core --bin dump-schema
  • strict JSON metadata audit for operation tags/descriptions, parameter descriptions/examples, request-body descriptions, and enum metadata
  • internal $ref resolution audit
  • git diff --check

Docs sync

The public docs sync is in api7/docs#1680. Merge this source PR first, then merge the docs PR after required docs review approval.

Independent audit

A fresh audit agent reviewed this PR and the docs sync PR. It reported three MEDIUM findings, which were fixed in follow-up commit 62207ee. Later review passes also addressed playground response coverage, Admin JSON body-limit documentation, reference metadata completeness, self-hosted wording, and public docs $ref resolution.

@coderabbitai

coderabbitaiBot commented Jun 15, 2026

Copy link
Copy Markdown

Review Change Stack

Warning

Review limit reached

@kayx23, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 8 minutes and 13 seconds. Learn how PR review limits work.

Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file).

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Free

Run ID: f876e2bb-17ba-4374-879f-7f2a27ed5149

📥 Commits

Reviewing files that changed from the base of the PR and between bac213c and 4ee16ac.

📒 Files selected for processing (3)
  • crates/aisix-admin/src/openapi.rs
  • crates/aisix-core/src/models/provider_key.rs
  • schemas/resources/provider_key.schema.json
📝 Walkthrough

Walkthrough

Expands the embedded OpenAPI document in openapi.rs to declare full responses[*].content media-type schemas for all admin and playground endpoints, tightens components.schemas entries with required fields, enums, and additionalProperties constraints, and adds four new test assertions validating path completeness, schema references, response coverage, and 401 error schema consistency.

Changes

OpenAPI Spec Expansion and Validation

Layer / File(s)Summary
Info description and utility endpoint schemas
crates/aisix-admin/src/openapi.rs
Updates info.description wording for managed-mode behavior, expands /livez query parameter schema to explicit object form, and adds content blocks with media-type schemas for /admin/openapi.json and /admin/openapi-scalar responses.
Admin v1 and playground route response schemas
crates/aisix-admin/src/openapi.rs
Replaces compact response declarations across all /admin/v1/* CRUD/status endpoints and /playground/chat/completions with detailed content blocks containing JSON schemas for success payloads (ModelEntry, PublicApiKeyEntry, DeleteResponse, etc.) and all error statuses (AdminError, 401/422).
components.schemas definitions
crates/aisix-admin/src/openapi.rs
Expands schema definitions for ModelEntry, ModelStatusView, ModelKind, RuntimeStatus, SystemTime, PublicApiKey, PublicApiKeyEntry, ApiKeyRotateResponse, DeleteResponse, HealthResponse, ApiKeyRequest, and AdminError with explicit required arrays, enum values, property shapes, additionalProperties, and descriptions.
Test coverage expansion
crates/aisix-admin/src/openapi.rs
Extends schema existence assertions for newly introduced wrapper schemas; adds tests for exact admin path-set equality, ApiKeyRequest$ref usage in POST/PUT, every response defining a media schema, response media types/schemas for /playground/chat/completions, and all /admin/v1/* 401 responses referencing AdminError.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes


Note

🎁 Summarized by CodeRabbit Free

Your organization has reached its limit of developer seats under the Pro Plan. For new users, CodeRabbit will generate a high-level summary and a walkthrough for each pull request. For a comprehensive line-by-line review, please add seats to your subscription by visiting https://app.coderabbit.ai/login.If you believe this is a mistake and have available seats, please assign one to the pull request author through the subscription management page using the link above.

Comment @coderabbitai help to get the list of available commands and usage tips.

@kayx23
kayx23 marked this pull request as ready for review June 15, 2026 01:18

@chatgpt-codex-connectorchatgpt-codex-connectorBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit:330def89c4

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment threadcrates/aisix-admin/src/openapi.rs

@chatgpt-codex-connectorchatgpt-codex-connectorBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit:52cce94ef3

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment threadcrates/aisix-admin/src/openapi.rs

@chatgpt-codex-connectorchatgpt-codex-connectorBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit:bac213c495

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment threadcrates/aisix-admin/src/openapi.rs

@chatgpt-codex-connectorchatgpt-codex-connectorBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit:c1567211eb

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment threadcrates/aisix-admin/src/openapi.rs

@chatgpt-codex-connectorchatgpt-codex-connectorBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit:7ea6271ac0

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment threadcrates/aisix-admin/src/openapi.rs
@kayx23kayx23 changed the title docs: complete admin OpenAPI response schemasdocs: polish Admin API OpenAPI referenceJun 15, 2026
@kayx23kayx23 changed the title docs: polish Admin API OpenAPI referencedocs: update Admin API OpenAPI reference to align with the latest codeJun 15, 2026
@kayx23kayx23 changed the title docs: update Admin API OpenAPI reference to align with the latest codedocs: update Admin API OpenAPI reference to align with the latest developmentJun 15, 2026
@kayx23
kayx23 merged commit 9bd1e55 into mainJun 15, 2026
10 checks passed
@kayx23
kayx23 deleted the codex/admin-api-openapi-completeness branch June 15, 2026 04:40
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Improve Admin API OpenAPI reference completeness

1 participant

@kayx23
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms"); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

docs: update Admin API OpenAPI reference to align with the latest development - #603

Merged
kayx23 merged 13 commits into
mainfrom
codex/admin-api-openapi-completeness
Jun 15, 2026
Merged

docs: update Admin API OpenAPI reference to align with the latest development#603
kayx23 merged 13 commits into
mainfrom
codex/admin-api-openapi-completeness

Conversation

@kayx23

@kayx23kayx23 commented Jun 15, 2026

Copy link
Copy Markdown
Contributor

Summary

  • expand the Admin API OpenAPI document into a reference-quality spec with operation tags, endpoint descriptions, parameter descriptions/examples, request-body descriptions, response schemas, and enum metadata
  • remove the stale /metrics path from the Admin API spec because metrics are served from the dedicated metrics listener
  • document Admin API behavior for CRUD resources, health, runtime status, delete, API key rotation, malformed JSON/content-type failures, JSON body-limit failures, and playground proxy responses
  • use the self-hosted Admin API key request schema for API key create/update routes and keep public provider-key wording on the self-hosted path
  • add OpenAPI tests for exact route coverage, response schemas, auth/error envelopes, request-body schemas, reference metadata, parameter metadata, enum metadata, JSON body-limit responses, playground media/status coverage, and internal $ref resolution

Fixes#602.

Validation

  • cargo fmt --all -- --check
  • cargo test -p aisix-admin openapi -- --nocapture
  • cargo test -p aisix-admin -- --nocapture
  • cargo run -p aisix-core --bin dump-schema
  • strict JSON metadata audit for operation tags/descriptions, parameter descriptions/examples, request-body descriptions, and enum metadata
  • internal $ref resolution audit
  • git diff --check

Docs sync

The public docs sync is in api7/docs#1680. Merge this source PR first, then merge the docs PR after required docs review approval.

Independent audit

A fresh audit agent reviewed this PR and the docs sync PR. It reported three MEDIUM findings, which were fixed in follow-up commit 62207ee. Later review passes also addressed playground response coverage, Admin JSON body-limit documentation, reference metadata completeness, self-hosted wording, and public docs $ref resolution.

@coderabbitai

coderabbitaiBot commented Jun 15, 2026

Copy link
Copy Markdown

Review Change Stack

Warning

Review limit reached

@kayx23, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 8 minutes and 13 seconds. Learn how PR review limits work.

Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file).

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Free

Run ID: f876e2bb-17ba-4374-879f-7f2a27ed5149

📥 Commits

Reviewing files that changed from the base of the PR and between bac213c and 4ee16ac.

📒 Files selected for processing (3)
  • crates/aisix-admin/src/openapi.rs
  • crates/aisix-core/src/models/provider_key.rs
  • schemas/resources/provider_key.schema.json
📝 Walkthrough

Walkthrough

Expands the embedded OpenAPI document in openapi.rs to declare full responses[*].content media-type schemas for all admin and playground endpoints, tightens components.schemas entries with required fields, enums, and additionalProperties constraints, and adds four new test assertions validating path completeness, schema references, response coverage, and 401 error schema consistency.

Changes

OpenAPI Spec Expansion and Validation

Layer / File(s)Summary
Info description and utility endpoint schemas
crates/aisix-admin/src/openapi.rs
Updates info.description wording for managed-mode behavior, expands /livez query parameter schema to explicit object form, and adds content blocks with media-type schemas for /admin/openapi.json and /admin/openapi-scalar responses.
Admin v1 and playground route response schemas
crates/aisix-admin/src/openapi.rs
Replaces compact response declarations across all /admin/v1/* CRUD/status endpoints and /playground/chat/completions with detailed content blocks containing JSON schemas for success payloads (ModelEntry, PublicApiKeyEntry, DeleteResponse, etc.) and all error statuses (AdminError, 401/422).
components.schemas definitions
crates/aisix-admin/src/openapi.rs
Expands schema definitions for ModelEntry, ModelStatusView, ModelKind, RuntimeStatus, SystemTime, PublicApiKey, PublicApiKeyEntry, ApiKeyRotateResponse, DeleteResponse, HealthResponse, ApiKeyRequest, and AdminError with explicit required arrays, enum values, property shapes, additionalProperties, and descriptions.
Test coverage expansion
crates/aisix-admin/src/openapi.rs
Extends schema existence assertions for newly introduced wrapper schemas; adds tests for exact admin path-set equality, ApiKeyRequest$ref usage in POST/PUT, every response defining a media schema, response media types/schemas for /playground/chat/completions, and all /admin/v1/* 401 responses referencing AdminError.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes


Note

🎁 Summarized by CodeRabbit Free

Your organization has reached its limit of developer seats under the Pro Plan. For new users, CodeRabbit will generate a high-level summary and a walkthrough for each pull request. For a comprehensive line-by-line review, please add seats to your subscription by visiting https://app.coderabbit.ai/login.If you believe this is a mistake and have available seats, please assign one to the pull request author through the subscription management page using the link above.

Comment @coderabbitai help to get the list of available commands and usage tips.

@kayx23
kayx23 marked this pull request as ready for review June 15, 2026 01:18

@chatgpt-codex-connectorchatgpt-codex-connectorBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit:330def89c4

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment threadcrates/aisix-admin/src/openapi.rs

@chatgpt-codex-connectorchatgpt-codex-connectorBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit:52cce94ef3

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment threadcrates/aisix-admin/src/openapi.rs

@chatgpt-codex-connectorchatgpt-codex-connectorBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit:bac213c495

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment threadcrates/aisix-admin/src/openapi.rs

@chatgpt-codex-connectorchatgpt-codex-connectorBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit:c1567211eb

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment threadcrates/aisix-admin/src/openapi.rs

@chatgpt-codex-connectorchatgpt-codex-connectorBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit:7ea6271ac0

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment threadcrates/aisix-admin/src/openapi.rs
@kayx23kayx23 changed the title docs: complete admin OpenAPI response schemasdocs: polish Admin API OpenAPI referenceJun 15, 2026
@kayx23kayx23 changed the title docs: polish Admin API OpenAPI referencedocs: update Admin API OpenAPI reference to align with the latest codeJun 15, 2026
@kayx23kayx23 changed the title docs: update Admin API OpenAPI reference to align with the latest codedocs: update Admin API OpenAPI reference to align with the latest developmentJun 15, 2026
@kayx23
kayx23 merged commit 9bd1e55 into mainJun 15, 2026
10 checks passed
@kayx23
kayx23 deleted the codex/admin-api-openapi-completeness branch June 15, 2026 04:40
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Improve Admin API OpenAPI reference completeness

1 participant

@kayx23
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links"); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + '
Skip to content

docs: update Admin API OpenAPI reference to align with the latest development - #603

Merged
kayx23 merged 13 commits into
mainfrom
codex/admin-api-openapi-completeness
Jun 15, 2026
Merged

docs: update Admin API OpenAPI reference to align with the latest development#603
kayx23 merged 13 commits into
mainfrom
codex/admin-api-openapi-completeness

Conversation

@kayx23

@kayx23kayx23 commented Jun 15, 2026

Copy link
Copy Markdown
Contributor

Summary

  • expand the Admin API OpenAPI document into a reference-quality spec with operation tags, endpoint descriptions, parameter descriptions/examples, request-body descriptions, response schemas, and enum metadata
  • remove the stale /metrics path from the Admin API spec because metrics are served from the dedicated metrics listener
  • document Admin API behavior for CRUD resources, health, runtime status, delete, API key rotation, malformed JSON/content-type failures, JSON body-limit failures, and playground proxy responses
  • use the self-hosted Admin API key request schema for API key create/update routes and keep public provider-key wording on the self-hosted path
  • add OpenAPI tests for exact route coverage, response schemas, auth/error envelopes, request-body schemas, reference metadata, parameter metadata, enum metadata, JSON body-limit responses, playground media/status coverage, and internal $ref resolution

Fixes#602.

Validation

  • cargo fmt --all -- --check
  • cargo test -p aisix-admin openapi -- --nocapture
  • cargo test -p aisix-admin -- --nocapture
  • cargo run -p aisix-core --bin dump-schema
  • strict JSON metadata audit for operation tags/descriptions, parameter descriptions/examples, request-body descriptions, and enum metadata
  • internal $ref resolution audit
  • git diff --check

Docs sync

The public docs sync is in api7/docs#1680. Merge this source PR first, then merge the docs PR after required docs review approval.

Independent audit

A fresh audit agent reviewed this PR and the docs sync PR. It reported three MEDIUM findings, which were fixed in follow-up commit 62207ee. Later review passes also addressed playground response coverage, Admin JSON body-limit documentation, reference metadata completeness, self-hosted wording, and public docs $ref resolution.

@coderabbitai

coderabbitaiBot commented Jun 15, 2026

Copy link
Copy Markdown

Review Change Stack

Warning

Review limit reached

@kayx23, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 8 minutes and 13 seconds. Learn how PR review limits work.

Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file).

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Free

Run ID: f876e2bb-17ba-4374-879f-7f2a27ed5149

📥 Commits

Reviewing files that changed from the base of the PR and between bac213c and 4ee16ac.

📒 Files selected for processing (3)
  • crates/aisix-admin/src/openapi.rs
  • crates/aisix-core/src/models/provider_key.rs
  • schemas/resources/provider_key.schema.json
📝 Walkthrough

Walkthrough

Expands the embedded OpenAPI document in openapi.rs to declare full responses[*].content media-type schemas for all admin and playground endpoints, tightens components.schemas entries with required fields, enums, and additionalProperties constraints, and adds four new test assertions validating path completeness, schema references, response coverage, and 401 error schema consistency.

Changes

OpenAPI Spec Expansion and Validation

Layer / File(s)Summary
Info description and utility endpoint schemas
crates/aisix-admin/src/openapi.rs
Updates info.description wording for managed-mode behavior, expands /livez query parameter schema to explicit object form, and adds content blocks with media-type schemas for /admin/openapi.json and /admin/openapi-scalar responses.
Admin v1 and playground route response schemas
crates/aisix-admin/src/openapi.rs
Replaces compact response declarations across all /admin/v1/* CRUD/status endpoints and /playground/chat/completions with detailed content blocks containing JSON schemas for success payloads (ModelEntry, PublicApiKeyEntry, DeleteResponse, etc.) and all error statuses (AdminError, 401/422).
components.schemas definitions
crates/aisix-admin/src/openapi.rs
Expands schema definitions for ModelEntry, ModelStatusView, ModelKind, RuntimeStatus, SystemTime, PublicApiKey, PublicApiKeyEntry, ApiKeyRotateResponse, DeleteResponse, HealthResponse, ApiKeyRequest, and AdminError with explicit required arrays, enum values, property shapes, additionalProperties, and descriptions.
Test coverage expansion
crates/aisix-admin/src/openapi.rs
Extends schema existence assertions for newly introduced wrapper schemas; adds tests for exact admin path-set equality, ApiKeyRequest$ref usage in POST/PUT, every response defining a media schema, response media types/schemas for /playground/chat/completions, and all /admin/v1/* 401 responses referencing AdminError.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes


Note

🎁 Summarized by CodeRabbit Free

Your organization has reached its limit of developer seats under the Pro Plan. For new users, CodeRabbit will generate a high-level summary and a walkthrough for each pull request. For a comprehensive line-by-line review, please add seats to your subscription by visiting https://app.coderabbit.ai/login.If you believe this is a mistake and have available seats, please assign one to the pull request author through the subscription management page using the link above.

Comment @coderabbitai help to get the list of available commands and usage tips.

@kayx23
kayx23 marked this pull request as ready for review June 15, 2026 01:18

@chatgpt-codex-connectorchatgpt-codex-connectorBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit:330def89c4

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment threadcrates/aisix-admin/src/openapi.rs

@chatgpt-codex-connectorchatgpt-codex-connectorBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit:52cce94ef3

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment threadcrates/aisix-admin/src/openapi.rs

@chatgpt-codex-connectorchatgpt-codex-connectorBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit:bac213c495

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment threadcrates/aisix-admin/src/openapi.rs

@chatgpt-codex-connectorchatgpt-codex-connectorBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit:c1567211eb

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment threadcrates/aisix-admin/src/openapi.rs

@chatgpt-codex-connectorchatgpt-codex-connectorBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit:7ea6271ac0

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment threadcrates/aisix-admin/src/openapi.rs
@kayx23kayx23 changed the title docs: complete admin OpenAPI response schemasdocs: polish Admin API OpenAPI referenceJun 15, 2026
@kayx23kayx23 changed the title docs: polish Admin API OpenAPI referencedocs: update Admin API OpenAPI reference to align with the latest codeJun 15, 2026
@kayx23kayx23 changed the title docs: update Admin API OpenAPI reference to align with the latest codedocs: update Admin API OpenAPI reference to align with the latest developmentJun 15, 2026
@kayx23
kayx23 merged commit 9bd1e55 into mainJun 15, 2026
10 checks passed
@kayx23
kayx23 deleted the codex/admin-api-openapi-completeness branch June 15, 2026 04:40
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Improve Admin API OpenAPI reference completeness

1 participant

@kayx23
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default"); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

docs: update Admin API OpenAPI reference to align with the latest development - #603

Merged
kayx23 merged 13 commits into
mainfrom
codex/admin-api-openapi-completeness
Jun 15, 2026
Merged

docs: update Admin API OpenAPI reference to align with the latest development#603
kayx23 merged 13 commits into
mainfrom
codex/admin-api-openapi-completeness

Conversation

@kayx23

@kayx23kayx23 commented Jun 15, 2026

Copy link
Copy Markdown
Contributor

Summary

  • expand the Admin API OpenAPI document into a reference-quality spec with operation tags, endpoint descriptions, parameter descriptions/examples, request-body descriptions, response schemas, and enum metadata
  • remove the stale /metrics path from the Admin API spec because metrics are served from the dedicated metrics listener
  • document Admin API behavior for CRUD resources, health, runtime status, delete, API key rotation, malformed JSON/content-type failures, JSON body-limit failures, and playground proxy responses
  • use the self-hosted Admin API key request schema for API key create/update routes and keep public provider-key wording on the self-hosted path
  • add OpenAPI tests for exact route coverage, response schemas, auth/error envelopes, request-body schemas, reference metadata, parameter metadata, enum metadata, JSON body-limit responses, playground media/status coverage, and internal $ref resolution

Fixes#602.

Validation

  • cargo fmt --all -- --check
  • cargo test -p aisix-admin openapi -- --nocapture
  • cargo test -p aisix-admin -- --nocapture
  • cargo run -p aisix-core --bin dump-schema
  • strict JSON metadata audit for operation tags/descriptions, parameter descriptions/examples, request-body descriptions, and enum metadata
  • internal $ref resolution audit
  • git diff --check

Docs sync

The public docs sync is in api7/docs#1680. Merge this source PR first, then merge the docs PR after required docs review approval.

Independent audit

A fresh audit agent reviewed this PR and the docs sync PR. It reported three MEDIUM findings, which were fixed in follow-up commit 62207ee. Later review passes also addressed playground response coverage, Admin JSON body-limit documentation, reference metadata completeness, self-hosted wording, and public docs $ref resolution.

@coderabbitai

coderabbitaiBot commented Jun 15, 2026

Copy link
Copy Markdown

Review Change Stack

Warning

Review limit reached

@kayx23, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 8 minutes and 13 seconds. Learn how PR review limits work.

Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file).

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Free

Run ID: f876e2bb-17ba-4374-879f-7f2a27ed5149

📥 Commits

Reviewing files that changed from the base of the PR and between bac213c and 4ee16ac.

📒 Files selected for processing (3)
  • crates/aisix-admin/src/openapi.rs
  • crates/aisix-core/src/models/provider_key.rs
  • schemas/resources/provider_key.schema.json
📝 Walkthrough

Walkthrough

Expands the embedded OpenAPI document in openapi.rs to declare full responses[*].content media-type schemas for all admin and playground endpoints, tightens components.schemas entries with required fields, enums, and additionalProperties constraints, and adds four new test assertions validating path completeness, schema references, response coverage, and 401 error schema consistency.

Changes

OpenAPI Spec Expansion and Validation

Layer / File(s)Summary
Info description and utility endpoint schemas
crates/aisix-admin/src/openapi.rs
Updates info.description wording for managed-mode behavior, expands /livez query parameter schema to explicit object form, and adds content blocks with media-type schemas for /admin/openapi.json and /admin/openapi-scalar responses.
Admin v1 and playground route response schemas
crates/aisix-admin/src/openapi.rs
Replaces compact response declarations across all /admin/v1/* CRUD/status endpoints and /playground/chat/completions with detailed content blocks containing JSON schemas for success payloads (ModelEntry, PublicApiKeyEntry, DeleteResponse, etc.) and all error statuses (AdminError, 401/422).
components.schemas definitions
crates/aisix-admin/src/openapi.rs
Expands schema definitions for ModelEntry, ModelStatusView, ModelKind, RuntimeStatus, SystemTime, PublicApiKey, PublicApiKeyEntry, ApiKeyRotateResponse, DeleteResponse, HealthResponse, ApiKeyRequest, and AdminError with explicit required arrays, enum values, property shapes, additionalProperties, and descriptions.
Test coverage expansion
crates/aisix-admin/src/openapi.rs
Extends schema existence assertions for newly introduced wrapper schemas; adds tests for exact admin path-set equality, ApiKeyRequest$ref usage in POST/PUT, every response defining a media schema, response media types/schemas for /playground/chat/completions, and all /admin/v1/* 401 responses referencing AdminError.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes


Note

🎁 Summarized by CodeRabbit Free

Your organization has reached its limit of developer seats under the Pro Plan. For new users, CodeRabbit will generate a high-level summary and a walkthrough for each pull request. For a comprehensive line-by-line review, please add seats to your subscription by visiting https://app.coderabbit.ai/login.If you believe this is a mistake and have available seats, please assign one to the pull request author through the subscription management page using the link above.

Comment @coderabbitai help to get the list of available commands and usage tips.

@kayx23
kayx23 marked this pull request as ready for review June 15, 2026 01:18

@chatgpt-codex-connectorchatgpt-codex-connectorBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit:330def89c4

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment threadcrates/aisix-admin/src/openapi.rs

@chatgpt-codex-connectorchatgpt-codex-connectorBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit:52cce94ef3

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment threadcrates/aisix-admin/src/openapi.rs

@chatgpt-codex-connectorchatgpt-codex-connectorBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit:bac213c495

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment threadcrates/aisix-admin/src/openapi.rs

@chatgpt-codex-connectorchatgpt-codex-connectorBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit:c1567211eb

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment threadcrates/aisix-admin/src/openapi.rs

@chatgpt-codex-connectorchatgpt-codex-connectorBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit:7ea6271ac0

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment threadcrates/aisix-admin/src/openapi.rs
@kayx23kayx23 changed the title docs: complete admin OpenAPI response schemasdocs: polish Admin API OpenAPI referenceJun 15, 2026
@kayx23kayx23 changed the title docs: polish Admin API OpenAPI referencedocs: update Admin API OpenAPI reference to align with the latest codeJun 15, 2026
@kayx23kayx23 changed the title docs: update Admin API OpenAPI reference to align with the latest codedocs: update Admin API OpenAPI reference to align with the latest developmentJun 15, 2026
@kayx23
kayx23 merged commit 9bd1e55 into mainJun 15, 2026
10 checks passed
@kayx23
kayx23 deleted the codex/admin-api-openapi-completeness branch June 15, 2026 04:40
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Improve Admin API OpenAPI reference completeness

1 participant

@kayx23
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers"); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

docs: update Admin API OpenAPI reference to align with the latest development - #603

Merged
kayx23 merged 13 commits into
mainfrom
codex/admin-api-openapi-completeness
Jun 15, 2026
Merged

docs: update Admin API OpenAPI reference to align with the latest development#603
kayx23 merged 13 commits into
mainfrom
codex/admin-api-openapi-completeness

Conversation

@kayx23

@kayx23kayx23 commented Jun 15, 2026

Copy link
Copy Markdown
Contributor

Summary

  • expand the Admin API OpenAPI document into a reference-quality spec with operation tags, endpoint descriptions, parameter descriptions/examples, request-body descriptions, response schemas, and enum metadata
  • remove the stale /metrics path from the Admin API spec because metrics are served from the dedicated metrics listener
  • document Admin API behavior for CRUD resources, health, runtime status, delete, API key rotation, malformed JSON/content-type failures, JSON body-limit failures, and playground proxy responses
  • use the self-hosted Admin API key request schema for API key create/update routes and keep public provider-key wording on the self-hosted path
  • add OpenAPI tests for exact route coverage, response schemas, auth/error envelopes, request-body schemas, reference metadata, parameter metadata, enum metadata, JSON body-limit responses, playground media/status coverage, and internal $ref resolution

Fixes#602.

Validation

  • cargo fmt --all -- --check
  • cargo test -p aisix-admin openapi -- --nocapture
  • cargo test -p aisix-admin -- --nocapture
  • cargo run -p aisix-core --bin dump-schema
  • strict JSON metadata audit for operation tags/descriptions, parameter descriptions/examples, request-body descriptions, and enum metadata
  • internal $ref resolution audit
  • git diff --check

Docs sync

The public docs sync is in api7/docs#1680. Merge this source PR first, then merge the docs PR after required docs review approval.

Independent audit

A fresh audit agent reviewed this PR and the docs sync PR. It reported three MEDIUM findings, which were fixed in follow-up commit 62207ee. Later review passes also addressed playground response coverage, Admin JSON body-limit documentation, reference metadata completeness, self-hosted wording, and public docs $ref resolution.

@coderabbitai

coderabbitaiBot commented Jun 15, 2026

Copy link
Copy Markdown

Review Change Stack

Warning

Review limit reached

@kayx23, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 8 minutes and 13 seconds. Learn how PR review limits work.

Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file).

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Free

Run ID: f876e2bb-17ba-4374-879f-7f2a27ed5149

📥 Commits

Reviewing files that changed from the base of the PR and between bac213c and 4ee16ac.

📒 Files selected for processing (3)
  • crates/aisix-admin/src/openapi.rs
  • crates/aisix-core/src/models/provider_key.rs
  • schemas/resources/provider_key.schema.json
📝 Walkthrough

Walkthrough

Expands the embedded OpenAPI document in openapi.rs to declare full responses[*].content media-type schemas for all admin and playground endpoints, tightens components.schemas entries with required fields, enums, and additionalProperties constraints, and adds four new test assertions validating path completeness, schema references, response coverage, and 401 error schema consistency.

Changes

OpenAPI Spec Expansion and Validation

Layer / File(s)Summary
Info description and utility endpoint schemas
crates/aisix-admin/src/openapi.rs
Updates info.description wording for managed-mode behavior, expands /livez query parameter schema to explicit object form, and adds content blocks with media-type schemas for /admin/openapi.json and /admin/openapi-scalar responses.
Admin v1 and playground route response schemas
crates/aisix-admin/src/openapi.rs
Replaces compact response declarations across all /admin/v1/* CRUD/status endpoints and /playground/chat/completions with detailed content blocks containing JSON schemas for success payloads (ModelEntry, PublicApiKeyEntry, DeleteResponse, etc.) and all error statuses (AdminError, 401/422).
components.schemas definitions
crates/aisix-admin/src/openapi.rs
Expands schema definitions for ModelEntry, ModelStatusView, ModelKind, RuntimeStatus, SystemTime, PublicApiKey, PublicApiKeyEntry, ApiKeyRotateResponse, DeleteResponse, HealthResponse, ApiKeyRequest, and AdminError with explicit required arrays, enum values, property shapes, additionalProperties, and descriptions.
Test coverage expansion
crates/aisix-admin/src/openapi.rs
Extends schema existence assertions for newly introduced wrapper schemas; adds tests for exact admin path-set equality, ApiKeyRequest$ref usage in POST/PUT, every response defining a media schema, response media types/schemas for /playground/chat/completions, and all /admin/v1/* 401 responses referencing AdminError.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes


Note

🎁 Summarized by CodeRabbit Free

Your organization has reached its limit of developer seats under the Pro Plan. For new users, CodeRabbit will generate a high-level summary and a walkthrough for each pull request. For a comprehensive line-by-line review, please add seats to your subscription by visiting https://app.coderabbit.ai/login.If you believe this is a mistake and have available seats, please assign one to the pull request author through the subscription management page using the link above.

Comment @coderabbitai help to get the list of available commands and usage tips.

@kayx23
kayx23 marked this pull request as ready for review June 15, 2026 01:18

@chatgpt-codex-connectorchatgpt-codex-connectorBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit:330def89c4

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment threadcrates/aisix-admin/src/openapi.rs

@chatgpt-codex-connectorchatgpt-codex-connectorBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit:52cce94ef3

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment threadcrates/aisix-admin/src/openapi.rs

@chatgpt-codex-connectorchatgpt-codex-connectorBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit:bac213c495

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment threadcrates/aisix-admin/src/openapi.rs

@chatgpt-codex-connectorchatgpt-codex-connectorBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit:c1567211eb

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment threadcrates/aisix-admin/src/openapi.rs

@chatgpt-codex-connectorchatgpt-codex-connectorBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit:7ea6271ac0

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment threadcrates/aisix-admin/src/openapi.rs
@kayx23kayx23 changed the title docs: complete admin OpenAPI response schemasdocs: polish Admin API OpenAPI referenceJun 15, 2026
@kayx23kayx23 changed the title docs: polish Admin API OpenAPI referencedocs: update Admin API OpenAPI reference to align with the latest codeJun 15, 2026
@kayx23kayx23 changed the title docs: update Admin API OpenAPI reference to align with the latest codedocs: update Admin API OpenAPI reference to align with the latest developmentJun 15, 2026
@kayx23
kayx23 merged commit 9bd1e55 into mainJun 15, 2026
10 checks passed
@kayx23
kayx23 deleted the codex/admin-api-openapi-completeness branch June 15, 2026 04:40
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Improve Admin API OpenAPI reference completeness

1 participant

@kayx23
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode"); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })();
Skip to content

docs: update Admin API OpenAPI reference to align with the latest development - #603

Merged
kayx23 merged 13 commits into
mainfrom
codex/admin-api-openapi-completeness
Jun 15, 2026
Merged

docs: update Admin API OpenAPI reference to align with the latest development#603
kayx23 merged 13 commits into
mainfrom
codex/admin-api-openapi-completeness

Conversation

@kayx23

@kayx23kayx23 commented Jun 15, 2026

Copy link
Copy Markdown
Contributor

Summary

  • expand the Admin API OpenAPI document into a reference-quality spec with operation tags, endpoint descriptions, parameter descriptions/examples, request-body descriptions, response schemas, and enum metadata
  • remove the stale /metrics path from the Admin API spec because metrics are served from the dedicated metrics listener
  • document Admin API behavior for CRUD resources, health, runtime status, delete, API key rotation, malformed JSON/content-type failures, JSON body-limit failures, and playground proxy responses
  • use the self-hosted Admin API key request schema for API key create/update routes and keep public provider-key wording on the self-hosted path
  • add OpenAPI tests for exact route coverage, response schemas, auth/error envelopes, request-body schemas, reference metadata, parameter metadata, enum metadata, JSON body-limit responses, playground media/status coverage, and internal $ref resolution

Fixes#602.

Validation

  • cargo fmt --all -- --check
  • cargo test -p aisix-admin openapi -- --nocapture
  • cargo test -p aisix-admin -- --nocapture
  • cargo run -p aisix-core --bin dump-schema
  • strict JSON metadata audit for operation tags/descriptions, parameter descriptions/examples, request-body descriptions, and enum metadata
  • internal $ref resolution audit
  • git diff --check

Docs sync

The public docs sync is in api7/docs#1680. Merge this source PR first, then merge the docs PR after required docs review approval.

Independent audit

A fresh audit agent reviewed this PR and the docs sync PR. It reported three MEDIUM findings, which were fixed in follow-up commit 62207ee. Later review passes also addressed playground response coverage, Admin JSON body-limit documentation, reference metadata completeness, self-hosted wording, and public docs $ref resolution.

@coderabbitai

coderabbitaiBot commented Jun 15, 2026

Copy link
Copy Markdown

Review Change Stack

Warning

Review limit reached

@kayx23, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 8 minutes and 13 seconds. Learn how PR review limits work.

Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file).

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Free

Run ID: f876e2bb-17ba-4374-879f-7f2a27ed5149

📥 Commits

Reviewing files that changed from the base of the PR and between bac213c and 4ee16ac.

📒 Files selected for processing (3)
  • crates/aisix-admin/src/openapi.rs
  • crates/aisix-core/src/models/provider_key.rs
  • schemas/resources/provider_key.schema.json
📝 Walkthrough

Walkthrough

Expands the embedded OpenAPI document in openapi.rs to declare full responses[*].content media-type schemas for all admin and playground endpoints, tightens components.schemas entries with required fields, enums, and additionalProperties constraints, and adds four new test assertions validating path completeness, schema references, response coverage, and 401 error schema consistency.

Changes

OpenAPI Spec Expansion and Validation

Layer / File(s)Summary
Info description and utility endpoint schemas
crates/aisix-admin/src/openapi.rs
Updates info.description wording for managed-mode behavior, expands /livez query parameter schema to explicit object form, and adds content blocks with media-type schemas for /admin/openapi.json and /admin/openapi-scalar responses.
Admin v1 and playground route response schemas
crates/aisix-admin/src/openapi.rs
Replaces compact response declarations across all /admin/v1/* CRUD/status endpoints and /playground/chat/completions with detailed content blocks containing JSON schemas for success payloads (ModelEntry, PublicApiKeyEntry, DeleteResponse, etc.) and all error statuses (AdminError, 401/422).
components.schemas definitions
crates/aisix-admin/src/openapi.rs
Expands schema definitions for ModelEntry, ModelStatusView, ModelKind, RuntimeStatus, SystemTime, PublicApiKey, PublicApiKeyEntry, ApiKeyRotateResponse, DeleteResponse, HealthResponse, ApiKeyRequest, and AdminError with explicit required arrays, enum values, property shapes, additionalProperties, and descriptions.
Test coverage expansion
crates/aisix-admin/src/openapi.rs
Extends schema existence assertions for newly introduced wrapper schemas; adds tests for exact admin path-set equality, ApiKeyRequest$ref usage in POST/PUT, every response defining a media schema, response media types/schemas for /playground/chat/completions, and all /admin/v1/* 401 responses referencing AdminError.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes


Note

🎁 Summarized by CodeRabbit Free

Your organization has reached its limit of developer seats under the Pro Plan. For new users, CodeRabbit will generate a high-level summary and a walkthrough for each pull request. For a comprehensive line-by-line review, please add seats to your subscription by visiting https://app.coderabbit.ai/login.If you believe this is a mistake and have available seats, please assign one to the pull request author through the subscription management page using the link above.

Comment @coderabbitai help to get the list of available commands and usage tips.

@kayx23
kayx23 marked this pull request as ready for review June 15, 2026 01:18

@chatgpt-codex-connectorchatgpt-codex-connectorBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit:330def89c4

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment threadcrates/aisix-admin/src/openapi.rs

@chatgpt-codex-connectorchatgpt-codex-connectorBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit:52cce94ef3

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment threadcrates/aisix-admin/src/openapi.rs

@chatgpt-codex-connectorchatgpt-codex-connectorBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit:bac213c495

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment threadcrates/aisix-admin/src/openapi.rs

@chatgpt-codex-connectorchatgpt-codex-connectorBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit:c1567211eb

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment threadcrates/aisix-admin/src/openapi.rs

@chatgpt-codex-connectorchatgpt-codex-connectorBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit:7ea6271ac0

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment threadcrates/aisix-admin/src/openapi.rs
@kayx23kayx23 changed the title docs: complete admin OpenAPI response schemasdocs: polish Admin API OpenAPI referenceJun 15, 2026
@kayx23kayx23 changed the title docs: polish Admin API OpenAPI referencedocs: update Admin API OpenAPI reference to align with the latest codeJun 15, 2026
@kayx23kayx23 changed the title docs: update Admin API OpenAPI reference to align with the latest codedocs: update Admin API OpenAPI reference to align with the latest developmentJun 15, 2026
@kayx23
kayx23 merged commit 9bd1e55 into mainJun 15, 2026
10 checks passed
@kayx23
kayx23 deleted the codex/admin-api-openapi-completeness branch June 15, 2026 04:40
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Improve Admin API OpenAPI reference completeness

1 participant

@kayx23