Uh oh!
There was an error while loading. Please reload this page.
fix(openai): apply per-PK request overrides on embed/complete/image (not chat only) - #648
Merged
Merged
Conversation
…not chat only The OpenAI bridge applied operator request overrides (param_renames / param_constraints / default_body_fields / default_headers) only in chat() / chat_stream() via prepare_outbound_body + build_request_headers. embed(), complete() and generate_image() built their bodies/headers by hand and silently dropped every override, so a PK's configured default_headers / default_body_fields never reached /v1/embeddings, /v1/completions or /v1/images/generations. Route those three through the same prepare_outbound_body + build_request_headers that chat() uses. Overrides are per-PK (not per-endpoint) by design, matching chat; the helpers are no-ops when the PK carries none, so behavior is unchanged for the common case. Per-method tests assert a configured default_body_fields + default_headers reach the outbound request; each fails before the fix (overrides dropped → upstream mock unmatched → Err) and passes after. Note: the raw-HTTP proxy handlers that bypass the bridge (the /v1/responses verbatim-OpenAI path, /v1/rerank, /v1/audio/*) apply overrides via a separate mechanism and are a tracked follow-up.
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe OpenAI bridge now applies provider-key request overrides to ChangesOpenAI request override parity
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes 🚥 Pre-merge checks | ✅ 5 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
A ProviderKey can carry request overrides —
param_renames,param_constraints,default_body_fields,default_headers— that the operator expects applied to every outbound request that key serves. The OpenAI bridge applied them only inchat()/chat_stream()(viaprepare_outbound_body+build_request_headers). The other bridge methods —embed(),complete(),generate_image()— built their bodies and headers by hand and silently dropped every override.So an operator who configured, say, a
default_headersentry or adefault_body_fieldsdefault on a provider key found it applied to/v1/chat/completionsbut not to/v1/embeddings,/v1/completions, or/v1/images/generations. Same chat-only oversight as AISIX-Cloud#867 (provider attribution), in a different subsystem.Fix
Route
embed()/complete()/generate_image()through the sameprepare_outbound_body+build_request_headershelperschat()already uses. Overrides are per-PK (not per-endpoint) by design — consistent with chat — and the helpers are no-ops when the PK carries none, so behavior is unchanged for the common (no-override) case.build_request_headerskeeps its reserved-header protection (an override can't clobberauthorization).Tests
Per-method tests configure a
default_body_fields+default_headersoverride and assert both reach the outbound upstream request (wiremock body + header matchers). Each fails before the fix (overrides dropped → mock unmatched →Err) and passes after. Fullaisix-provider-openaisuite green (108), clippy + fmt clean.Follow-up
The raw-HTTP proxy handlers that bypass the bridge and build requests directly — the
/v1/responsesverbatim-OpenAI path,/v1/rerank, and/v1/audio/*— apply overrides through a separate (proxy-side) mechanism and are a tracked follow-up, not covered here.Origin: surfaced by a cross-API consistency audit after AISIX-Cloud#867.
Summary by CodeRabbit