ADFA-3074: Clone error handling

app/src/main/java/com/itsaky/androidide/fragments/CloneRepositoryFragment.kt

@@ -11,6 +11,7 @@ import androidx.fragment.app.viewModels
 import androidx.lifecycle.Lifecycle
 import androidx.lifecycle.lifecycleScope
 import androidx.lifecycle.repeatOnLifecycle
+import com.google.android.material.button.MaterialButton
 import com.google.android.material.textfield.TextInputLayout
 import com.itsaky.androidide.activities.MainActivity
 import com.itsaky.androidide.databinding.FragmentCloneRepositoryBinding
@@ -82,12 +83,11 @@ class CloneRepositoryFragment : BaseFragment() {
  }
 
  cloneButton.setOnClickListener {
- val url = repoUrl.text.toString()
- val path = localPath.text.toString()
- val username = if (authCheckbox.isChecked) username.text.toString() else null
- val password = if (authCheckbox.isChecked) password.text.toString() else null
-
- viewModel.cloneRepository(url, path, username, password)
+ cloneRepo()
+ }
+
+ cancelButton.setOnClickListener {
+ viewModel.cancelClone()
  }
 
  exitButton.setOnClickListener {
@@ -110,6 +110,15 @@ class CloneRepositoryFragment : BaseFragment() {
  }
  }
 
+ private fun FragmentCloneRepositoryBinding.cloneRepo() {
+ val url = repoUrl.text.toString()
+ val path = localPath.text.toString()
+ val mUsername = if (authCheckbox.isChecked) username.text.toString() else null
+ val mPassword = if (authCheckbox.isChecked) password.text.toString() else null
+
+ viewModel.cloneRepository(url, path, mUsername, mPassword)
+ }
+
  private fun observeViewModel() {
  viewLifecycleOwner.lifecycleScope.launch {
  viewLifecycleOwner.repeatOnLifecycle(Lifecycle.State.STARTED) {
@@ -137,24 +146,40 @@ class CloneRepositoryFragment : BaseFragment() {
  }
  }
 
+ cancelButton.visibility =
+ if (state is CloneRepoUiState.Cloning && state.isCancellable) View.VISIBLE else View.GONE
+
  when (state) {
  is CloneRepoUiState.Idle -> {
- cloneButton.isEnabled = state.isCloneButtonEnabled
+ cloneButton.apply {
+ isEnabled = state.isCloneButtonEnabled
+ refreshStatus(isForRetry = false)
+ }
  statusText.text = ""
  }
+
  is CloneRepoUiState.Cloning -> {
- cloneButton.isEnabled = false
- statusText.text = getString(R.string.cloning_repo)
+ cloneButton.apply {
+ isEnabled = false
+ refreshStatus(isForRetry = false)
+ }
+ statusText.text = state.statusTextResId?.let { getString(it) }
+ ?: getString(R.string.cloning_repo)
  }
+
  is CloneRepoUiState.Error -> {
- cloneButton.isEnabled = true
- val statusMessage = state.errorResId?.let { getString(it) } ?: state.errorMessage
+ cloneButton.apply {
+ isEnabled = true
+ refreshStatus(isForRetry = state.canRetry)
+ }
+ val statusMessage =
+ state.errorResId?.let { getString(it) } ?: state.errorMessage
  statusText.text = statusMessage
  }
+
  is CloneRepoUiState.Success -> {
  cloneButton.isEnabled = true
  statusText.text = getString(R.string.clone_successful)
-
  val destDir = File(state.localPath)
  if (destDir.exists()) {
  mainViewModel.setScreen(MainViewModel.SCREEN_MAIN)
@@ -176,6 +201,14 @@ class CloneRepositoryFragment : BaseFragment() {
  }
  }
 
+ private fun MaterialButton.refreshStatus(isForRetry: Boolean) {
+ setIconResource(if (isForRetry) R.drawable.ic_refresh else 0)
+
+ text = context.getString(
+ if (isForRetry) R.string.retry else R.string.download_project
+ )
+ }
+
  override fun onDestroyView() {
  super.onDestroyView()
  binding = null

app/src/main/java/com/itsaky/androidide/viewmodel/CloneRepositoryViewModel.kt

@@ -4,7 +4,6 @@ import android.app.Application
 import androidx.lifecycle.AndroidViewModel
 import androidx.lifecycle.application
 import androidx.lifecycle.viewModelScope
-import com.itsaky.androidide.R
 import com.itsaky.androidide.git.core.GitRepositoryManager
 import com.itsaky.androidide.git.core.models.CloneRepoUiState
 import kotlinx.coroutines.Dispatchers
@@ -16,13 +15,21 @@ import kotlinx.coroutines.launch
 import kotlinx.coroutines.withContext
 import org.eclipse.jgit.lib.ProgressMonitor
 import org.eclipse.jgit.transport.UsernamePasswordCredentialsProvider
+import org.eclipse.jgit.api.errors.TransportException
+import java.net.UnknownHostException
+import java.io.EOFException
 import java.io.File
+import com.blankj.utilcode.util.NetworkUtils
+import com.itsaky.androidide.resources.R
 
 class CloneRepositoryViewModel(application: Application) : AndroidViewModel(application) {
 
  private val _uiState = MutableStateFlow<CloneRepoUiState>(CloneRepoUiState.Idle())
  val uiState: StateFlow<CloneRepoUiState> = _uiState.asStateFlow()
 
+ @Volatile
+ private var isCloneCancelled = false
+
  fun onInputChanged(url: String, path: String) {
  val currentState = _uiState.value
  if (currentState is CloneRepoUiState.Idle) {
@@ -54,6 +61,7 @@ class CloneRepositoryViewModel(application: Application) : AndroidViewModel(appl
  username: String? = null,
  token: String? = null
  ) {
+ isCloneCancelled = false
  val destDir = File(localPath)
  val isExistingDir = destDir.exists()
  if (isExistingDir && destDir.listFiles()?.isNotEmpty() == true) {
@@ -67,12 +75,25 @@ class CloneRepositoryViewModel(application: Application) : AndroidViewModel(appl
  return
  }
 
+ if (!NetworkUtils.isConnected()) {
+ _uiState.update {
+ CloneRepoUiState.Error(
+ url = url,
+ localPath = localPath,
+ errorResId = R.string.no_internet_connection,
+ canRetry = true
+ )
+ }
+ return
+ }
+
  viewModelScope.launch {
  var hasCloned = false
  _uiState.update {
  CloneRepoUiState.Cloning(
  url = url,
- localPath = localPath
+ localPath = localPath,
+ statusTextResId = R.string.initialising_clone
  )
  }
  try {
@@ -103,7 +124,9 @@ class CloneRepositoryViewModel(application: Application) : AndroidViewModel(appl
 
  override fun endTask() {}
 
- override fun isCancelled(): Boolean = false
+ override fun isCancelled(): Boolean {
+ return isCloneCancelled
+ }
 
  override fun showDuration(enabled: Boolean) {}
 
@@ -120,13 +143,16 @@ class CloneRepositoryViewModel(application: Application) : AndroidViewModel(appl
  currentTaskTitle
  }
 
- val currentState = _uiState.value
- if (currentState is CloneRepoUiState.Cloning) {
- _uiState.update {
+ _uiState.update { currentState ->
+ if (currentState is CloneRepoUiState.Cloning) {
  currentState.copy(
  cloneProgress = progressMsg,
  clonePercentage = percentage,
+ isCancellable = true,
+ statusTextResId = if (isCloneCancelled) R.string.cancelling_clone else R.string.cloning_repo
  )
+ } else {
+ currentState
  }
  }
  }
@@ -143,12 +169,40 @@ class CloneRepositoryViewModel(application: Application) : AndroidViewModel(appl
  CloneRepoUiState.Success(localPath = localPath)
  }
  } catch (e: Exception) {
- val errorMessage = e.message ?: application.getString(R.string.unknown_error)
+ // Error handling
+ if (isCloneCancelled) {
+ _uiState.update {
+ CloneRepoUiState.Idle(
+ url = url,
+ localPath = localPath,
+ isCloneButtonEnabled = true
+ )
+ }
+ return@launch
+ }
+
+ val isNetworkError = e is TransportException && e.cause is UnknownHostException
+ val isConnectionDrop = e.cause is EOFException || 
+ e.message?.contains("Unexpected end of stream") == true ||
+ e.message?.contains("Software caused connection abort") == true
+
+ val errorResId = when {
+ isNetworkError -> R.string.no_internet_connection
+ isConnectionDrop -> R.string.connection_lost
+ else -> null
+ }
+
+ val errorMessage = if (errorResId == null) {
+ e.message ?: application.getString(R.string.unknown_error)
+ } else null
+
  _uiState.update {
  CloneRepoUiState.Error(
  url = url,
  localPath = localPath,
- errorMessage = application.getString(R.string.clone_failed, errorMessage)
+ errorResId = errorResId,
+ errorMessage = errorMessage?.let { application.getString(R.string.clone_failed, it) },
+ canRetry = true
  )
  }
  } finally {
@@ -177,4 +231,16 @@ class CloneRepositoryViewModel(application: Application) : AndroidViewModel(appl
  }
  }
 
+ fun cancelClone() {
+ isCloneCancelled = true
+
+ _uiState.update { currentState ->
+ if (currentState is CloneRepoUiState.Cloning) {
+ currentState.copy(statusTextResId = R.string.cancelling_clone)
+ } else {
+ currentState
+ }
+ }
+ }
+
 }