Skip to content

ADFA-3826 Whitelist some StrictMode errors for Mediatek, Xiaomi and MIUI devices#1259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hal-eisen-adfa merged 4 commits into from
Apr 28, 2026
Merged

ADFA-3826 Whitelist some StrictMode errors for Mediatek, Xiaomi and MIUI devices #1259

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
eb63891
Whitelist some StrictMode errors for Mediatek, Xiaomi and MIUI devices
hal-eisen-adfa Apr 28, 2026
71d9b8d
Tighten up the whitelist rules to reduce maintenance risk
hal-eisen-adfa Apr 28, 2026
d6231d4
Merge branch 'stage' into ADFA-3826-StrictMode-violations-pre-permiss…
hal-eisen-adfa Apr 28, 2026
1eb825a
Refine whitelist rules to be more narrowly targeted
hal-eisen-adfa Apr 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
110 changes: 110 additions & 0 deletions app/src/androidTest/kotlin/com/itsaky/androidide/app/strictmode/WhitelistRulesTest.kt
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
package com.itsaky.androidide.app.strictmode

import android.os.strictmode.DiskReadViolation
import android.os.strictmode.DiskWriteViolation
import androidx.test.ext.junit.runners.AndroidJUnit4
import org.junit.Test
import org.junit.runner.RunWith
Expand DownExpand Up@@ -98,4 +99,113 @@ class WhitelistRulesTest {
),
)
}

@Test
fun allow_DiskRead_on_MtkBoostFwkIsGameApp() {
assertAllowed<DiskReadViolation>(
// @formatter:off
stackTraceElement("java.io.File", "exists"),
stackTraceElement("com.mediatek.boostfwk.utils.Util", "isGameApp"),
stackTraceElement("com.mediatek.boostfwk.utils.TasksUtil", "isGameAPP"),
stackTraceElement("com.mediatek.boostfwk.identify.scroll.ScrollIdentify", "checkAppType"),
stackTraceElement("com.mediatek.boostfwk.identify.scroll.ScrollIdentify", "dispatchScenario"),
// @formatter:on
)
}

@Test
fun allow_DiskRead_on_MtkAsyncDrawableCachePutCacheList() {
assertAllowed<DiskReadViolation>(
// @formatter:off
stackTraceElement("java.io.File", "exists"),
stackTraceElement("android.app.SharedPreferencesImpl", "writeToFile"),
stackTraceElement("android.app.SharedPreferencesImpl\$EditorImpl", "commit"),
stackTraceElement("com.mediatek.res.AsyncDrawableCache", "storeDrawableId"),
stackTraceElement("com.mediatek.res.AsyncDrawableCache", "putCacheList"),
stackTraceElement("com.mediatek.res.ResOptExtImpl", "putCacheList"),
stackTraceElement("android.content.res.ResourcesImpl", "cacheDrawable"),
// @formatter:on
)
}

@Test
fun allow_DiskRead_on_MtkAsyncDrawableCachePutCacheList_OsStatVariant() {
assertAllowed<DiskReadViolation>(
// @formatter:off
stackTraceElement("android.system.Os", "stat"),
stackTraceElement("android.app.SharedPreferencesImpl", "writeToFile"),
stackTraceElement("android.app.SharedPreferencesImpl\$EditorImpl", "commit"),
stackTraceElement("com.mediatek.res.AsyncDrawableCache", "storeDrawableId"),
stackTraceElement("com.mediatek.res.AsyncDrawableCache", "putCacheList"),
stackTraceElement("com.mediatek.res.ResOptExtImpl", "putCacheList"),
stackTraceElement("android.content.res.ResourcesImpl", "cacheDrawable"),
// @formatter:on
)
}

@Test
fun allow_DiskWrite_on_MtkAsyncDrawableCachePutCacheList() {
assertAllowed<DiskWriteViolation>(
// @formatter:off
stackTraceElement("libcore.io.IoBridge", "open"),
stackTraceElement("java.io.FileOutputStream", "<init>"),
stackTraceElement("android.app.SharedPreferencesImpl", "createFileOutputStream"),
stackTraceElement("android.app.SharedPreferencesImpl", "writeToFile"),
stackTraceElement("android.app.SharedPreferencesImpl\$EditorImpl", "commit"),
stackTraceElement("com.mediatek.res.AsyncDrawableCache", "storeDrawableId"),
stackTraceElement("com.mediatek.res.AsyncDrawableCache", "putCacheList"),
stackTraceElement("com.mediatek.res.ResOptExtImpl", "putCacheList"),
// @formatter:on
)
}

@Test
fun allow_DiskWrite_on_MtkAsyncDrawableCache_FileOutputStreamWrite() {
assertAllowed<DiskWriteViolation>(
// @formatter:off
stackTraceElement("java.io.FileOutputStream", "write"),
stackTraceElement("com.android.internal.util.FastXmlSerializer", "flushBytes"),
stackTraceElement("com.android.internal.util.FastXmlSerializer", "flush"),
stackTraceElement("com.android.internal.util.FastXmlSerializer", "endDocument"),
stackTraceElement("com.android.internal.util.XmlSerializerWrapper", "endDocument"),
stackTraceElement("com.android.internal.util.XmlUtils", "writeMapXml"),
stackTraceElement("android.app.SharedPreferencesImpl", "writeToFile"),
stackTraceElement("android.app.SharedPreferencesImpl\$EditorImpl", "commit"),
stackTraceElement("com.mediatek.res.AsyncDrawableCache", "storeDrawableId"),
stackTraceElement("com.mediatek.res.AsyncDrawableCache", "putCacheList"),
stackTraceElement("com.mediatek.res.ResOptExtImpl", "putCacheList"),
// @formatter:on
)
}

@Test
fun allow_DiskWrite_on_MtkAsyncDrawableCache_FileDelete() {
assertAllowed<DiskWriteViolation>(
// @formatter:off
stackTraceElement("java.io.UnixFileSystem", "delete"),
stackTraceElement("java.io.File", "delete"),
stackTraceElement("android.app.SharedPreferencesImpl", "writeToFile"),
stackTraceElement("android.app.SharedPreferencesImpl\$EditorImpl", "commit"),
stackTraceElement("com.mediatek.res.AsyncDrawableCache", "storeDrawableId"),
stackTraceElement("com.mediatek.res.AsyncDrawableCache", "putCacheList"),
stackTraceElement("com.mediatek.res.ResOptExtImpl", "putCacheList"),
// @formatter:on
)
}

@Test
fun allow_DiskWrite_on_MtkAsyncDrawableCache_OsChmod() {
assertAllowed<DiskWriteViolation>(
// @formatter:off
stackTraceElement("android.system.Os", "chmod"),
stackTraceElement("android.os.FileUtils", "setPermissions"),
stackTraceElement("android.app.ContextImpl", "setFilePermissionsFromMode"),
stackTraceElement("android.app.SharedPreferencesImpl", "writeToFile"),
stackTraceElement("android.app.SharedPreferencesImpl\$EditorImpl", "commit"),
stackTraceElement("com.mediatek.res.AsyncDrawableCache", "storeDrawableId"),
stackTraceElement("com.mediatek.res.AsyncDrawableCache", "putCacheList"),
stackTraceElement("com.mediatek.res.ResOptExtImpl", "putCacheList"),
// @formatter:on
)
}
}
89 changes: 89 additions & 0 deletions app/src/main/java/com/itsaky/androidide/app/strictmode/WhitelistEngine.kt
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,9 @@
package com.itsaky.androidide.app.strictmode

import android.os.strictmode.DiskReadViolation
import android.os.strictmode.DiskWriteViolation
import androidx.annotation.VisibleForTesting
import com.itsaky.androidide.app.strictmode.FrameMatcher.Companion.anyOf
import com.itsaky.androidide.app.strictmode.FrameMatcher.Companion.classAndMethod
import android.os.strictmode.Violation as StrictModeViolation

Expand DownExpand Up@@ -220,6 +222,93 @@ object WhitelistEngine {
classAndMethod("com.itsaky.androidide.activities.OnboardingActivity", "checkToolsIsInstalled"),
)
}

rule {
ofType<DiskReadViolation>()
allow(
"""
On MediaTek devices, BoostFwk's 'Util.isGameApp' is invoked from ScrollIdentify
(via OverScroller's BoostFwkManagerImpl.perfHint) when a RecyclerView/ViewPager2
is initialized. It checks for a file's existence, resulting in a DiskReadViolation.
Since we can't control when BoostFwk performs scenario detection, we allow this
violation.
""".trimIndent(),
)

matchAdjacentFrames(
classAndMethod("java.io.File", "exists"),
classAndMethod("com.mediatek.boostfwk.utils.Util", "isGameApp"),
classAndMethod("com.mediatek.boostfwk.utils.TasksUtil", "isGameAPP"),
classAndMethod("com.mediatek.boostfwk.identify.scroll.ScrollIdentify", "checkAppType"),
)
}

rule {
ofType<DiskReadViolation>()
allow(
"""
On MediaTek devices, AsyncDrawableCache hooks into Resources.loadDrawable and
synchronously commits to a SharedPreferences-backed cache. This is triggered by
routine layout inflation and produces a DiskReadViolation. We anchor this rule
with a java.io disk-access frame at the top and the SharedPreferencesImpl
commit frame immediately adjacent to the vendor chain, so it only fires on the
actual prefs-write path inside this vendor caching code.
""".trimIndent(),
)

matchAdjacentFramesInOrder(
listOf(
listOf(
anyOf(
classAndMethod("java.io.File", "exists"),
classAndMethod("java.io.FileInputStream", "<init>"),
classAndMethod("java.io.FileOutputStream", "<init>"),
classAndMethod("java.io.RandomAccessFile", "<init>"),
classAndMethod("android.system.Os", "stat"),
),
),
listOf(
classAndMethod("android.app.SharedPreferencesImpl\$EditorImpl", "commit"),
classAndMethod("com.mediatek.res.AsyncDrawableCache", "storeDrawableId"),
classAndMethod("com.mediatek.res.AsyncDrawableCache", "putCacheList"),
classAndMethod("com.mediatek.res.ResOptExtImpl", "putCacheList"),
),
),
)
}

rule {
ofType<DiskWriteViolation>()
allow(
"""
On MediaTek devices, AsyncDrawableCache hooks into Resources.loadDrawable and
synchronously commits to a SharedPreferences-backed cache. The same path also
produces a DiskWriteViolation when the prefs file is written. We anchor this
rule with a concrete write-path frame at the top and the SharedPreferencesImpl
commit frame immediately adjacent to the vendor chain, so it only fires on the
actual prefs-write path inside this vendor caching code.
""".trimIndent(),
)

matchAdjacentFramesInOrder(
listOf(
listOf(
anyOf(
classAndMethod("java.io.FileOutputStream", "<init>"),
classAndMethod("java.io.FileOutputStream", "write"),
classAndMethod("java.io.File", "delete"),
classAndMethod("android.system.Os", "chmod"),
),
),
listOf(
classAndMethod("android.app.SharedPreferencesImpl\$EditorImpl", "commit"),
classAndMethod("com.mediatek.res.AsyncDrawableCache", "storeDrawableId"),
classAndMethod("com.mediatek.res.AsyncDrawableCache", "putCacheList"),
classAndMethod("com.mediatek.res.ResOptExtImpl", "putCacheList"),
),
),
)
}
Comment thread
coderabbitai[bot] marked this conversation as resolved.
Comment thread
coderabbitai[bot] marked this conversation as resolved.
}

/**
Expand Down
Loading