ADFA-3604: Fix Gson model classes and JDI debugger connector stripped by R8

[davidschachterADFA]

Summary

Two more R8 shrink bugs in the ADFA-3604 series (Gson-via-reflection and JDI's ServiceLoader-based connectors -- same root cause as the earlier fixes already on stage: R8 can't trace reflective/ServiceLoader instantiation, so it strips no-arg constructors it thinks are unused).

• Gson model classes (d8b7f3f1d): templates-impl's TemplatesIndex/TemplateJson/etc., plus two more found by auditing every gson.fromJson call site in the repo -- OpenedFilesCache/OpenedFile (had no prior keep rule at all) and the breakpoint persistence models.
• JDI debugger connector (74e27524a): SocketAttachingConnector/SocketListeningConnector stripped, causing java.lang.Error: no Connectors loaded (surfaced on-device as a misleading "Network access error" dialog -- the debug-connect failure handler always appends that suggestion regardless of actual cause). The fix was already anticipated and left commented out in proguard-rules.pro from before shrinking was enabled; just needed uncommenting.
• Comment fix (b4e28fe21): corrected a stale positional reference ("above" -> "below") in a proguard-rules.pro comment from the previous commit.

Test plan

• Verified on-device: JDWP listener starts successfully, no dialog, zero FATAL EXCEPTION in logcat
• Verified on-device: template loading and opened-files-cache persistence work without the "Abstract classes can't be instantiated" error
• :app:assembleV8Release builds clean from this branch and installs/runs without ANRs

Generated with Claude Code

[claude]

Claude Code Review

This repository is configured for manual code reviews. Comment @claude review for a one-time review, or @claude review always to subscribe this PR to a review on every future push.

_{Tip: disable this comment in your organization's Code Review settings.}

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 3206e050-2c28-4787-8132-571450a5a735

📥 Commits

Reviewing files that changed from the base of the PR and between 0fb615a and b4e28fe.

📒 Files selected for processing (1)

• app/proguard-rules.pro

---

📝 Walkthrough

• Added R8 keep rules for Gson-reflected AndroidIDE, LSP debug, and template ZIP model classes.
• Enabled keep rules for JDI socket attaching and listening connectors loaded through ServiceLoader.
• Corrected a stale positional reference in proguard-rules.pro.
• Verified template loading, opened-files-cache persistence, and JDWP listener startup on-device.
• Verified the :app:assembleV8Release build.
• Risk: Package-wide keep rules can increase APK size and reduce shrinking and obfuscation effectiveness.

Walkthrough

The ProGuard configuration now uses package-wide keep rules for AndroidIDE and template ZIP models. It also enables retention rules for com.sun.tools.jdi and com.sun.jdi classes.

Changes

ProGuard keep rules

Layer / File(s)	Summary
Model retention rules app/proguard-rules.pro	Package-wide rules retain AndroidIDE models, LSP debug models, and Gson-deserialized template ZIP models.
JDI retention rules app/proguard-rules.pro	Enabled rules retain com.sun.tools.jdi and com.sun.jdi classes, providers, and constructors during shrinking.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

• appdevforall/CodeOnTheGo#1596: Adjusts targeted R8/ProGuard keep rules in the same configuration file.
• appdevforall/CodeOnTheGo#1610: Contains matching keep-rule changes for Gson models and JDI debugger classes.

Poem

A rabbit checks the shrinking spell,
Models stay where Gson can tell.
JDI classes keep their place,
Providers load with steady grace.
Hop, hop—retention wins!

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly identifies the R8 fixes for Gson model classes and the JDI debugger connector.
Description check	✅ Passed	The description directly explains the Gson and JDI R8 fixes, the comment correction, and the verification results.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch fix/ADFA-3604-gson-jdi-r8-shrink

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}