Skip to content

ADFA-1863 Add SonarQube to the debug build#586

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
hal-eisen-adfa wants to merge 4 commits into from
+33 −2
Closed

ADFA-1863 Add SonarQube to the debug build #586

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ace8887
First attempt at adding SonarQube to the debug build
hal-eisen-adfa Nov 6, 2025
8795367
Exclude keystore from spotless
hal-eisen-adfa Nov 6, 2025
021b4b1
Apply suggestion from @greptile-apps[bot]
hal-eisen-adfa Dec 4, 2025
ed8fe77
Apply suggestions from code review
jomen-adfa Dec 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 19 additions & 0 deletions .github/workflows/debug.yml
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -405,6 +405,25 @@ jobs:

rm -f payload.json

- name: Cache SonarQube packages
uses: actions/cache@v4
with:
path: ~/.sonar/cache
key: ${{ runner.os }}-sonar
restore-keys: ${{ runner.os }}-sonar

- name: Cache Gradle packages
uses: actions/cache@v4
with:
path: ~/.gradle/caches
key: ${{ runner.os }}-gradle-${{ hashFiles('**/*.gradle') }}
restore-keys: ${{ runner.os }}-gradle
Comment on lines +415 to +420

@coderabbitaicoderabbitaiBotDec 25, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

Gradle cache key may miss Kotlin DSL files.

The hash pattern **/*.gradle won't match .gradle.kts files used in this project, potentially causing unnecessary cache misses.

🔎 Proposed fix
 - name: Cache Gradle packages
uses: actions/cache@v4
with:
path: ~/.gradle/caches
- key: ${{ runner.os }}-gradle-${{ hashFiles('**/*.gradle') }}+ key: ${{ runner.os }}-gradle-${{ hashFiles('**/*.gradle', '**/*.gradle.kts', '**/libs.versions.toml') }}
restore-keys: ${{ runner.os }}-gradle
📝 Committable suggestion

‼️IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
- name: Cache Gradle packages
uses: actions/cache@v4
with:
path: ~/.gradle/caches
key: ${{ runner.os }}-gradle-${{ hashFiles('**/*.gradle') }}
restore-keys: ${{ runner.os }}-gradle
- name: Cache Gradle packages
uses: actions/cache@v4
with:
path: ~/.gradle/caches
key: ${{ runner.os }}-gradle-${{ hashFiles('**/*.gradle', '**/*.gradle.kts', '**/libs.versions.toml') }}
restore-keys: ${{ runner.os }}-gradle
🤖 Prompt for AI Agents
In .github/workflows/debug.yml around lines 415 to 420, the Gradle cache key
only hashes **/*.gradle which misses Kotlin DSL files (.gradle.kts) and can
cause cache misses; update the key's hashFiles call to include both patterns
(e.g., hashFiles('**/*.gradle', '**/*.gradle.kts')) so .gradle.kts files are
included in the cache key (optionally also include settings.gradle(.kts) or
other build files as needed).


- name: Build and analyze
env:
SONAR_TOKEN: ${{ secrets.SONAR_TOKEN }}
run: flox activate -d flox/base -- ./gradlew sonar --info

- name: Cleanup google-services.json
if: always()
run: |
Expand Down
14 changes: 12 additions & 2 deletions build.gradle.kts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -42,15 +42,16 @@ plugins {
alias(libs.plugins.rikka.autoresconfig) apply false
alias(libs.plugins.rikka.materialthemebuilder) apply false
alias(libs.plugins.rikka.refine) apply false
alias(libs.plugins.sonarqube)
alias(libs.plugins.spotless)
}

buildscript {
dependencies {
classpath(libs.kotlin.gradle.plugin)
classpath(libs.nav.safe.args.gradle.plugin)
classpath(libs.kotlin.serialization.plugin)
classpath(libs.nav.safe.args.gradle.plugin)
classpath(libs.kotlin.serialization.plugin)
classpath(libs.nav.safe.args.gradle.plugin)
}
}
Comment on lines 49 to 56

@coderabbitaicoderabbitaiBotDec 25, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

Duplicate classpath dependency.

libs.nav.safe.args.gradle.plugin is declared twice (lines 52 and 54). This appears to be a copy-paste error during reordering.

🔎 Proposed fix
 buildscript {
dependencies {
classpath(libs.kotlin.gradle.plugin)
classpath(libs.nav.safe.args.gradle.plugin)
classpath(libs.kotlin.serialization.plugin)
- classpath(libs.nav.safe.args.gradle.plugin)
}
}
📝 Committable suggestion

‼️IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
buildscript {
dependencies {
classpath(libs.kotlin.gradle.plugin)
classpath(libs.nav.safe.args.gradle.plugin)
classpath(libs.kotlin.serialization.plugin)
classpath(libs.nav.safe.args.gradle.plugin)
classpath(libs.kotlin.serialization.plugin)
classpath(libs.nav.safe.args.gradle.plugin)
}
}
buildscript {
dependencies {
classpath(libs.kotlin.gradle.plugin)
classpath(libs.nav.safe.args.gradle.plugin)
classpath(libs.kotlin.serialization.plugin)
}
}
🤖 Prompt for AI Agents
In build.gradle.kts around lines 49 to 56, the dependency
libs.nav.safe.args.gradle.plugin is declared twice (lines 52 and 54); remove the
duplicated classpath entry so the plugin is only declared once (keep the correct
single occurrence and delete the redundant line), then run a quick Gradle
sync/build to verify no further missing plugin references.


Expand DownExpand Up@@ -191,6 +192,7 @@ spotless {
".githooks/**/*",
"scripts/**/*",
)
targetExclude("scripts/debug-keystore/adfa-keystore.jks")
}
}

Expand DownExpand Up@@ -230,3 +232,11 @@ tasks.named<Delete>("clean") {
delete(rootProject.layout.buildDirectory)
}
}

sonar {
properties {
property("sonar.host.url", "https://sonarcloud.io")
property("sonar.projectKey", "appdevforall_CodeOnTheGo")
property("sonar.organization", "app-dev-for-all")
}
}
Comment thread
jomen-adfa marked this conversation as resolved.
2 changes: 2 additions & 0 deletions gradle/libs.versions.toml
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -58,6 +58,7 @@ libsu-core = "6.0.0"
## put it in app/src/main/jniLibs
brotli4j = "1.18.0"
spotless = "7.2.1"
sonarqube = "7.0.0.6105"

@coderabbitaicoderabbitaiBotDec 25, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major

🧩 Analysis chain

🌐 Web query:

SonarQube Gradle plugin org.sonarqube version 7.0.0.6105

💡 Result:

Yes — org.sonarqube version 7.0.0.6105 is a released SonarScanner for Gradle plugin. Key facts:

  • Released/created Oct 14, 2025; advertised as adding support for Gradle 9. [1][2]
  • Published on the Gradle Plugin Portal and available from artifact repositories (org.sonarsource.scanner.gradle:sonarqube-gradle-plugin:7.0.0.6105). [1][3]
  • Community reports of some regressions/bugs with subproject resolution and Gradle 9 in that release. [4]

Sources:
[1] Gradle Plugin Portal — org.sonarqube (version 7.0.0.6105).
[2] SonarSource docs — SonarScanner for Gradle release notes (7.0.0.6105).
[3] Maven / mvnrepository entry for sonarqube-gradle-plugin 7.0.0.6105.
[4] SonarSource community bug reports about 7.0.0.6105.

🌐 Web query:

SonarQube Gradle plugin latest stable version 2024 2025

💡 Result:

The latest stable SonarQube Gradle plugin is 7.2.2.6593 (released Dec 18, 2025). [1][2]

Usage (plugins DSL):
plugins {
id("org.sonarqube") version "7.2.2.6593"
}

Sources: Gradle Plugin Portal and Maven listing. [1][2]

Consider upgrading SonarQube plugin to the latest stable version.

While 7.0.0.6105 is a valid released version, it has known regressions with subproject resolution and Gradle 9 support. The latest stable version is 7.2.2.6593 (released Dec 18, 2025), which should be preferred.

🤖 Prompt for AI Agents
In gradle/libs.versions.toml around line 61, the SonarQube Gradle plugin is
pinned to 7.0.0.6105 which has known regressions; update the version string to
7.2.2.6593 (the latest stable) in that file, then refresh dependencies
(./gradlew --refresh-dependencies) and run a full build and the sonarqube task
to verify compatibility and resolve any deprecation/regression warnings.

fragmentKtx = "1.8.8"

[libraries]
Expand DownExpand Up@@ -273,6 +274,7 @@ kotlin-jvm = { id = "org.jetbrains.kotlin.jvm", version.ref = "kotlin" }
maven-publish = { id = "com.vanniktech.maven.publish.base", version.ref = "maven-publish-plugin" }
gradle-publish = { id = "com.gradle.plugin-publish", version = "1.2.1" }
spotless = { id = "com.diffplug.spotless", version.ref = "spotless" }
sonarqube = { id = "org.sonarqube", version.ref = "sonarqube" }
sentry = { id = "io.sentry.android.gradle", version.ref = "sentry" }
google-services = { id = "com.google.gms.google-services", version.ref = "google-services" }
rikka-autoresconfig = { id = "dev.rikka.tools.autoresconfig", version = "1.2.2" }
Expand Down
Loading