ADFA-1966: Move file operations to background thread

app/src/main/java/com/itsaky/androidide/viewmodels/PluginManagerViewModel.kt

@@ -11,13 +11,15 @@ import com.itsaky.androidide.ui.models.PluginManagerUiEffect
 import com.itsaky.androidide.ui.models.PluginManagerUiEvent
 import com.itsaky.androidide.ui.models.PluginManagerUiState
 import com.itsaky.androidide.ui.models.PluginOperation
+import kotlinx.coroutines.Dispatchers
 import kotlinx.coroutines.channels.Channel
 import kotlinx.coroutines.flow.MutableStateFlow
 import kotlinx.coroutines.flow.StateFlow
 import kotlinx.coroutines.flow.asStateFlow
 import kotlinx.coroutines.flow.receiveAsFlow
 import kotlinx.coroutines.flow.update
 import kotlinx.coroutines.launch
+import kotlinx.coroutines.withContext
 import java.io.File
 import java.io.FileOutputStream
 
@@ -220,24 +222,29 @@ class PluginManagerViewModel(
  _currentOperation.value = PluginOperation.Installing
  _uiState.update { it.copy(isInstalling = true) }
 
+ var tempFile: File? = null
+
  try {
- val inputStream = contentResolver.openInputStream(uri)
- ?: throw Exception("Cannot open file")
-
- // Create temporary file in cache directory (not plugins directory)
- // Get the actual filename from the URI
- val fileName = getFileNameFromUri(uri)
- val extension = if (fileName?.endsWith(".cgp", ignoreCase = true) == true) ".cgp" else ".apk"
- val tempFileName = "temp_plugin_${System.currentTimeMillis()}$extension"
- val tempDir = File(filesDir, "temp")
- tempDir.mkdirs()
- val tempFile = File(tempDir, tempFileName)
-
- // Copy file content
- FileOutputStream(tempFile).use { output ->
- inputStream.use { input ->
- input.copyTo(output)
+ // Move all file I/O to IO dispatcher
+ tempFile = withContext(Dispatchers.IO) {
+ val inputStream = contentResolver.openInputStream(uri)
+ ?: throw Exception("Cannot open file")
+
+ // Create temporary file in cache directory (not plugins directory)
+ // Get the actual filename from the URI
+ val fileName = getFileNameFromUri(uri)
+ val extension = if (fileName?.endsWith(".cgp", ignoreCase = true) == true) ".cgp" else ".apk"
+ val tempFileName = "temp_plugin_${System.currentTimeMillis()}$extension"
+ val tempDir = File(filesDir, "temp").apply { mkdirs() }
+ val tempFile = File(tempDir, tempFileName)
+
+ // Copy file content
+ FileOutputStream(tempFile).use { output ->
+ inputStream.use { input ->
+ input.copyTo(output)
+ }
  }
+ tempFile
  }
 
  // Install using repository
@@ -251,16 +258,20 @@ class PluginManagerViewModel(
  }
  .onFailure { exception ->
  Log.e(TAG, "Failed to install plugin", exception)
- // Clean up temp file on failure
- if (tempFile.exists()) {
- tempFile.delete()
- }
  _uiEffect.trySend(PluginManagerUiEffect.ShowError("Failed to install plugin: ${exception.message}"))
  }
 
  } catch (exception: Exception) {
  Log.e(TAG, "Error installing plugin from URI", exception)
  _uiEffect.trySend(PluginManagerUiEffect.ShowError("Failed to install plugin: ${exception.message}"))
+ } finally {
+ tempFile?.let { file ->
+ withContext(Dispatchers.IO) {
+ if (file.exists()) {
+ file.delete()
+ }
+ }
+ }
  }
 
  _uiState.update { it.copy(isInstalling = false) }

common/src/main/java/com/itsaky/androidide/utils/FeedbackManager.kt

@@ -20,7 +20,9 @@ import androidx.core.text.HtmlCompat
 import androidx.lifecycle.lifecycleScope
 import com.itsaky.androidide.buildinfo.BuildInfo
 import com.itsaky.androidide.resources.R
+import kotlinx.coroutines.Dispatchers
 import kotlinx.coroutines.launch
+import kotlinx.coroutines.withContext
 import org.slf4j.LoggerFactory
 import java.io.File
 import java.io.FileOutputStream
@@ -181,7 +183,7 @@ object FeedbackManager {
 
 
 	fun captureScreenshot(context: Context, callback: (File?) -> Unit) {
- val activity = context as? Activity
+ val activity = context as? AppCompatActivity
  if (activity == null) {
  logger.warn("Cannot capture screenshot: Context is not an Activity")
  callback(null)
@@ -210,14 +212,16 @@ object FeedbackManager {
 	}
 
 	private fun captureWithPixelCopy(
- activity: Activity,
+ activity: AppCompatActivity,
  rootView: View,
  screenshotFile: File,
  callback: (File?) -> Unit
 	) {
 
- runCatching {
- val bitmap = createBitmap(rootView.width, rootView.height)
+ var bitmap: Bitmap? = null
+
+ try {
+ bitmap = createBitmap(rootView.width, rootView.height)
  val locationOfViewInWindow = IntArray(2)
  rootView.getLocationInWindow(locationOfViewInWindow)
 
@@ -232,29 +236,39 @@ object FeedbackManager {
  bitmap,
  { result ->
  if (result == PixelCopy.SUCCESS) {
- saveScreenshot(bitmap, screenshotFile, callback)
- }
+ activity.lifecycleScope.launch {
+ saveScreenshot(bitmap, screenshotFile, callback)
+ }
+ } else {
+ logger.error("PixelCopy failed with result code: $result")
+ bitmap.recycle()
+ callback(null)
+ }
  },
  Handler(Looper.getMainLooper())
  )
- }.onFailure {
- logger.error("PixelCopy exception, falling back to Canvas", it)
+ } catch (e: Exception) {
+ logger.error("PixelCopy exception, falling back to Canvas", e)
+ bitmap?.recycle()
+ callback(null)
  }
 	}
 
 
-	private fun saveScreenshot(bitmap: Bitmap, file: File, callback: (File?) -> Unit) {
- runCatching {
- FileOutputStream(file).use { out ->
- bitmap.compress(Bitmap.CompressFormat.PNG, 90, out)
- }
- bitmap.recycle()
- callback(file)
- }.onFailure {
- logger.error("Failed to save screenshot", it)
- callback(null)
- }
-	}
+ private suspend fun saveScreenshot(bitmap: Bitmap, file: File, callback: (File?) -> Unit) {
+ val result = withContext(Dispatchers.IO) {
+ runCatching {
+ FileOutputStream(file).use { out ->
+ bitmap.compress(Bitmap.CompressFormat.PNG, 90, out)
+ }
+ file
+ }.onFailure {
+ logger.error("Failed to save screenshot", it)
+ }.getOrNull()
+ }
+ bitmap.recycle()
+ callback(result)
+ }
 
 
 	private fun launchIntentChooser(