ADFA-1717: Remove wasted space on keystore generator plugin tab

[Daniel-ADFA]

No description provided.

[coderabbitai]

📝 Walkthrough

• Removed decorative header UI from keystore-generator-plugin:

  • Deleted header LinearLayout (icon + "Keystore Generator" title) and horizontal divider from fragment_keystore_generator.xml.
  • Removed initialization and long-click tooltip registration for the header/editor-tab area in KeystoreGeneratorFragment.kt; headerContainer variable declaration remains.
  • Status/progress section, form fields, and action buttons unchanged and remain functional.

• Tooltip behavior changes:

  • Long-press tooltip on the editor/tab header (category "plugin_keystore_generator", tag "keystore_generator.editor_tab") was removed; generate-button long-press tooltip remains.

• Plugin metadata bumps:

  • apk-viewer-plugin: plugin.version updated 1.0.0 → 1.0.1 (AndroidManifest.xml).
  • keystore-generator-plugin: plugin.version updated 1.0.2 → 1.0.3 (AndroidManifest.xml).

Risks & considerations

• Documentation/help regression: Removing the header long-press tooltip eliminates an in-place help/discovery mechanism for the "editor_tab" documentation. Provide alternate access to this documentation if users rely on it (e.g., help menu, inline hints, or reattach tooltip to another anchor).
• User discoverability: Without the header title/icon, users may be less certain they are in the Keystore Generator when the tab title is not visible.
• Dead code: headerContainer remains declared (private lateinit var headerContainer) but is no longer initialized or used; this is dead code and should be removed to avoid confusion and potential crashes if referenced later.
• Layout validation: Verify rendering across screen sizes and orientations to ensure no unexpected spacing or constraint regressions after header removal.
• Versioning audit: Confirm plugin version bumps follow release policy and that dependent tooling or marketplaces are updated accordingly.

Walkthrough

Removed the header UI and its runtime initialization/tooltip from the keystore generator fragment, and bumped plugin version metadata in two AndroidManifest files.

Changes

Cohort / File(s)	Summary
Keystore generator UI keystore-generator-plugin/src/main/kotlin/com/appdevforall/keygen/plugin/fragments/KeystoreGeneratorFragment.kt, keystore-generator-plugin/src/main/res/layout/fragment_keystore_generator.xml	Removed headerContainer initialization and its long‑click tooltip setup in Kotlin; removed header LinearLayout (ImageView, TextView) and the horizontal divider from the fragment layout.
Plugin version updates apk-viewer-plugin/src/main/AndroidManifest.xml, keystore-generator-plugin/src/main/AndroidManifest.xml	Updated meta-dataplugin.version values: apk-viewer-plugin 1.0.0 → 1.0.1; keystore-generator-plugin 1.0.2 → 1.0.3.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

• ADFA-1718: Add Material 3 theme support and IdeThemeService for plugins  #937 — Modifies KeystoreGeneratorFragment.kt UI behavior (related header/tooltip changes).

Suggested reviewers

• hal-eisen-adfa
• jatezzz

Poem

"I hopped through code with nimble paws,
A header hid without a cause.
Tooltip gone, the view feels light,
Versions climbed — a tiny flight.
🐇✨"

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name	Status	Explanation	Resolution
Description check	❓ Inconclusive	No pull request description was provided by the author, making it impossible to evaluate relevance to the changeset.	Add a description explaining the rationale for removing the header UI elements and any related context or testing performed.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Title check	✅ Passed	The pull request title directly addresses the main change: removing header UI elements and their associated code to eliminate wasted space in the keystore generator plugin tab.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch ADFA-1717

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[hal-eisen-adfa]

LGTM

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@apk-viewer-plugin/src/main/AndroidManifest.xml`:
- Line 19: The apk-viewer-plugin AndroidManifest shows an unrelated version bump
(android:value="1.0.1") — revert this change so plugin.version returns to
"1.0.0" unless you intended to release APK Viewer; locate the android:value
attribute in apk-viewer-plugin's AndroidManifest.xml and change it back to the
original "1.0.0" (or add a clear justification comment/commit message if the
bump is intentional).