Uh oh!
There was an error while loading. Please reload this page.
ADFA-5184 fix(web): correct the "server not responding" banner copy - #487
Merged
Conversation
…/ADFA-5184-backend-error-copy
New wording per review: 'Make sure K2Go is running on the host device, and that your device is on the same Wi-Fi or connected to its hotspot.' Covers both the shared-Wi-Fi and own-hotspot cases and fixes the K2GO/K2Go casing. EN + 33 locales + index.html span.
…/ADFA-5184-backend-error-copy
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the served landing page's "backend not responding" banner, which gave
wrong and outdated guidance, per ADFA-5184.
The banner told the user to open Termux and run
iiab-termux --start. That'swrong on two counts: it assumes the only cause is a stopped server (the server
may simply be starting up, or its hotspot/address changed), and Termux was
dropped two iterations ago, so the command no longer applies. It's also aimed at
the host, but the banner is what a guest sees.
What changes (copy only, no logic):
backend_errorstring: neutral wording that doesn't assume a singlecause, states the page reconnects on its own (the JS already polls every 5–60 s
and self-heals), and points to rescanning the code if the address changed.
iiab-termux --startline from index.html.New copy:
"The K2Go server isn't responding. Make sure K2Go is running on the host
device; the page reconnects on its own. If it doesn't come back, rescan the
code to get its current address."
Scope: static/site only (index.html + lang/*.js). No app/native change.
l10n: default + 32 locales. Locale strings are machine-translated, pending native
review for bn/gu/ta/sw/az/yo/sr.
Verification:
node --checkpasses on all 33 lang files; no "termux" referenceremains under static/site. Renders on-device after a rootfs rebuild (the served
site ships in the rootfs).