Uh oh!
There was an error while loading. Please reload this page.
ADFA-5018 | Open Agent settings from IDE Preferences - #60
Merged
Conversation
There was a problem hiding this comment.
Claude Code Review
This repository is configured for manual code reviews. Comment @claude review for a one-time review, or @claude review always to subscribe this PR to a review on every future push.
Tip: disable this comment in your organization's Code Review settings.
jatezzz
requested review from
a team, Daniel-ADFA, dara-abijo-adfa, hal-eisen-adfa and itsaky-adfaAugust 5, 2026 14:35
jatezzzforce-pushed
the
feat/ADFA-5018-agent-settings-in-preferences
branch
from
August 5, 2026 16:06
75e9282 to
494a93bCompareContributor
Do we have to finish ADFA-5017 before we proceed here? |
jatezzz
commented
Aug 6, 2026
ContributorAuthor
@hal-eisen-adfa Yes, ADFA-5017 includes the API extension for this feature |
Daniel-ADFA
approved these changes
Aug 6, 2026
jatezzzforce-pushed
the
feat/ADFA-2709-gemini-key-onboarding
branch
from
August 6, 2026 15:39
f325cd9 to
8015675Comparejatezzzforce-pushed
the
feat/ADFA-5018-agent-settings-in-preferences
branch
2 times, most recently
from
August 6, 2026 16:14
5bd0786 to
627a70dComparejatezzzforce-pushed
the
feat/ADFA-2709-gemini-key-onboarding
branch
from
August 6, 2026 17:29
894abb5 to
38b0b74Comparejatezzzforce-pushed
the
feat/ADFA-5018-agent-settings-in-preferences
branch
from
August 6, 2026 17:29
627a70d to
ab81c13CompareContributes an Agent row to Preferences -> Configuration and turns the settings dialog into a full-screen fragment; the chat's shortcuts open the same screen.
jatezzzforce-pushed
the
feat/ADFA-5018-agent-settings-in-preferences
branch
from
August 6, 2026 18:47
ab81c13 to
121fe28Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
What:
Migrated the AI Agent's settings from a floating chat dialog to a full-screen view accessible directly from the IDE's Preferences, while retaining the existing in-chat shortcut.
How:
SettingsExtensioninAiAssistantPlugin.ktto inject the Agent settings row under Preferences → Configuration → Agent.AiSettingsFragmentfrom aDialogFragmentto a standardFragmentso it can be mounted full-screen by the host'sPluginScreenActivity.ChatFragment.ktto launch the settings viaIdeUIService.openPluginScreen()instead of displaying a local dialog fragment.fragment_ai_settings.xml) to match standard Preferences styling, including theme-aware backgrounds and a back arrow replacing the close button.strings.xmlfor proper localization and updated documentation references.Why:
To make AI configuration discoverable for users configuring the IDE before opening a project, removing a dead end when the agent fails due to missing keys, and unifying the settings UI into a single, consistent implementation.
Details
UI Changes: The settings screen now uses standard IDE header colors, a back arrow (
ic_arrow_back.xml), and standard title placement. It fully respects the IDE's light and dark themes viaPluginFragmentHelper.Logic Changes: The back button now finishes the host activity instead of dismissing a dialog. Lifecycle management in
ChatFragmentnow relies on the standardonResume()callback rather than custom fragment result listeners to refresh backend availability.document_5159000787652708101.mp4
Ticket
ADFA-5018