Uh oh!
There was an error while loading. Please reload this page.
Use the latest official ECJ 3.14.0 - #1024
Merged
Merged
Conversation
| dependencies { | ||
| ecj 'org.eclipse.jdt.core.compiler:ecj:4.6.1' | ||
| ecj 'org.eclipse.jdt:ecj:3.14.0' |
Contributor
There was a problem hiding this comment.
Do we need the whole package?
CollaboratorAuthor
There was a problem hiding this comment.
It seems, there are no other options.
In general, I'm not aware of historical reasons of ECJ usage, in theory simple javac can work as well.
Contributor
There was a problem hiding this comment.
javac cannot compile the solution and SeleniumHQ/selenium#863 is the main reason why it cannot
mykola-mokhnach
commented
Sep 19, 2018
Contributor
It looks like Travis is not very happy: https://travis-ci.org/appium/java-client/jobs/430697234 |
valfirst
commented
Sep 19, 2018
CollaboratorAuthor
It looks like some travis issue, similar to this one: travis-ci/travis-ci#3795. https://travis-ci.org/appium/java-client/jobs/430697234#L817: I'll touch the commit to trigger a new build |
The old ECJ reference was bogus (see official confirmation: https://bugs.eclipse.org/bugs/show_bug.cgi?id=499019#c19) and didn't work properly with JDK9
mykola-mokhnach
approved these changes
Sep 19, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change list
Use the latest official ECJ 3.14.0
Types of changes
Details
The old ECJ reference was bogus (see official confirmation: https://bugs.eclipse.org/bugs/show_bug.cgi?id=499019#c19) and didn't work properly with JDK9