Skip to content

#320 fix - #327

Merged
TikhomirovSergey merged 1 commit into
appium:masterfrom
TikhomirovSergey:#320-fix
Mar 2, 2016
Merged

#320 fix#327
TikhomirovSergey merged 1 commit into
appium:masterfrom
TikhomirovSergey:#320-fix

Conversation

@TikhomirovSergey

Copy link
Copy Markdown
Contributor

Changes:

  • 320 fix. The Widget.getSelfReference() was added. This method allows to extract a real widget-object from inside a proxy at some extraordinary situations.

  • test modification

This change is the addition to features whis heve been implemented here: #267. There was a problem:

This use case has some restrictions;
...

  • for now it is not possible to
importio.appium.java_client.pagefactory.OverrideWidget;
...
//above is the other field declaration@OverrideWidget(html = UsersWidgetForHtml.class, androidUIAutomator = UsersWidgetForAndroid.class, iOSUIAutomation = UsersWidgetForIOS .class)
DefaultAbstractUsersWidgetwidget;
//below is the other field/method declaration//user's code
((UsersWidgetForAndroid) widget).doSpecialWorkForAndroing()

I think that this problem will be resolved next time.

So this commit resolves this issie and related problems this way:

importio.appium.java_client.pagefactory.OverrideWidget;
...
//above is the other field declaration@OverrideWidget(html = UsersWidgetForHtml.class, androidUIAutomator = UsersWidgetForAndroid.class, iOSUIAutomation = UsersWidgetForIOS .class)
DefaultAbstractUsersWidgetwidget;
//below is the other field/method declaration//user's code
((UsersWidgetForAndroid) widget.getSelfReference()).doSpecialWorkForAndroing()

Changes:
- #320 fix. The Widget.getSelfReference() was added. This method allows to extract a real widget-object from inside a proxy at some extraordinary situations.
- test modification
@TikhomirovSergey

Copy link
Copy Markdown
ContributorAuthor

@SergeyErmakovMercDev could you take a look at this PR?

@SButterfly

Copy link
Copy Markdown

@TikhomirovSergey well, how can I download source code with pull request?

@SButterfly

Copy link
Copy Markdown

I looked, and It works. Thanks.
BTW. I still don't know how to checkout to pull requests.

TikhomirovSergey added a commit that referenced this pull request Mar 2, 2016
@SButterfly
You can:
- switch to your java_client fork using git
- > git checkout -b your_new_branch_name master
- > git pull https://github.com/User_Name/java-client.git target_branch
But now you can clone master
@TikhomirovSergey
TikhomirovSergey merged commit 9224b8d into appium:masterMar 2, 2016
@TikhomirovSergey

Copy link
Copy Markdown
ContributorAuthor

@SButterfly

You can:

But now you can clone master

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@TikhomirovSergey@SButterfly