Skip to content

Rotation support. - #439

Closed
rafe-g wants to merge 1 commit into
appium:masterfrom
rafe-g:master
Closed

Rotation support.#439
rafe-g wants to merge 1 commit into
appium:masterfrom
rafe-g:master

Conversation

@rafe-g

@rafe-grafe-g commented Jul 16, 2016•
edited
Loading

Copy link
Copy Markdown
Contributor

Change list

Please provide briefly described change list which are you going to propose.

Types of changes

What types of changes are you proposing/introducing to Java client?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Details

Please provide more details about changes if it is necessary. If there are new features you can provide code samples which show the way they
work and possible use cases. Also you can create gists with pasted java code samples or put them here using markdown.
About markdown please read Mastering markdown and Writing on GitHub

@rafe-g

rafe-g commented Jul 16, 2016

Copy link
Copy Markdown
ContributorAuthor

@TikhomirovSergey

rafe-g
rafe-g reviewed Jul 16, 2016
View reviewed changes
Comment threadsrc/main/java/io/appium/java_client/AppiumDriver.java

@Override
public DeviceRotation rotation() {
Response response = execute(DriverCommand.GET_SCREEN_ROTATION);

@rafe-grafe-gJul 16, 2016

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah sorry let me update this, forgot to commit this part.

@TikhomirovSergey

TikhomirovSergey commented Jul 16, 2016•
edited
Loading

Copy link
Copy Markdown
Contributor

Hi @Rafael-Chavez
I have found the PR that you proposed to Selenium
SeleniumHQ/selenium#2474

@TikhomirovSergey

TikhomirovSergey commented Jul 16, 2016•
edited
Loading

Copy link
Copy Markdown
Contributor

Ok, Firstly
Could you get fixed the issue which has been found by codecy?

TikhomirovSergey
TikhomirovSergey reviewed Jul 16, 2016
View reviewed changes
Comment threadpom.xml
</dependency>
<dependency>
<groupId>org.seleniumhq.selenium</groupId>
<artifactId>selenium-java</artifactId>

@TikhomirovSergeyTikhomirovSergeyJul 16, 2016

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did you remove this?

@TikhomirovSergey

TikhomirovSergey commented Jul 16, 2016•
edited
Loading

Copy link
Copy Markdown
Contributor

It is interesting.
I think it is great to have a feature like that. But there are problems

  • The Selenium Java clint still doesn't contain the DeviceRotation class. Maybe it has sense to add that class to the Appium java clent?
  • are you sure that Appium server supports this command? Please take a look at that string. @imurchie@jlipps Could you clarify what does this command do? If there is no such get/set command then I think it makes sense to implement them on the server side.

ping @SrinivasanTarget

@rafe-g
rafe-gforce-pushed the master branch 3 times, most recently from e3a034f to c9db0baCompareJuly 17, 2016 07:37
rafe-g
rafe-g reviewed Jul 17, 2016
View reviewed changes
Comment threadsrc/main/java/io/appium/java_client/AppiumDriver.java

@Override
public DeviceRotation rotation() {
Response response = execute(DriverCommand.GET_SCREEN_ROTATION);

@rafe-grafe-gJul 17, 2016

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The variable is being used.

@SrinivasanTarget

SrinivasanTarget commented Jul 18, 2016

Copy link
Copy Markdown
Member

It's really a cool feature 👍 I see we have this endpoint implemented only in appium-ios-driver here https://github.com/appium/appium-ios-driver/blob/master/lib/commands/gesture.js#L63

@rafe-g

rafe-g commented Jul 18, 2016

Copy link
Copy Markdown
ContributorAuthor

@SrinivasanTarget actually the link you pasted is for the endpoint /rotate

the mobile spec defines a /rotation endpoint. Maybe a good idea to merge these two? im not sure what spec this mobileRotation command was adhering to. Maybe @jlipps@imurchie can give more details?

@rafe-g

rafe-g commented Jul 18, 2016

Copy link
Copy Markdown
ContributorAuthor

@TikhomirovSergey DeviceRotation class is proposed to be part of selenium project.
SeleniumHQ/selenium#2482

@rafe-g
rafe-gforce-pushed the master branch 5 times, most recently from b39f2d0 to c38451eCompareJuly 19, 2016 00:41
@rafe-g

rafe-g commented Jul 19, 2016•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

@TikhomirovSergey@SrinivasanTarget i updated the routes in the appium server to support this command. The selenium pull request has been merged already.

@TikhomirovSergey

TikhomirovSergey commented Jul 21, 2016•
edited
Loading

Copy link
Copy Markdown
Contributor

@Rafael-Chavez Ok. It will be merged when it will be available in selenium. Are you agree?

@rafe-g

rafe-g commented Jul 21, 2016•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

you mean on the next selenium release?

@TikhomirovSergey

TikhomirovSergey commented Jul 21, 2016

Copy link
Copy Markdown
Contributor

Yes

@SrinivasanTargetSrinivasanTarget mentioned this pull request Oct 12, 2016
Merged
3 tasks
@SrinivasanTarget

SrinivasanTarget commented Oct 15, 2016

Copy link
Copy Markdown
Member

Closing this in favor of #489

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

on hold

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@rafe-g@TikhomirovSergey@SrinivasanTarget