Android setting engine

[TikhomirovSergey]

Change list

• io.appium.java_client.AppiumSetting became deprecated. It was moved to io.appium.java_client.android.Setting.
• the method io.appium.java_client.AppiumDriver#getSettings() was completely moved to io.appium.java_client.android.AndroidDriver.
• the new interface io.appium.java_client.android.HasSettings was added. It has default implementation. And this interface is implemented by AndroidDriver.
  Methods:
  • void setSetting(Setting setting, Object value)
  • JsonObject getSettings()
  • void ignoreUnimportantViews(Boolean compress)
  • void configuratorSetWaitForIdleTimeout(int timeout)
  • void configuratorSetWaitForSelectorTimeout(int timeout)
  • void configuratorSetScrollAcknowledgmentTimeout(int timeout)
  • void configuratorSetKeyInjectionDelay(int delay)
  • void configuratorSetActionAcknowledgmentTimeout(int timeout)
    This change was proposed at add support to set UiAutomator Congfigurator values #410 by @truebit

Types of changes

What types of changes are you proposing/introducing to Java client?
Put an x in the boxes that apply

• Bugfix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
  Windows Mobile automation support.  #471

[TikhomirovSergey]

@SrinivasanTarget@truebit
Could you review this PR?

[SrinivasanTarget]

I like the changes 👍 LGTM

[truebit]

the settings api has been changed to top level as requested by @jlipps in appium/appium-android-driver#153
you could find the doc in https://github.com/truebit/appium/blob/master/docs/en/advanced-concepts/settings.md#supported-settings

So these settings api requests should be the same like ignoreUnimportantViews in top level instead of configurator/xxxTimeout

[TikhomirovSergey]

@truebit
Yes and proposed code actualy does that:
https://github.com/appium/java-client/pull/477/files#diff-7daaa6d2742d959db92558292282ea56R41
https://github.com/appium/java-client/pull/477/files#diff-7daaa6d2742d959db92558292282ea56R78
https://github.com/appium/java-client/pull/477/files#diff-cebdf3eaee01b491314c7101b3103f7bR298
https://github.com/appium/java-client/blob/master/src/main/java/io/appium/java_client/MobileCommand.java#L92

Isn't it?

[truebit]

no, this code is still the two level configurator. Now it should be like ignoreUnimportantViews. Every setting here for configurators should be individivual

[truebit]

all below settings are at same level like ignoreUnimportantViews. there is no 'configurator' sub setting

"actionAcknowledgmentTimeout" - Int which is the same as setActionAcknowledgmentTimeout. If a negative value is given, it would set to default(3 * 1000 milliseconds)

"keyInjectionDelay" - Int which is the same as setKeyInjectionDelay. If a negative value is given, it would set to default(0 milliseconds)

"scrollAcknowledgmentTimeout" - Int which is the same as setScrollAcknowledgmentTimeout. If a negative value is given, it would set to default(200 milliseconds)

"waitForIdleTimeout" - Int which is the same as setWaitForIdleTimeout. If a negative value is given, it would set to default(10 * 1000 milliseconds)

"waitForSelectorTimeout" - Int which is the same as setWaitForSelectorTimeout. If a negative value is given, it would set to default(10 * 1000 milliseconds)

[TikhomirovSergey]

Ok. Will iptrove this a bit later.