Remove console output from AppiumDriverLocalService by default

[Mygod]

Change list

Remove console output from AppiumDriverLocalService by default.

Types of changes

• Bugfix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)

Details

Reason: I need to use System.out to print some less verbose output. And user can easily turn it back on by calling addOutPutStream.

However the other way around is hard. Here's what I'm currently using.

 try {
streamField = AppiumDriverLocalService.class.getDeclaredField("stream");
streamField.setAccessible(true);
streamsField = Class.forName("io.appium.java_client.service.local.ListOutputStream")
.getDeclaredField("streams");
streamsField.setAccessible(true);
} catch (ClassNotFoundException | NoSuchFieldException e) {
e.printStackTrace();
}
try {
((ArrayList<OutputStream>) streamsField.get(streamField.get(service))).clear(); // remove System.out logging
} catch (IllegalAccessException e) {
e.printStackTrace();
}

[alexander-poulikakos]

I fully agree on this PR. We should not log to System.out by default.

[SrinivasanTarget]

@TikhomirovSergey ping

[jeangb]

Hi, this looks very interesting.
Any news on this ?

[jsf-clabot]

All committers have signed the CLA.

[Mygod]

@jeangb Meanwhile you can still use the workaround mentioned in the PR to get rid of the console output.

[jeangb]

Thank you @Mygod, in what class this workaround take place ?

[Mygod]

@jeangb Just whenever you create a AppiumDriverLocalService, do this on that object.

[jeangb]

@Mygod great, thx

[selenUser]

@Mygod which type is streamField ? (which import should I do ?)

[Mygod]

@selenUser

streamField = AppiumDriverLocalService.class.getDeclaredField("stream");

It's a Field in reflection. :)

[drapostolos]

Perhaps this can be merged to master and released? To avoid workarounds...

[jeangb]

Do you think it would be possible to redirect this stream to an other view that console, in Eclipse. For example this view could be called Server.

[VenkateshPS]

Thanks @Mygod the workaround saved me.

[mykola-mokhnach]

#909

[Prasannajnaeyulu]

This is where one can find the workaround until the appium server with this changes is released
element-hq/riot-automated-tests@73677dd