Addition to #545 by SrinivasanTarget · Pull Request #546 · appium/java-client

SrinivasanTarget · 2016-12-25T11:01:25Z

Change list

Added Tests for iOS XCUIT mode.
Gradle publish tasks are updated

Types of changes

What types of changes are you proposing/introducing to Java client?
Put an x in the boxes that apply

No changes in production code.
Bugfix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)

@TikhomirovSergey FYI

- new annotations were provided - supporting tools were actualized

…a-client into TikhomirovSergey-xcuitFindBy

SrinivasanTarget · 2016-12-25T11:08:20Z

@TikhomirovSergey I see this is first time javadoc task is running in Travis job :) Its because of javadoc task refractor in build.gradle file :)

TikhomirovSergey · 2016-12-25T13:11:49Z

@SrinivasanTarget The travis build is failed

SrinivasanTarget · 2016-12-25T13:13:08Z

Yeah I have to find a way to ignore signing in Travis.

…

On Sun 25 Dec, 2016, 6:41 PM Sergey Tikhomirov, ***@***.***> wrote: @SrinivasanTarget <https://github.com/SrinivasanTarget> The travis build is failed — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#546 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AIfAJSvJxJZ56SQZ_P1l_nNG2Dvatbutks5rLmuWgaJpZM4LVYoy> .

TikhomirovSergey · 2016-12-25T13:13:33Z

+
+import java.io.File;
+
+public class AppXCUITTest extends BaseIOSTest {


TikhomirovSergey · 2016-12-25T13:20:43Z

+
+ @iOSXCUITFindBy(className = "XCUIElementTypeSlider")
+ private MobileElement slider;
+


@SrinivasanTarget
Everything is ok. But I think coverage could be enhanced. There is no case like
@iOSFindBy(id = "someId") privateMobileElementfoundLikeIOSId;
because I think some locators (like "id") are compatible with both modes. It similar to the test of the selendroid mode.

TikhomirovSergey · 2016-12-25T13:22:03Z

@SrinivasanTarget Everything is ok but could you provide one more test as it was mentioned in remarks?

SrinivasanTarget · 2016-12-25T13:23:08Z

Sure will do that :)

…

On Sun 25 Dec, 2016, 6:52 PM Sergey Tikhomirov, ***@***.***> wrote: @SrinivasanTarget <https://github.com/SrinivasanTarget> Everything is ok but could you provide one more test as it was mentioned in remarks? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#546 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AIfAJehhrhL11VKAPYF2RQv8IkB3Zaolks5rLm38gaJpZM4LVYoy> .

TikhomirovSergey · 2016-12-25T13:29:07Z

+
+ @iOSXCUITFindBy(className = "XCUIElementTypeSlider")
+ private MobileElement slider;
+


@SrinivasanTarget
Also you could add this test
@iOSFindBy(iOSAutomation = "some searching script") @iOSXCUITFindBy(iOSNsPredicate = "some predicate") //it should be used for the searching instead of //@iOSFindByprivateMobileElementfoundByScript;

@SrinivasanTarget @TikhomirovSergey when we initialize IOSDriver and provide the XCUITest as AutomationName only this case will it pick the iOSXCUITFindBy ?

@saikrishna321 When there is only java @iOSFindBy then it will be used.
When there are
@iOSFindBy@iOSXCUITFindBy
then java @iOSXCUITFindBy will be preferred. Selendroid mode works the same way.

@TikhomirovSergey it works that way in Selendroid, coz the automatioName is set to selendroid. It should be the same here as well, if the automatioName is set to XCUITest only then @iOSXCUITFindBy should be preferred. Thoughts ?

@saikrishna321 Yes you are correct. Btw for iOS10 automationName is not mandatory, server will set automatically even if you have given platformVersion.

@saikrishna321 I can't get...
It is designed the same way as java @AndroidFindBy/java @SelendroidFindBy. It was designed this way because it is possible that old automation for iOS <= 9.3 and the new automation should be supported by one test scope.
The algorithm:
@iOSFindBy@iOSXCUITFindBy
if you run new mode then
@iOSXCUITFindBy
is used. If you use legacy mode then
@iOSFindBy
is used instead.
@iOSFindBy
is used by both modes.
@iOSXCUITFindBy
is used by the new mode. If you launch legacy mode then page object tools create
ByIdOrName
The same works for Android/Selendroid.
So what the concern?

@TikhomirovSergey no concern, well explained. Cheers

TikhomirovSergey · 2016-12-25T13:29:56Z

@SrinivasanTarget
There is one more remark

SrinivasanTarget · 2016-12-25T18:00:55Z

Codacy is GREEN now. Will try to fix travis.

TikhomirovSergey · 2016-12-26T07:46:10Z

@SrinivasanTarget Yes. Everything is ok. Please get build successful

SrinivasanTarget · 2016-12-26T09:54:20Z

@TikhomirovSergey Yeah Sure.Its weird. I don't see travis running our command. Command works locally fine.

SrinivasanTarget · 2016-12-26T10:04:59Z

@TikhomirovSergey Travis is GREEN now. Its running our commands now. Moved it to run under container based infra.

SrinivasanTarget · 2016-12-26T13:48:54Z

Linking gists justs for internal reference: iOS 10 - https://gist.github.com/SrinivasanTarget/a75db7dfcff1e237ae6ad9919ffa8219
iOS 9 - https://gist.github.com/SrinivasanTarget/07046e5208cc431f7d81f19c7d3e663c

SrinivasanTargetand others added 5 commits December 20, 2016 23:55

Gradle Publish
c0c4659

Update Page object tools to XCUIT mode
5177f52
- new annotations were provided - supporting tools were actualized

naming was fixed + bugfix
028dbd6

Merge branch 'xcuitFindBy' ofhttps://github.com/TikhomirovSergey/jav…
2dacb1f
…a-client into TikhomirovSergey-xcuitFindBy

Addition to#545
a6b4dbe

SrinivasanTarget requested a review from TikhomirovSergey December 25, 2016 11:01

SrinivasanTarget self-assigned this Dec 25, 2016

SrinivasanTarget added the testing label Dec 25, 2016

SrinivasanTarget added this to the 5.0.0 milestone Dec 25, 2016

SrinivasanTarget added iOS refactor labels Dec 25, 2016

SrinivasanTarget added 2 commits December 25, 2016 16:45

Fixed javaDoc errors
8bb5d23

Exclude signing in travis
1d86df0

TikhomirovSergey approved these changes Dec 25, 2016
View reviewed changes

TikhomirovSergey suggested changes Dec 25, 2016
View reviewed changes

Increased test coverage
befa115

TikhomirovSergey approved these changes Dec 26, 2016
View reviewed changes

added travis config
e345ba3

added travis config
6bd6184

TikhomirovSergey merged commit 6fa95e0 into appium:masterDec 27, 2016

SrinivasanTarget deleted the TikhomirovSergeyXCUITFindBy branch February 25, 2017 19:08


		import java.io.File;

		public class AppXCUITTest extends BaseIOSTest {


		@iOSXCUITFindBy(className = "XCUIElementTypeSlider")
		private MobileElement slider;

Uh oh!

Uh oh!

Conversation

SrinivasanTarget commented Dec 25, 2016• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Change list

Types of changes

Uh oh!

SrinivasanTarget commented Dec 25, 2016

Uh oh!

TikhomirovSergey commented Dec 25, 2016

Uh oh!

SrinivasanTarget commented Dec 25, 2016 via email

Uh oh!

TikhomirovSergeyDec 25, 2016

Choose a reason for hiding this comment

Uh oh!

TikhomirovSergeyDec 25, 2016

Choose a reason for hiding this comment

Uh oh!

TikhomirovSergey commented Dec 25, 2016

Uh oh!

SrinivasanTarget commented Dec 25, 2016 via email

Uh oh!

TikhomirovSergeyDec 25, 2016• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

saikrishna321Dec 26, 2016

Choose a reason for hiding this comment

Uh oh!

TikhomirovSergeyDec 26, 2016

Choose a reason for hiding this comment

Uh oh!

saikrishna321Dec 26, 2016

Choose a reason for hiding this comment

Uh oh!

SrinivasanTargetDec 26, 2016• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

TikhomirovSergeyDec 26, 2016• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

saikrishna321Dec 26, 2016

Choose a reason for hiding this comment

Uh oh!

TikhomirovSergey commented Dec 25, 2016

Uh oh!

SrinivasanTarget commented Dec 25, 2016

Uh oh!

TikhomirovSergey commented Dec 26, 2016

Uh oh!

SrinivasanTarget commented Dec 26, 2016

Uh oh!

SrinivasanTarget commented Dec 26, 2016

Uh oh!

SrinivasanTarget commented Dec 26, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

SrinivasanTarget commented Dec 25, 2016•
edited
Loading

TikhomirovSergeyDec 25, 2016•
edited
Loading

SrinivasanTargetDec 26, 2016•
edited
Loading

TikhomirovSergeyDec 26, 2016•
edited
Loading