Skip to content

#549 FIX - #551

Merged
TikhomirovSergey merged 1 commit into
appium:masterfrom
TikhomirovSergey:master
Jan 2, 2017
Merged

#549 FIX#551
TikhomirovSergey merged 1 commit into
appium:masterfrom
TikhomirovSergey:master

Conversation

@TikhomirovSergey

@TikhomirovSergeyTikhomirovSergey commented Jan 1, 2017

Copy link
Copy Markdown
Contributor

Change list

  • ByChained was re-implemented. Now it fairly searches for a single element when it is required
  • AppiumElementLocator refactoring
  • new tests were provided

Types of changes

  • No changes in production code.
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Details

#549 FIX

@TikhomirovSergeyTikhomirovSergey added this to the 5.0.0 milestone Jan 1, 2017
@TikhomirovSergeyTikhomirovSergey self-assigned this Jan 1, 2017
@TikhomirovSergey

TikhomirovSergey commented Jan 1, 2017

Copy link
Copy Markdown
ContributorAuthor

@saikrishna321 Could you review this PR too? Also it would be cool if you built the jar using these changes and tried to reproduce the issue/confirm that it is resolved on your app?

@saikrishna321

saikrishna321 commented Jan 2, 2017

Copy link
Copy Markdown
Member

@TikhomirovSergey not able to build locally

FAILURE: Build failed with an exception.
* What went wrong:
Error while evaluating property 'signatory' of task ':signArchives'
> Unable to retrieve secret key from key ring file '/Users/saikrisv/git/java_client_pr/java-client/PathToYourKeyRingFile' as it does not exist

@SrinivasanTarget

SrinivasanTarget commented Jan 2, 2017

Copy link
Copy Markdown
Member

@saikrishna321 You can exclude it ./gradlew clean build -x test -x signArchives

@saikrishna321

saikrishna321 commented Jan 2, 2017

Copy link
Copy Markdown
Member

@TikhomirovSergey still the issue exists. Please find the logs

https://gist.github.com/saikrishna321/b66af4ac3659a9e4b0300db959c7e2af

its calling elements again https://gist.github.com/saikrishna321/b66af4ac3659a9e4b0300db959c7e2af#file-pr_fix-L467

@TikhomirovSergey
#549FIX
b5acb64
- ByChained was re-implemented. Now it fairly searches for a single element when it is required
- AppiumElementLocator refactoring
- new tests were provided
@TikhomirovSergey

TikhomirovSergey commented Jan 2, 2017•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

@saikrishna321
Yes. I have got it fixed now. I hope this is the final commit. There is my last server output
https://gist.github.com/TikhomirovSergey/3306fb9ef7e4c544a34a67a142782674

Please build it and try it again on your app. I am waiting for your response.

@saikrishna321

saikrishna321 commented Jan 2, 2017

Copy link
Copy Markdown
Member

@TikhomirovSergey sure trying now ..

@saikrishna321

saikrishna321 commented Jan 2, 2017•
edited
Loading

Copy link
Copy Markdown
Member

@TikhomirovSergey Thanks it is working fine now :) can merge this .. will raise further issues if i get through with page objects

@TikhomirovSergey

TikhomirovSergey commented Jan 2, 2017

Copy link
Copy Markdown
ContributorAuthor

@saikrishna321 Ok. I'm going to publish 5.0.0-BETA2 soon. For now you can use the built shapshot instead.

@TikhomirovSergey
TikhomirovSergey merged commit a45dff7 into appium:masterJan 2, 2017
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SrinivasanTargetSrinivasanTargetSrinivasanTarget approved these changes

Assignees

@TikhomirovSergeyTikhomirovSergey

Labels

bugrefactor

Projects

None yet

Milestone

5.0.0

Development

Successfully merging this pull request may close these issues.

3 participants

@TikhomirovSergey@saikrishna321@SrinivasanTarget